[GitHub] tinkerpop pull request #679: TINKERPOP-1679: Detached side-effects aren't at...

2017-07-20 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/679 TINKERPOP-1679: Detached side-effects aren't attached when remoted https://issues.apache.org/jira/browse/TINKERPOP-1679 This was occurring because Gremlin-Python did not have serial

[GitHub] tinkerpop issue #677: TINKERPOP-1729: Remove deprecated select steps.

2017-07-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/677 Yes -- tested again to be safe. ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop issue #675: Ensure serializers iteration is consistent

2017-07-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/675 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #678: TINKERPOP-1715: update spark version to 2.2

2017-07-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/678 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #677: TINKERPOP-1729: Remove deprecated select steps.

2017-07-14 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/677 TINKERPOP-1729: Remove deprecated select steps. https://issues.apache.org/jira/browse/TINKERPOP-1729 There is no point is crying over spilled milk. The deed is done. It had to be done

[GitHub] tinkerpop issue #656: TINKERPOP-1385 Bind profile test assertions to TinkerG...

2017-07-14 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/656 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #662: TINKERPOP-1718 Deprecated GryoLiteMessageSerializerV1d...

2017-07-14 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/662 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #676: TINKERPOP-1727: Bytecode object shallow copied when tr...

2017-07-13 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/676 Ah solid find. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #664: TINKERPOP-834: Remove deprecated sack() method

2017-07-12 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tinkerpop issue #664: TINKERPOP-834: Remove deprecated sack() method

2017-07-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/664 This was merged. For some reason the issue tracker didn't catch it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] tinkerpop pull request #673: TINKERPOP-1709: Add a list of all the steps tha...

2017-07-12 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/673 TINKERPOP-1709: Add a list of all the steps that support by()/from()/to()/as()/option() https://issues.apache.org/jira/browse/TINKERPOP-1709 Listed and referenced (linked to) those steps

[GitHub] tinkerpop issue #658: TINKERPOP-1714 GremlinExecutor checks for timeout from...

2017-07-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/658 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #672: TINKERPOP-1427 GraphSON 3.0

2017-07-12 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/672 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #668: TINKERPOP-1720: Remove deprecated Hadoop code

2017-07-11 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/668 TINKERPOP-1720: Remove deprecated Hadoop code https://issues.apache.org/jira/browse/TINKERPOP-1720 Removed Constants and VertexComputing method. Created another ticket for the

[GitHub] tinkerpop pull request #667: TINKERPOP-1721: Remove deprecated Bindings rela...

2017-07-11 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/667 TINKERPOP-1721: Remove deprecated Bindings related code https://issues.apache.org/jira/browse/TINKERPOP-1721 The deed has been done. Mam, these bindings won't be bothering you any l

[GitHub] tinkerpop issue #665: TINKERPOP-1170: Remove deprecated ConfigurationTravers...

2017-07-11 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/665 No, `ConfigurationTraversal` was replaced by `PureTraversal` and the documentation uses `PureTraversal`. ``` this.traversal = PureTraversal.loadState(configuration

[GitHub] tinkerpop pull request #666: TINKERPOP-1719: Remove deprecated Traversal rel...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/666 TINKERPOP-1719: Remove deprecated Traversal related code https://issues.apache.org/jira/browse/TINKERPOP-1719 Removed deprecated `finalization.LazyBarrierStrategy` as well as some methods

[GitHub] tinkerpop pull request #665: TINKERPOP-1170: Remove deprecated Configuration...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/665 TINKERPOP-1170: Remove deprecated ConfigurationTraversal. https://issues.apache.org/jira/browse/TINKERPOP-1170 Removed `ConfigurationTraversal` which really should have never been used by

[GitHub] tinkerpop pull request #664: TINKERPOP-834: Remove deprecated sack() method

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/664 TINKERPOP-834: Remove deprecated sack() method https://issues.apache.org/jira/browse/TINKERPOP-834 It has been done. VOTE +1 You can merge this pull request into a Git repository

[GitHub] tinkerpop issue #657: TINKERPOP-832: Remove deprecated addV/E/InE/OutE metho...

2017-07-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/657 I haven't done any of that for any of the deprecation tickets. Once these are all merged, I will do a CTR of everything since then. --- If your project is set up for it, you can reply to

[GitHub] tinkerpop pull request #661: TINKERPOP-880: Remove deprecated GroupStepV3d0 ...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/661 TINKERPOP-880: Remove deprecated GroupStepV3d0 and GroupSideEffectStepV3d0 https://issues.apache.org/jira/browse/TINKERPOP-880 `groupV3d0()` was created for backward compatibility prior to

[GitHub] tinkerpop pull request #660: TINKERPOP-1142: Remove deprecated valueIncr, va...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/660 TINKERPOP-1142: Remove deprecated valueIncr, valueDecr, keyIncr, keyDecr. https://issues.apache.org/jira/browse/TINKERPOP-1142 Removed deprecated `valueIncr`, `valueDecr`, `keyIncr`, and

[GitHub] tinkerpop pull request #659: TINKERPOP-1291: Remove deprecated mapValues and...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/659 TINKERPOP-1291: Remove deprecated mapValues and mapKeys methods https://issues.apache.org/jira/browse/TINKERPOP-1291 Removed `GraphTraversal.mapValues()` and `GraphTraversal.mapKeys

[GitHub] tinkerpop issue #618: TINKERPOP-915 Add combined handler for Http and Websoc...

2017-07-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/618 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #655: TINKERPOP-1706 ScriptEngine related deprecation remova...

2017-07-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/655 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #645: TINKERPOP-1698 Gryo 3.0

2017-07-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/645 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #657: TINKERPOP-832: Remove deprecated addV/E/InE/Out...

2017-07-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/657 TINKERPOP-832: Remove deprecated addV/E/InE/OutE methods https://issues.apache.org/jira/browse/TINKERPOP-832 Removed deprecated `addV()`, `addE()`, `addInE()`, and `addOutE()` methods

[GitHub] tinkerpop pull request #:

2017-07-06 Thread okram
Github user okram commented on the pull request: https://github.com/apache/tinkerpop/commit/f68b36c44ee7febfa2b2698889c977b11a3e8f49#commitcomment-22955008 Its also going to need to be registered with Gremlin-Python. However, lets wait to do that as we are about to push a major

[GitHub] tinkerpop issue #621: TINKERPOP-1682 by-modulator optimization strategy

2017-07-06 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/621 I just noticed that this strategy is not registered with the GraphSON and Gryo serializers accordingly. Thus, back to VOTE 0. --- If your project is set up for it, you can reply to this email and

[GitHub] tinkerpop issue #621: TINKERPOP-1682 by-modulator optimization strategy

2017-07-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/621 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #647: TINKERPOP-1708: Add a "Note on Scopes" document

2017-07-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/647 Fixed both of @dkuppitz's recommended tweaks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] tinkerpop issue #646: TINKERPOP-1603 Remove deprecated code

2017-07-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/646 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #651: TINKERPOP-1169: Remove deprecated TraversalScriptFunct...

2017-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/651 Travis is complaining cause of some 'time traversal' test in Gremlin-Groovy test suite. Not related to this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] tinkerpop pull request #651: TINKERPOP-1169: Remove deprecated TraversalScri...

2017-06-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/651 TINKERPOP-1169: Remove deprecated TraversalScriptFunction and TraversalScriptHelper https://issues.apache.org/jira/browse/TINKERPOP-1169 Removed deprecated `TraversalScriptFunction` and

[GitHub] tinkerpop pull request #650: TINKERPOP-1171: Remove deprecated TraversalSour...

2017-06-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/650 TINKERPOP-1171: Remove deprecated TraversalSource.Builder https://issues.apache.org/jira/browse/TINKERPOP-1171 Removed deprecated `TraversalSource.Builder`. VOTE +1. You can

[GitHub] tinkerpop pull request #649: TINKERPOP-1289: Remove deprecated ConnectiveP, ...

2017-06-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/649 TINKERPOP-1289: Remove deprecated ConnectiveP, AndP, and OrP constructors. https://issues.apache.org/jira/browse/TINKERPOP-1289 Removed deprecated constructors. (for TinkerPop 3.3.0

[GitHub] tinkerpop pull request #648: TINKERPOP-1710: Add a note on tree() by-modulat...

2017-06-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/648 TINKERPOP-1710: Add a note on tree() by-modulation and uniqueness of tree branches. https://issues.apache.org/jira/browse/TINKERPOP-1710 There was confusion as to what should happen what

[GitHub] tinkerpop pull request #647: TINKERPOP-1708: Add a "Note on Scopes" document

2017-06-30 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/647 TINKERPOP-1708: Add a "Note on Scopes" document https://issues.apache.org/jira/browse/TINKERPOP-1708 Added a `Note on Scopes` section to the `the-traversal.asciidoc`. VO

[GitHub] tinkerpop issue #641: TINKERPOP-1703: Make EdgeOtherVertexStep non-final

2017-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/641 Merged. I think that its not being auto-closed cause I changed the PR title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop pull request #641: TINKERPOP-1703: Make EdgeOtherVertexStep non-fi...

2017-06-30 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tinkerpop issue #641: TINKERPOP-1703: Make EdgeOtherVertexStep non-final

2017-06-30 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/641 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #643: TINKERPOP-1701: HaltedTraverserStrategy should ...

2017-06-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/643 TINKERPOP-1701: HaltedTraverserStrategy should recurse into collections for detachment. https://issues.apache.org/jira/browse/TINKERPOP-1701 `HaltedTraverserStrategy` is used by

[GitHub] tinkerpop issue #634: TINKERPOP-741 Deprecated Transaction.submit(Function)

2017-06-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/634 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #633: TINKERPOP-741 (master) Removed deprecated transaction ...

2017-06-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/633 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #640: TINKERPOP-1694 Deprecated useMapperFromGraph

2017-06-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/640 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #642: TINKERPOP-1704: XXXTranslators are not being re...

2017-06-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/642 TINKERPOP-1704: XXXTranslators are not being respective of BulkSet and Tree. https://issues.apache.org/jira/browse/TINKERPOP-1704 `JavaTranslator` would convert `Tree` to `HashMap` and

[GitHub] tinkerpop pull request #641: TINKERPOP-1703: Make DsegEdgeOtherVertexStep no...

2017-06-28 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/641 TINKERPOP-1703: Make DsegEdgeOtherVertexStep non-final https://issues.apache.org/jira/browse/TINKERPOP-1703 The ticket really is about making {{EdgeOtherVertexStep}} non-final so

[GitHub] tinkerpop pull request #639: TINKERPOP-1669: EdgeVertexStep should be design...

2017-06-27 Thread okram
Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] tinkerpop issue #632: TINKERPOP-1519: tinker graph computer does not handle ...

2017-06-26 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/632 The problem is real, the fix works given the specific test case. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-23 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r123753801 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java --- @@ -79,6 +79,14 @@ public void modulateBy

[GitHub] tinkerpop issue #631: TINKERPOP-1445 Add ellipses for long property values

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/631 VOTE +1. (However, I wouldn't add the between the last line and the `...` but whateves) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-22 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r123507142 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalRing.java --- @@ -62,6 +62,10 @@ public void

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-22 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r123506884 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java --- @@ -79,6 +79,14 @@ public void modulateBy

[GitHub] tinkerpop pull request #639: TINKERPOP-1669: EdgeVertexStep should be design...

2017-06-22 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/639 TINKERPOP-1669: EdgeVertexStep should be designed for extension https://issues.apache.org/jira/browse/TINKERPOP-1669 `EdgeVertexStep` is no longer final and can be extended by providers

[GitHub] tinkerpop issue #628: TINKERPOP-1550 Made ganglia/graphite optional dependen...

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/628 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #624: TINKERPOP-929 Deprecation Removal

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/624 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #636: TINKERPOP-1691 Changed semantics of EventStrategyProce...

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/636 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #635: TINKERPOP-1688 Add annotations to TraversalMetrics pre...

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/635 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #637: TINKERPOP-1004 Expand usage of TransactionException

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/637 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #638: TINKERPOP-999 Removed generics from ServerGremlinExecu...

2017-06-22 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/638 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121701740 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStep.java --- @@ -79,6 +79,14 @@ public void modulateBy

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121703249 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/OrderGlobalStep.java --- @@ -99,6 +99,19 @@ public void

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121704449 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalStrategies.java --- @@ -215,7 +216,8 @@ static void visit(Map

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121702575 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalRing.java --- @@ -62,6 +62,10 @@ public void

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121703823 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/GroupSideEffectStep.java --- @@ -81,6 +81,14 @@ public

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121704275 --- Diff: CHANGELOG.asciidoc --- @@ -25,7 +25,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima [[release-3-3-0

[GitHub] tinkerpop pull request #621: TINKERPOP-1682 by-modulator optimization strate...

2017-06-13 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/621#discussion_r121702035 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupStepV3d0.java --- @@ -111,6 +111,16 @@ public void

[GitHub] tinkerpop issue #614: TINKERPOP-1676 (master) GraphSON Performance

2017-05-31 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/614 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #613: TINKERPOP-1676 (tp32) GraphSON Performance

2017-05-31 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/613 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #617: TINKERPOP-1681 Multiple hasId's are or'd into GraphSte...

2017-05-31 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/617 Seems right to me. Just to be certain `x.y.z` are ANDs and before, for `hasLabel()` and `hasId()` they were being OR'd. Test cases make sense. VOTE +1. --- If your project is set u

[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...

2017-05-31 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/616 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-26 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 Please see https://github.com/apache/tinkerpop/pull/615 . Here is what I did: 1. Created a JIRA first. 2. Fixed the problem. 3. Created a test case that fails with the problem, but

[GitHub] tinkerpop pull request #615: TINKERPOP-1678: until(Predicate) is actually ca...

2017-05-26 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/615 TINKERPOP-1678: until(Predicate) is actually calling emit(Predicate) https://issues.apache.org/jira/browse/TINKERPOP-1678 Fixed a typo-bug in `GraphTraversal` where `until(Predicate)` was

[GitHub] tinkerpop issue #609: TINKERPOP-1675 Throw underlying unchecked exception in...

2017-05-24 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/609 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #610: TINKERPOP-786 Gremlin DSL Support

2017-05-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/610 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 It must effect semantics as `until` is different from `emit`. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] tinkerpop issue #608: TINKERPOP-1618 Removed dependence on groovy for gremli...

2017-05-20 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/608 Cool! -- VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 You need splits so the traverser remains "local" to the child branch. I think your fix for this particular problem is correct, it would be great if you could also add a test case to `

[GitHub] tinkerpop issue #607: TINKERPOP-1673: GroovyTranslator produces Gremlin that...

2017-05-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/607 VOTE +1. Forgot to vote on my own PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] tinkerpop pull request #607: TINKERPOP-1673: GroovyTranslator produces Greml...

2017-05-11 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/607 TINKERPOP-1673: GroovyTranslator produces Gremlin that can't execute on :remote https://issues.apache.org/jira/browse/TINKERPOP-1673 `GroovyTranslator` now uses Groovy `[...]

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

2017-05-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/606 Whoa!? That is a huge problem. Can you do three things for this please? 1. Can you write a test case in `RepeatTest` that shows it breaking, but with your fix, it working. 2. Can you

[GitHub] tinkerpop issue #594: TINKERPOP-1577 Building gremlin-python with python 2/3

2017-04-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/594 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #599: TINKERPOP-1044 master Include more error information i...

2017-04-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/599 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #598: TINKERPOP-1044 Include more error information in remot...

2017-04-17 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/598 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...

2017-04-13 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/601 Yes, and I decided not to include that given that its rare and the only way to test would be to look for a `LambdaHolder` which would then make the strategy not apply to lots of other situations. I

[GitHub] tinkerpop pull request #601: TINKERPOP-1668: RepeatUnrollStrategy should not...

2017-04-13 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/601 TINKERPOP-1668: RepeatUnrollStrategy should not execute if there is a LoopStep used. https://issues.apache.org/jira/browse/TINKERPOP-1668 If the child traversal of `RepeatStep` has a

[GitHub] tinkerpop issue #595: TINKERPOP-1608 XSLT for converting GraphSON

2017-04-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/595 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...

2017-04-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/590#discussion_r110167099 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/ElementHelper.java --- @@ -116,6 +116,10 @@ public static void

[GitHub] tinkerpop pull request #590: TINKERPOP-1664 StarVertexProperty will check me...

2017-04-03 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/590#discussion_r109411238 --- Diff: CHANGELOG.asciidoc --- @@ -64,6 +64,7 @@ TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED YET) * Improved error handling of

[GitHub] tinkerpop issue #590: TINKERPOP-1664 StarVertexProperty will check meta-prop...

2017-04-03 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/590 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-29 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/587 Fixed the bugs that both @dkuppitz and @twilmes discovered. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #587: TINKERPOP-1642 Performance Enhancement on Mutating Tra...

2017-03-28 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/587 Note that `tp32/` doesn't have the issue. Thus, the bug is confined to this branch (luckily). --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] tinkerpop issue #584: TINKERPOP-1095 Gremlin Server performance improvement ...

2017-03-24 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/584 Solid work. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] tinkerpop issue #572: TINKERPOP-1652 Disable PathRetractionStrategy strategy...

2017-03-24 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/572 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #574: TINKERPOP-1387: from and to modulators for path steps

2017-03-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/574 @dkuppitz --- Do you feel like adding your "playlist" example with text to `the-traversal.asciidoc` in the `SimplePath Step` section? --- If your project is set up for it, you can rep

[GitHub] tinkerpop issue #574: TINKERPOP-1387: from and to modulators for path steps

2017-03-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/574 @dkuppitz -- okay? ... so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] tinkerpop issue #578: TINKERPOP-1625: Improvements to has() related steps

2017-03-21 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/578 ``` [INFO] [INFO] BUILD SUCCESS [INFO

[GitHub] tinkerpop pull request #578: TINKERPOP-1625: Improvements to has() related s...

2017-03-21 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/578 TINKERPOP-1625: Improvements to has() related steps https://issues.apache.org/jira/browse/TINKERPOP-1625 Added tests for `hasKey()` and `hasValue()`. Also tweaked up `HasTest` which had

[GitHub] tinkerpop pull request #574: TINKERPOP-1387: from and to modulators for path...

2017-03-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/574#discussion_r106495135 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/CyclicPathStep.java --- @@ -1,46 +0,0

[GitHub] tinkerpop pull request #574: TINKERPOP-1387: from and to modulators for path...

2017-03-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/574#discussion_r106494779 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java --- @@ -1034,11 +1034,10

<    1   2   3   4   5   6   >