Given the problems noticed with 3.2.5 as it is now I'm going to cancel this vote so that we can address the issues. I'll start a fresh VOTE thread when a new packaging is ready to go.
On Wed, Jun 14, 2017 at 3:42 PM, Stephen Mallette <spmalle...@gmail.com> wrote: > I'm fine to re-do it. Let's fix the mess. The fixes may be one liners but > there must be something amiss in the test cases that aren't catching these > things so it would be nice to dig in there. I'm going to cancel the VOTE. > Let's use the "code freeze" thread to coordinate the fixes. > > On Wed, Jun 14, 2017 at 3:29 PM, Marko Rodriguez <okramma...@gmail.com> > wrote: > >> I say -1 and then also fix the Pieter bug with the anyStepRecursively(). >> >> Both seem 1 line fixes. >> >> Marko. >> >> http://markorodriguez.com >> >> >> >> > On Jun 14, 2017, at 12:27 PM, Robert Dale <robd...@gmail.com> wrote: >> > >> > My vote is to move forward with the release as-is. This becomes a known >> > issue. But it's up to you. You have to do all the work ;-) >> > >> > Robert Dale >> > >> > On Wed, Jun 14, 2017 at 3:24 PM, Stephen Mallette <spmalle...@gmail.com >> > >> > wrote: >> > >> >> damn. that really stinks. That basically means that use of P.inside() >> >> translates to P.between() during serialization of bytecode. how did >> that >> >> not show up as a failure in a test somewhere (i don't know how remote >> >> process tests couldn't have caught that)?! >> >> >> >> well - what are we thinking now? -1, fix, re-release and re-do the >> VOTE? >> >> >> >> On Wed, Jun 14, 2017 at 3:13 PM, Robert Dale <robd...@gmail.com> >> wrote: >> >> >> >>> Stephen, found a little bug. I was going to push it but the branch is >> >> set >> >>> to the release version. >> >>> >> >>> diff --git >> >>> a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/ >> >>> structure/io/gryo/GryoSerializers.java >> >>> b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/ >> >>> structure/io/gryo/GryoSerializers.java >> >>> index 6bcb14f..0e7cac6 100644 >> >>> --- >> >>> a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/ >> >>> structure/io/gryo/GryoSerializers.java >> >>> +++ >> >>> b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/ >> >>> structure/io/gryo/GryoSerializers.java >> >>> @@ -217,7 +217,7 @@ public final class GryoSerializers { >> >>> if (predicate.equals("between")) >> >>> return P.between(((List) value).get(0), >> ((List) >> >>> value).get(1)); >> >>> else if (predicate.equals("inside")) >> >>> - return P.between(((List) value).get(0), >> ((List) >> >>> value).get(1)); >> >>> + return P.inside(((List) value).get(0), >> ((List) >> >>> value).get(1)); >> >>> else if (predicate.equals("outside")) >> >>> return P.outside(((List) value).get(0), >> ((List) >> >>> value).get(1)); >> >>> else if (predicate.equals("within")) >> >>> >> >>> >> >>> Robert Dale >> >>> >> >>> On Wed, Jun 14, 2017 at 7:15 AM, pieter gmail < >> pieter.mar...@gmail.com> >> >>> wrote: >> >>> >> >>>> Ran all Sqlg's custom tests and the structure and process test >> suites. >> >>>> All tests pass. >> >>>> >> >>>> VOTE +1 >> >>>> >> >>>> >> >>>> On 14/06/2017 03:36, David Brown wrote: >> >>>> >> >>>>> Ran ./validate-distribution.sh 3.2.5 - all ok >> >>>>> >> >>>>> Installed gremlin-python 3.2.5 from source as aiogremlin dependency >> - >> >>>>> successful >> >>>>> >> >>>>> Tested aiogremlin against Gremlin-Server 3.2.5 - all tests pass >> >>>>> >> >>>>> Manually ran Gremlin-Python tests using Pytest against >> Gremlin-Server >> >>>>> 3.2.5: >> >>>>> >> >>>>> * Python 2.7.12 - all tests pass >> >>>>> * Python 3.5.2 - all tests pass >> >>>>> >> >>>>> Nice work everyone! >> >>>>> >> >>>>> VOTE +1 >> >>>>> >> >>>>> On Tue, Jun 13, 2017 at 2:36 PM, Robert Dale <robd...@gmail.com> >> >> wrote: >> >>>>> >> >>>>>> +1 LGTM >> >>>>>> >> >>>>>> Robert Dale >> >>>>>> >> >>>>>> On Tue, Jun 13, 2017 at 6:29 AM, Daniel Kuppitz <m...@gremlin.guru> >> >>> wrote: >> >>>>>> >> >>>>>> *Validating binary distributions* >> >>>>>>> >> >>>>>>> * downloading Apache TinkerPop Gremlin >> >>>>>>> (apache-tinkerpop-gremlin-console-3.2.5-bin.zip)... OK >> >>>>>>> * validating signatures and checksums ... >> >>>>>>> * PGP signature ... OK >> >>>>>>> * MD5 checksum ... OK >> >>>>>>> * SHA1 checksum ... OK >> >>>>>>> * unzipping Apache TinkerPop Gremlin ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's docs ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's binaries ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's legal files ... >> >>>>>>> * LICENSE ... OK >> >>>>>>> * NOTICE ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's plugin directory ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's lib directory ... OK >> >>>>>>> * testing script evaluation ... OK >> >>>>>>> >> >>>>>>> * downloading Apache TinkerPop Gremlin >> >>>>>>> (apache-tinkerpop-gremlin-server-3.2.5-bin.zip)... OK >> >>>>>>> * validating signatures and checksums ... >> >>>>>>> * PGP signature ... OK >> >>>>>>> * MD5 checksum ... OK >> >>>>>>> * SHA1 checksum ... OK >> >>>>>>> * unzipping Apache TinkerPop Gremlin ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's docs ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's binaries ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's legal files ... >> >>>>>>> * LICENSE ... OK >> >>>>>>> * NOTICE ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's plugin directory ... OK >> >>>>>>> * validating Apache TinkerPop Gremlin's lib directory ... OK >> >>>>>>> >> >>>>>>> Validating source distribution >> >>>>>>> >> >>>>>>> * downloading Apache TinkerPop 3.2.5 >> (apache-tinkerpop-3.2.5-src.zi >> >>>>>>> p)... >> >>>>>>> OK >> >>>>>>> * validating signatures and checksums ... >> >>>>>>> * PGP signature ... OK >> >>>>>>> * MD5 checksum ... OK >> >>>>>>> * SHA1 checksum ... OK >> >>>>>>> * unzipping Apache TinkerPop 3.2.5 ... OK >> >>>>>>> * building project ... OK >> >>>>>>> >> >>>>>>> VOTE: +1 >> >>>>>>> >> >>>>>>> >> >>>>>>> On Mon, Jun 12, 2017 at 11:20 PM, Stephen Mallette < >> >>>>>>> spmalle...@gmail.com> >> >>>>>>> wrote: >> >>>>>>> >> >>>>>>> Ok - fixed: >> >>>>>>>> >> >>>>>>>> https://github.com/apache/tinkerpop/commit/ >> >>>>>>>> >> >>>>>>> 3977783f9b66bde8728b04be215ff1 >> >>>>>>> >> >>>>>>>> 460e9b0af9 >> >>>>>>>> >> >>>>>>>> Uploaded fresh zips. Please continue with review/VOTE. Thanks >> >>>>>>>> >> >>>>>>>> On Mon, Jun 12, 2017 at 3:04 PM, Stephen Mallette < >> >>>>>>>> spmalle...@gmail.com> >> >>>>>>>> wrote: >> >>>>>>>> >> >>>>>>>> dah - wonder how that happened. that's like the worst kind of >> >> mistake >> >>>>>>>>> >> >>>>>>>> to >> >>>>>>> >> >>>>>>>> make. small enough to be largely inconsequential, but still >> staring >> >>> you >> >>>>>>>>> right in the face to be big enough to have to re-do stuff. ok - >> >>>>>>>>> >> >>>>>>>> consider >> >>>>>>> >> >>>>>>>> this vote thread on hold for now. i have to fix that. thanks for >> >>>>>>>>> >> >>>>>>>> noticing >> >>>>>>> >> >>>>>>>> that. >> >>>>>>>>> >> >>>>>>>>> On Mon, Jun 12, 2017 at 2:58 PM, Robert Dale <robd...@gmail.com >> > >> >>>>>>>>> >> >>>>>>>> wrote: >> >>>>>>> >> >>>>>>>> Looks like some extra chars got introduced here: >> >>>>>>>>>> >> >>>>>>>>>> commit 9e14d674d26bf0a2b6b5bcd3d6a57feeeba24b16: >> >>>>>>>>>> CHANGELOG.asciidoc: >> >>>>>>>>>> -* Fixed an `NullPointerException` in `GraphMLReader` that >> >> occurred >> >>>>>>>>>> >> >>>>>>>>> when >> >>>>>>> >> >>>>>>>> an >> >>>>>>>>>> `<edge>` didn't have an ID field and the base graph supported >> ID >> >>>>>>>>>> assignment. >> >>>>>>>>>> +* Fixed an `NullPoiBugs >> >>>>>>>>>> +^^^^nterException` in `GraphMLReader` that occurred when an >> >>> `<edge>` >> >>>>>>>>>> didn't have an ID field and the base graph supported ID >> >> assignment. >> >>>>>>>>>> >> >>>>>>>>>> >> >>>>>>>>>> Robert Dale >> >>>>>>>>>> >> >>>>>>>>>> On Mon, Jun 12, 2017 at 12:00 PM, Stephen Mallette < >> >>>>>>>>>> >> >>>>>>>>> spmalle...@gmail.com> >> >>>>>>>> >> >>>>>>>>> wrote: >> >>>>>>>>>> >> >>>>>>>>>> Hello, >> >>>>>>>>>>> >> >>>>>>>>>>> We are happy to announce that TinkerPop 3.2.5 is ready for >> >>> release. >> >>>>>>>>>>> >> >>>>>>>>>>> The release artifacts can be found at this location: >> >>>>>>>>>>> https://dist.apache.org/repos/ >> >> dist/dev/tinkerpop/3.2.5/ >> >>>>>>>>>>> >> >>>>>>>>>>> The source distribution is provided by: >> >>>>>>>>>>> apache-tinkerpop-3.2.5-src.zip >> >>>>>>>>>>> >> >>>>>>>>>>> Two binary distributions are provided for user convenience: >> >>>>>>>>>>> apache-tinkerpop-gremlin-console3.2.5-bin.zip >> >>>>>>>>>>> apache-tinkerpop-gremlin-server-3.2.5-bin.zip >> >>>>>>>>>>> >> >>>>>>>>>>> The GPG key used to sign the release artifacts is available >> at: >> >>>>>>>>>>> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >> >>>>>>>>>>> >> >>>>>>>>>>> The online docs can be found here: >> >>>>>>>>>>> http://tinkerpop.apache.org/docs/3.2.5/ (user docs) >> >>>>>>>>>>> http://tinkerpop.apache.org/docs/3.2.5/upgrade/ >> >> (upgrade >> >>>>>>>>>>> >> >>>>>>>>>> docs) >> >>>>>>>> >> >>>>>>>>> http://tinkerpop.apache.org/javadocs/3.2.5/core/ (core >> >>>>>>>>>>> >> >>>>>>>>>> javadoc) >> >>>>>>>> >> >>>>>>>>> http://tinkerpop.apache.org/javadocs/3.2.5/full/ (full >> >>>>>>>>>>> >> >>>>>>>>>> javadoc) >> >>>>>>>> >> >>>>>>>>> The tag in Apache Git can be found here: >> >>>>>>>>>>> >> >>>>>>>>>>> https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a= >> >> tag;h= >> >>>>>>>>>>> 9a60e34a3d590a311d4d1681143b6407c9b5dc13 >> >>>>>>>>>>> >> >>>>>>>>>>> The release notes are available here: >> >>>>>>>>>>> >> >>>>>>>>>>> >> >>>>>>>>>>> https://github.com/apache/tinkerpop/blob/master/ >> >>>>>>>>>>> CHANGELOG.asciidoc#tinkerpop-320-nine-inch-gremlins >> >>>>>>>>>>> >> >>>>>>>>>>> The [VOTE] will be open for the next 72 hours --- closing >> >> Thursday >> >>>>>>>>>>> >> >>>>>>>>>> (June >> >>>>>>>> >> >>>>>>>>> 15, 2017) at 12pm EST >> >>>>>>>>>>> >> >>>>>>>>>>> My vote is +1. >> >>>>>>>>>>> >> >>>>>>>>>>> Thank you very much, >> >>>>>>>>>>> Stephen >> >>>>>>>>>>> >> >>>>>>>>>>> >> >>>>>>>>> >> >>>>> >> >>>>> >> >>>> >> >>> >> >> >> >> >
