Re: [DISCUSS] ANTLR and gremlin-script

2021-03-26 Thread Stephen Mallette
I've renamed it to gremlin-language - I plan to merge this PR today. Thanks! On Thu, Mar 25, 2021 at 11:27 AM Joshua Shinavier wrote: > Hi Stephen, > > Replies inline. > > On Wed, Mar 24, 2021 at 5:18 AM Stephen Mallette > wrote: > > > [...] > > I'd thought that it made sense that Groovy and t

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-25 Thread Joshua Shinavier
Hi Stephen, Replies inline. On Wed, Mar 24, 2021 at 5:18 AM Stephen Mallette wrote: > [...] > I'd thought that it made sense that Groovy and the grammar stayed > fairly close to one another as a nice point of Groovy is that you can make > it do neat tricks when building DSLs but I don't think

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-24 Thread Stephen Mallette
Please see below: On Mon, Mar 22, 2021 at 10:25 AM Joshua Shinavier wrote: > Awesome. This definitely fills a major gap, and as Florian said, it is > great that it is already improving the documentation. > > High level-question: do you have any thoughts about Gremlin syntax > validation *in gene

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-24 Thread Stephen Mallette
Some answers inline below: On Mon, Mar 22, 2021 at 5:00 PM Joshua Shinavier wrote: > I am not yet entirely sure what it means either, but I am thinking that it > would be nice to be able to > a) validate Gremlin expressions written in languages other than Groovy or > Java, and > Yes - that woul

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-24 Thread Stephen Mallette
Some thoughts inline: On Mon, Mar 22, 2021 at 2:37 PM pieter gmail wrote: > Hi, > > Exciting as this is I am not quite sure what it means. > > Naively perhaps it the idea, > Arbitary gremlin string -> antlr parser -> some AST walker -> gremlin > byte code -> java in memory steps ... -> voila >

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-22 Thread Joshua Shinavier
Btw. to your other questions: I think Stephen's attitude toward TP4 is that there should be a smooth transition, so ideally this would be for TP3, migrating to TP4 when the time comes. Native Java traversals are not accessible to a parser, so I do not see how they would be impacted by gremlin-gra

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-22 Thread Joshua Shinavier
I am not yet entirely sure what it means either, but I am thinking that it would be nice to be able to a) validate Gremlin expressions written in languages other than Groovy or Java, and b) parse Gremlin expressions in Gremlin language variants, producing JVM-based traversals, or even c) parse Grem

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-22 Thread pieter gmail
Hi, Exciting as this is I am not quite sure what it means. Naively  perhaps it the idea, Arbitary gremlin string -> antlr parser -> some AST walker -> gremlin byte code -> java in memory steps ... -> voila Is the grammar going to be the primary and only interface/specification, or will the nativ

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-22 Thread Joshua Shinavier
Awesome. This definitely fills a major gap, and as Florian said, it is great that it is already improving the documentation. High level-question: do you have any thoughts about Gremlin syntax validation *in general*, i.e. for language variants other than Groovy? It would be interesting to explore

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-16 Thread Stephen Mallette
Here is the PR: https://github.com/apache/tinkerpop/pull/1408 On Tue, Mar 16, 2021 at 6:14 AM Stephen Mallette wrote: > No branch yet, but I think I will be sending the PR today. > > On Mon, Mar 15, 2021 at 9:33 PM Joshua Shinavier > wrote: > >> Is there a branch we can take a look at before th

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-16 Thread Stephen Mallette
No branch yet, but I think I will be sending the PR today. On Mon, Mar 15, 2021 at 9:33 PM Joshua Shinavier wrote: > Is there a branch we can take a look at before the PR is ready? > > Josh > > On Fri, Mar 12, 2021 at 5:42 AM Stephen Mallette > wrote: > > > I've been working on forming a pull r

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-15 Thread Joshua Shinavier
Is there a branch we can take a look at before the PR is ready? Josh On Fri, Mar 12, 2021 at 5:42 AM Stephen Mallette wrote: > I've been working on forming a pull request for this task. I don't think IP > Clearance is necessary as I originally did because the contribution is > really just an AN

Re: [DISCUSS] ANTLR and gremlin-script

2021-03-12 Thread Stephen Mallette
I've been working on forming a pull request for this task. I don't think IP Clearance is necessary as I originally did because the contribution is really just an ANTLR4 grammar file with some tests to validate things. Therefore, it's not a big body of independent code as I'd perhaps initially envis

Re: [DISCUSS] ANTLR and gremlin-script

2021-02-08 Thread Stephen Mallette
Just wanted to leave an update on this thread. It was nice to see some support for it. I've not had time to focus on the task itself so sorry there hasn't been much movement, but I hope to see it on track soon. I thought to update the thread after I came across yet another nice usage for it. I've l

Re: [DISCUSS] ANTLR and gremlin-script

2021-01-07 Thread pieter gmail
+1  I have often thought the language specification should be a project separate from the implementations, and done in a formal but plain English format similar to OMG or IETF specifications.  I suspect Sqlg's code base would have been fastly different if it had evolved from a grammer instead of

Re: [DISCUSS] ANTLR and gremlin-script

2021-01-07 Thread Josh Perryman
First of all: I love this direction, for all of the reasons cited and the innovation I'm hoping that it opens up. Also, that Amazon Neptune has already done the work and would be willing to share it with the rest of the world is a remarkable gift. I'm just a user / admirer of the technology, but

[DISCUSS] ANTLR and gremlin-script

2020-12-24 Thread Stephen Mallette
As a project, over the years, we've often been asked the question as to why Gremlin doesn't have an ANTLR style grammar. There have been varying answers over the years to explain the reasoning but in recent years I've started to see where our dependence on Java for driving Gremlin design has not tr