Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-23 Thread Stephen Mallette
hmm - ok, thanks. trying to think if there was anything else to worry about by changing the name of the file. I guess it was just this which you already got it seems https://github.com/apache/tinkerpop/blob/45fa7bc3feee5daa5536ef3d7279f9188f158efd/gremlin-python/src/main/jython/setup.py#L66 On T

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-22 Thread Robert Dale
An update on the python README issue, I fixed the typos in the codebase and simply renamed the README to have .rst so that it becomes renderable for preview on github - https://github.com/apache/tinkerpop/tree/master/gremlin-python/src/main/jython Just have to remember to preview it on github befo

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-19 Thread Robert Dale
Looks like these are immutable so an updated release would be required. Going forward, we can use markdown and render for review, even just through github, before publishing. https://packaging.python.org/guides/making-a-pypi-friendly-readme/ Robert Dale On Fri, Oct 18, 2019 at 8:43 PM Stephen M

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-18 Thread Stephen Mallette
it's the README - https://pypi.org/project/gremlinpython/ looks like there's just an extra backtick in there where they shouldn't be one: https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/jython/README stupid RST format On Fri, Oct 18, 2019 at 7:31 PM Robert Dale wr

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-18 Thread Robert Dale
Can you provide the link to the page with the broken link? On Fri, Oct 18, 2019, 7:04 PM Stephen Mallette wrote: > Just noticed that there's a broken link in the description for pypi - bah. > Not sure that this can be fixed outside of another deployment. So, I guess > it will look stupid for a w

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-18 Thread Stephen Mallette
Just noticed that there's a broken link in the description for pypi - bah. Not sure that this can be fixed outside of another deployment. So, I guess it will look stupid for a while, unless someone knows how to deal with it. I've already pushed a fix to github. I've updated the release branches to

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-10 Thread Stephen Mallette
Sorry, I sent that last post a bit too soon. I've published the last cut of the SNAPSHOT docs - please review so we can get any fixes in prior to finding a mess after release: http://tinkerpop.apache.org/docs/3.3.9-SNAPSHOT/ http://tinkerpop.apache.org/docs/3.4.4-SNAPSHOT/ Thanks! On Thu, Oct 10

Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-10 Thread Stephen Mallette
I think I"m going to be reverting most of this change: https://github.com/apache/tinkerpop/commit/aa955d56485483cb5b1901fd82783d5cdf969c7c#diff-402e09222db9327564f28924e1b39d0c We'll keep the update to our shaded version of Jackson, but I'm finding that the remaining changes caused problems with

[DISCUSS] code freeze 3.3.9/3.4.4

2019-10-07 Thread Stephen Mallette
I'm a bit late on the code freeze post, but here it is now - it technically started at the end of the day on Friday. For once we don't have a glut of pull requests to merge so that's nice. Please use this thread for release related issues as we look to get another one of these releases out the door