[GitHub] [tinkerpop] FlorianHockmann commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse

2020-02-19 Thread GitHub
> Will not because message is null. There there is silent error eating. You're right. I should have looked taken a closer look. > Could we just check that deserialized object is not null and throw exception. Yes, I think that might be the best option as we expect the message to never be null. S

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse

2020-02-19 Thread GitHub
> Also at same time not sure if it hides bad JSON setting or other json related > behind. Should we fail totally in this case? We would still get an error in that case [from here](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L136) where the