[GitHub] [tinkerpop] spmallette commented on pull request #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

Might want to add one or two specifically for this strategy just so that it gets exercised on graph provider systems. [ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

This is a pretty nice batch of test. Still thinking if there are cases that are not covered Are there any provider test suite tests that trigger this strategy? [ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ] This message was relayed via gitbox.apache.org for dev

[GitHub] [tinkerpop] spmallette commented on pull request #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

This is a pretty nice batch of test. Still thinking if there are cases that are not covered Are there any existing provider test suite tests that trigger this strategy? [ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ] This message was relayed via gitbox.apache.or

[GitHub] [tinkerpop] spmallette commented on pull request #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

could you add some javadoc like our other strategies: https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62 actually, a bit more "explaining" inli

[GitHub] [tinkerpop] spmallette commented on pull request #1040: TINKERPOP-1882 Apply range and limit steps as early as possible

could you add some javadoc like our other strategies: https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62 [ Full content available at: https://g