[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/346 Smart. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/346 no need to start over - maybe not an issue. i'll see what happens when i merge. thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 Normally that's what I would do but tried doing it the 'github way' - https://help.github.com/articles/syncing-a-fork/ So let me know what you want me to do now. I can start over, crea

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/346 You could just use `git rebase` to update your branch rather than `git merge` - in that way the commit history doesn't get weird. --- If your project is set up for it, you can reply to this e

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 I merged your master into my fork. Commit 0787e46097cc09bb278ac1c787c4a50ece81cdb0 I didn't realize it would affect the pull request. Next time I'll create a branch. --- If your project

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/346 @robertdale when we get the final vote for this PR to be merged, i expect to merge it to tp31 and then master as I'd like the 3.1.x line of code to get this fix. i only mention this because i s

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/346 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/346 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/346 Yes, I ran 'mvn clean install -DskipIntegrationTests=false -DincludeNeo4j' and it passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] tinkerpop issue #346: ResultSet.hasNext should be idempotent

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/346 This looks like a good change. Thanks for this. Did you run the Gremlin Server integration tests after making this change? --- If your project is set up for it, you can reply to this email and