[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-06 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/355 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-05 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/355 Clean changes. VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/355 Yea, lots of issues in this code area. `enforceHomogenousCollectionIfPresent` also has the potential to throw NPE's (if the first element of a non-empty collection is `null`). I will create

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread BrynCooke
Github user BrynCooke commented on the issue: https://github.com/apache/tinkerpop/pull/355 Also the conversion of the collection to an array is dangerous. Who knows what the collection is actually backed by? It should use an iterator and get the first element if it exists. --- If

[GitHub] tinkerpop issue #355: TINKERPOP-1355 Design HasContainer for extension

2016-07-04 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/355 I just implemented my proposed changes. Now we no longer get exceptions, but unexpected results: ``` gremlin> g.V().hasId(within(new ArrayList())) ==>v[1] ==>v[2] ==>v[3]