[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/417 The Python-related fixes are necessary or else some of the `WhereTests` fail. Python has a bad ordering to the scoping variables with nested `and()`/`or()`. Thus, for the test suite to pass I had to

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/417 Code looks great, although the Python-related fixes are a bit misplaced in this PR. Anyhow, VOTE: +1 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/417 Doc update looks good. I'd still like a short section in the upgrade docs but other than that - All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up fo

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/417 @spmallette I updated `traversal-induced-values.asciidoc`. Wow -- `where().by()` is super powerful. That nested `where(select())`-clause you had in there was nsty. Given how much easie

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-15 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/417 Could you please update the Traversal Induced Values recipe? https://github.com/apache/tinkerpop/blob/master/docs/src/recipes/traversal-induced-values.asciidoc --- If your proje

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/417 I think we did a pretty bad job on upgrade docs in 3.2.2 so i'm kinda on the lookout for things that we might add to them - this might be a nice thing to call attention to in "user" section imo

[GitHub] tinkerpop issue #417: TINKERPOP-1330: by()-modulation for where()

2016-09-14 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/417 Regarding the `match()` translation, it's indeed very easy: ``` gremlin> g.V().as("a").outE("created").as("b"). ..1> inV().as("c").in("created").as("d"). ..2>match