[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-15 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/482 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/482 `docker/build.sh -t -i -n` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/482 I'm cool with that change. I still have to run a `docker/build.sh -t -i -n` though - will do so as soon as I have the resources available (unless someone else volunteers). --- If your project i

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/482 When I go to merge, I will change the method name to `selectV3d2()` so if you want to vote :) ... Also, I think we need @dkuppitz and @robertdale and @mhfrantz to have a look and vote too. -

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/482 ok - if it's trivial, then perhaps not worrying about. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/482 The only difference is `select(Pop.mix,...)` (that is `selectV3d2()`) and there are 6 or so tests that test it in `RangeTest` and `TailTest`. I can explicitly make them use the method `selectV3d2()`

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

2016-11-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/482 It should be `selectV3d2()` given that it will yield backward compatibility to 3.2.x. Maybe I missed it, but are there any tests for `selectV3d2()` - at least something to exercise th