Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Done. We already use `validate-distribution.sh` to test script evaluations,
so it was easy to another test.
https://github.com/apache/tinkerpop/commit/62785dcb686be7d56bf207a0ef4279f912c
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Oh, that's a good idea! I will add that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Isn't there a distribution verification that does tests? I know it's
post-build, but that's better than nothing.
---
If your project is set up for it, you can reply to this email and have you
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Same here. I can't think of a way to test `gremlin.sh`. The script requires
that the project was built, but tests can be run without building the project
upfront. Going to merge this PR for now.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/537
i was trying to think how we could do it but didn't really come up with
anything. we really don't have any tests for `Console` right now that I know of
- not sure how we would reasonably do tha
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/537
I don't know. The fix relies on a change in `gremlin.sh`. Is that testable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/537
Actually, can you add a test case for this so we know it doesn't break
again in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/537
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/537
I did some manual tests - seems to work nicely - VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
