[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/682 I created 2 new PR's, one for `tp31/`, the other for `master/`. `tp31`: #683 `master`: #684 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/682 I've dug into supporting `BigDecimal` directly and it's turning into a mess a bit. Python does have `Decimal` class which is like `BigDecimal` but it doesn't serialize through the standard

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/682 This all goes back to typing numbers based on storage size is dumb. Most modern, high-level languages have arbitrary precision on integer and decimal values. Languages that have strongly typed

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/682 Ah. I didn't realize that either. BigDecimal is not something we want to support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/682 IMO it makes sense to support `BigDecimal`. If not for big numbers, then at least for the better precision. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/682 I didn't get a chance to review/vote on this before it was merged, but I dont' think this is what I expected to happen when I wrote the JIRA. I didn't think we would produce direct support for

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-25 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/682 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-25 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/682 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if