[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/697 All tests pass with `docker/build.sh -t -n -i` VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-23 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/697 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/697 Cleaner `if/else` clause. ``` return first instanceof Number && second instanceof Number ? NumberHelper.compare((Number) second, (Number) first) : Comparator.<~>naturalOr

[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/697 Alright, turned out it doesn't have a measurable performance impact. ``` if (first instanceof Number && second instanceof Number) { return NumberHelper.compare((Number) second,

[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-18 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/697 Eek. Yea. That `try/catch` sorta sucks. Can you do some performance testing with and without they `try/catch`? Would you mind? --- If your project is set up for it, you can reply to this email and

[GitHub] tinkerpop issue #697: TINKERPOP-1753 OrderStep not able to order by non-inte...

2017-08-18 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/697 Btw, I will update `CHANGELOG` after the code freeze. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have