Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
`dotnet pack gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj -c Release`
generates the package containing with assembly with the intended attributes.
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/716
Thanks @jorgebay - i wasn't aware of that issue. How does it look now?
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
We forgot to consider that, as we are strong named assembly, we must avoid
changing the assembly version for patch versions to minimize the need of
user-defined binding redirects.
In our
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/716
Thanks for doing this, @spmallette!
LGTM, VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/716
ohh - smart. no wonder the PR looks "wrong".
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/716
The strong name for Gremlin.Net.dll assembly (generated using
Gremlin.Net.csproj) is missing, we should add it in the template as well.
---
