Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Nice! lgtm
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Once I realized that the failure was not preventing the build it was easy
to spot the problem. Just pushed a fix.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Interesting. Those errors don't seem to affect the build though - it still
passes. I guess it's because we don't run any tests against those particular
graphs on the "secure" server? or is it f
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
I've rebased this on top of `tp32` (after #752 was merged) on my private
fork and the issue I've mentioned earlier persists:
https://travis-ci.org/jorgebay/tinkerpop/jobs/305703717#L7380 (Ubuntu)
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/747
VOTE: +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@robertdale thanks for looking into it.
I'm running `mvn clean install -DskipTests` followed by a `mvn clean
install -pl :gremlin-dotnet-tests -P gremlin-dotnet
-DskipIntegrationTests=fa
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay On which OS do you get the test errors?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
yeah - i'm just realizing how i flubbed a bunch of things on the last
commit. i was so focused on your .net problems i only ran tests for .net
:disappointed:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
This is strange. That command works for me. I'm not sure what could be
wrong.
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
I'm getting a path related issue on Gremlin.Net - Test module, while
executing:
```
mvn clean install -pl :gremlin-dotnet-tests -P gremlin-dotnet
-DskipIntegrationTests=false
```
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Ah, I see its possible to run integration test using:
```
mvn clean install -pl :gremlin-dotnet-source,:gremlin-dotnet-tests -P
gremlin-dotnet -DskipIntegrationTests=false
```
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
I think that there are a lot of path issues when building from outside of
the root directory - gremlin-dotnet is not the only one. i typically just do
this:
```text
mvn clean insta
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
hm... with the new server start scripts, when running from within a
directory like:
```
cd gremlin-dotnet
mvn clean install -P gremlin-dotnet
```
I get the following
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
`docker/build.sh -t -n -i` succeeds and tests pass.
VOTE: +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Fixes look good to me!
I'm running integration tests locally on docker and I'll come back to give
my plus one.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay fixed all the nits - thanks.
---
16 matches
Mail list logo
