Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
No worries, thanks!
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
ok - i'll just close this then. if you change your mind, we can get it
reopened and work it through. thanks!
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@spmallette I'm not sure I'll come back to this exactly. I was thinking
about it recently, actually, and I think just providing a `create()` which
calls `create(null)` in the VertexProgramBuilder
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@PBGraff do you think you will come back to this PR to get it finished up?
or is that unlikely given your schedule?
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@spmallette Thanks for the heads-up, but I don't think I'll have a chance
to get to it before then. It isn't so urgent it can't wait for the next release
as it's code style as opposed to a bug.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@PBGraff i just thought i'd reach out to let you know that we do have a
release coming up soon - aimed for first week of april (though we'd probably
look to stop making code changes in preparat
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
Sorry - you really shouldnt have any commits from our repo in this PR - it
should be all your work. The problem is that if when we look at the diff to
review, it contains changes that don't pe
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@spmallette That might have occurred with my attempt to rebase on the
forked project. It ended up having to do a merge from my local into my remote
branch, so those commits are probably (hopefully
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
@PBGraff i'm not sure why i didn't notice this before, but i see a bunch of
commits here that aren't yours. Did something get messed up in your fork
somehow?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
I'm posting this to all open PRs of current relevance - this PR needs to be
rebased against the branch it is targeted against given a broken python
dependency that was published to pypi a day o
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
I think that sounds like a reasonable plan and I would appreciate it if you
can cover part 4 on merge. I'll try to get to it soon. I understand that this
can get more complicated since I am propos
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
> My concern is that people may still override/implement the old method and
not the new one, thus yielding programs that don't execute properly
Hmmas I look at the way it is now, yo
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/772
I think all test problems have now been fixed. My concern is that people
may still override/implement the old method and not the new one, thus yielding
programs that don't execute properly. It wil
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
actually - i see that there is a whole other host of errors:
```text
[ERROR] Errors:
[ERROR]
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.shouldFailWithImpro
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/772
I add a bunch of comments - pretty minor changes mostly. The biggest thing
I'm seeing right now comes from the failing Travis build:
```text
[ERROR]
/home/travis/build/apache/tinke
15 matches
Mail list logo
