Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/786
Rebased, tests added and `CHANGELOG` updated. Functionally nothing really
changed, hence I don't think we need to revote. Going to merge this in 1-2
hours.
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/786
Huh, weird, wonder why it worked for me, must have been a pretty old branch
that was active when I tested it. But no big deal, I will retarget the PR once
I added some tests.
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
Hmm... Looks like it is reproducible on tp32.
## 3.2.7
```
apache-tinkerpop-gremlin-console-3.2.7]$ ./bin/gremlin.sh
\,,,/
(o o)
-oOOo-(3)
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/786
If you want to add the tests as part of this PR, that's fine - seems like
we should just have some for this thing. also, you need a changelog entry.
VOTE +1
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/786
I tried to reproduce it on a `tp32` and this issue didn't show up.
> also, do we not have a set of unit tests for `NumberHelper`? that's
weird, no?
Yeah, I can add those. Want me
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/786
@dkuppitz i noticed that you wrote that this was not an issue on tp32 - can
you explain why?
also, do we not have a set of unit tests for `NumberHelper`? that's weird,
no?
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/786
VOTE +1
---
