[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-30 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/791 VOTE: +1 ---

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/791 ok - i think i have it right now: ```text $ cat x.groovy println "test" $ bin/gremlin.sh -e x.groovy test $ bin/gremlin.sh -e=x.groovy Gremlin file not found at [

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/791 If i filter out the short options and someone does `-e=x.groovy` (or `-i=`) then it hangs the load of the console (which was the original problem i wanted to solve). I guess to properly handle

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/791 Yea, I think that would be better. Looks like an easy change, you'd just feed `normalizeArgs` with the long options only. ---

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-29 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/791 true - it just sorta worked that way i guess. i didn't go out of my way to disallow it. should i change it? ---

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-29 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/791 Hmm, although it's functional, it looks kinda weird. The common patterns are: * `-s` and `-s arg` for short options * `--long`, `--long arg` and `--long="arg"` for long options

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-25 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/791 Yeah, ok, apparently I never actually switched branches. Time to get some coffee VOTE +1 ---

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-25 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/791 What were you trying? seems to work for me: ```text $ cat x.groovy println "123" $ bin/gremlin.sh -e x.groovy 123 $ bin/gremlin.sh -e=x.groovy 123 $ bin/

[GitHub] tinkerpop issue #791: TINKERPOP-1879 Fixed gremlin.sh handling of = in flags

2018-01-25 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/791 Those tests pass? It doesn't seem to work for me on the cli. ---