[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-29 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 Can this be merged? ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-26 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 VOTE +1 ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-26 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/825 added changelog entry ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-26 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/825 Should get a CHANGELOG entry, right? ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-26 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/825 Best PR ever ;) VOTE: +1 ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-26 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/825 i meant to come back to that pom.xml and forgot. seems ok to drop the two exclusions now that giraph is gone. didn't get any new conflicts in doing so when i built. ---

[GitHub] tinkerpop issue #825: TINKERPOP-1930 Remove Giraph

2018-03-25 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/825 I think there's more that can be removed: ```diff diff --git a/pom.xml b/pom.xml index ef2be4821d..ddd9167a51 100644 --- a/pom.xml +++ b/pom.xml @@ -582,15 +582,6 @@ li