[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-05-14 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/854 My bad on the lack of merge. I'll do it today. ---

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-05-14 Thread VivienGiraud
Github user VivienGiraud commented on the issue: https://github.com/apache/tinkerpop/pull/854 OK, thanks @spmallette for the quick answer. We will try @davebshow patch on our side ;) BTW thank you @davebshow for this useful patch! ---

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-05-14 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/854 I would have liked to have seen it for 3.2.9/3.3.3 but it didn't merge in time (in the process of releasing those now). We don't have a scheduled release date yet for 3.2.10/3.3.4. ---

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-05-14 Thread VivienGiraud
Github user VivienGiraud commented on the issue: https://github.com/apache/tinkerpop/pull/854 Hi, We hit the same problem, so we rose the recursion limit : > from sys import setrecursionlimit > setrecursionlimit(2) But to be honest we are afraid it could crash

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-04-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/854 i dunno - that's sorta why i left it alone. if you can't think of any way to test it well, a nice long explanatory comment with the JIRA referenced where you made the change might be enough to

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-04-27 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/854 I'm happy to write a test. Is there an established way to to test large streaming responses? Or any tips on how to write one? ---

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-04-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/854 VOTE: +1 But I do think a simple test would be nice. The code screams "make me recursive" and a future contributor, not aware of this issue, might try to change it back and not realize t

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-04-25 Thread davebshow
Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/854 VOTE +1 ---

[GitHub] tinkerpop issue #854: TINKERPOP-1933 gremlin-python maximum recursion depth ...

2018-04-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/854 Builds with `mvn clean install -DskipTests && mvn verify -pl gremlin-python -DskipIntegrationTests=false` - I don't think you need a test for this necessarily. VOTE +1 ---