[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/855 done - https://github.com/apache/tinkerpop/commit/1d9e6dc6d30c5c7d56e4007527365793eb1f223e ---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/855 ah - ok, just use the Map rather than the Setfair enough ---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/855 Well, you would do use ConcurrentHashMap ;-) ``` static Map LOADED = new ConcurrentHashMap<>(); try {

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/855 That method isn't available on `ConcurrentHashMap.newKeySet()` - is there some other way to get to that? ---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/855 I think `computeIfAbsent()` would have been better :goat: ---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-25 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/855 VOTE +1 ---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

2018-04-24 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/855 VOTE: +1 ---