[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-10 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 VOTE +1 ---

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-08 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 Let's get #909 merged, rebase this, add GLV tests and then merge this one (doing the same for #897 ) ---

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-01 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/882 Done. ---

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-08-01 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 @dkuppitz could you rebase this one more time please? ---

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 good question @FlorianHockmann - seems like the recipe shouldn't be removed but perhaps updated to reflect this step?? ---

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-30 Thread FlorianHockmann
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/882 Just wondered: Does the _Shortest Path_ recipe still make sense with the new `shortestPath()` step? And should the section in the reference docs about shortest paths and the recipe link

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-07-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 I just issued #897 - note my comments there about TINKERPOP-1991. I think we should just leave that alone for 3.4.0 and come back to it. I also think we should disregard my comments about

[GitHub] tinkerpop issue #882: TINKERPOP-1990 Add a shortestPath() step

2018-06-21 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/882 I will try to find some time to do TINKERPOP-1991 and see what is involved. If it's a mess then maybe we don't try to shove TINKERPOP-1991 into 3.4.0 and await 3.5.0 then just merge