[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-09-04 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 I've closed this pull request given the recent discussion here to deal with this on TINKERPOP-2027. ---

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-27 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/898 > I'd be happy to give the typings file generation @mattallenuk I saw you've [created the ticket](https://issues.apache.org/jira/browse/TINKERPOP-2027): Nice! we can discuss on the tick

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-24 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 `subgraph()` serialization is a major problem without a clear solution for GLVs. there is nothing for anyone to deserialize a returned subgraph into for GLVs and so it has no where to go. all y

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-24 Thread daem0ndev
Github user daem0ndev commented on the issue: https://github.com/apache/tinkerpop/pull/898 hey folks! sorry i went missing :) so @mattallenuk please feel free to go ahead, we actually ran into some hiccups when trying to integrate with gremlin-javascript and remote calls when doing th

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-24 Thread mattallenuk
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/898 I'm also using Gremlin Javascript in a Typescript project. I'd be happy to give the typings file generation a crack if @daem0ndev is not able to. ---

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-23 Thread Tankobot
Github user Tankobot commented on the issue: https://github.com/apache/tinkerpop/pull/898 @jorgebay From the looks of that groovy file, only the traversal files are generated. Are the other scripts in the repository handwritten? I'm actually in a situation very similar to @daem0ndev (

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-22 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 @daem0ndev do you have any thoughts on the recent comments made here? ---

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-13 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 That was going to be my suggestion too - I think that it can be auto-generated then it should be. ---

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/898 Nice @daem0ndev! I think its a good idea to provide typing definitions inside the package. [Gremlin Variant APIs](http://tinkerpop.apache.org/docs/current/tutorials/gremlin-language-vari

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-08-01 Thread daem0ndev
Github user daem0ndev commented on the issue: https://github.com/apache/tinkerpop/pull/898 yes unfortunately its manually maintained right now, although I did my best to organize the file in such a way that its easy to map it to the default exports. The only way to get this for free i

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-07-30 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/898 Hi, thanks for the contribution. I'm sure @jorgebay will look in on this when he's back from vacation. In the mean time, for my own information, could you comment on how this file is to be mai

[GitHub] tinkerpop issue #898: gremlin-javascript: Typescript typings definition

2018-07-29 Thread daem0ndev
Github user daem0ndev commented on the issue: https://github.com/apache/tinkerpop/pull/898 I'm working on a NestJS module for gremlin client that will essentially be a clean typescript wrapper over this gremlin-javascript library. If there is any interest, I'll gladly publish it. -