Re: CountStrategy and TraversalHelper.replaceStep

Created a jira for this. I tested your fix and all tests are passing again. Sqlg and TinkerGraph. Thanks Pieter On 30/10/2017 18:01, Daniel Kuppitz wrote: Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the

Re: CountStrategy and TraversalHelper.replaceStep

Ok great, I'll test a bit with the order changed. Thanks, Pieter On 30/10/2017 18:01, Daniel Kuppitz wrote: Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the strategy. The fix is easy, we just need to change the order of the 2 statements in replaceStep():

Re: CountStrategy and TraversalHelper.replaceStep

Ah, yea, I see what you mean. It's actually replaceStep() which is buggy, not the strategy. The fix is easy, we just need to change the order of the 2 statements in replaceStep(): public static void replaceStep(final Step removeStep, final Step insertStep, final Traversal.Admin

Re: CountStrategy and TraversalHelper.replaceStep

I am on the latest 3.3.1-SNAPSHOT, just pulled master again. The actual traversals and results are correct. However after the CountStrategy the VertexStep(OUT,edge) previousStep pointer (AbstractStep.previousStep) is incorrect. I should be EmptyStep but infact points to the newly inserted

Re: CountStrategy and TraversalHelper.replaceStep

I don't see any issues. Which version are you talking about? *gremlin> Gremlin.version()* *==>3.2.7-SNAPSHOT* gremlin> g = TinkerFactory.createModern().traversal() ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard] gremlin> g.V(1).repeat(out()).until(__.not(outE())).values('name')

CountStrategy and TraversalHelper.replaceStep

Hi, Whilst optimizing the NotStep I came across what looks to me like a bug in TraversalHelper.replaceStep or perhaps rather in CountStrategy. The test below shows the bug.     @Test     public void g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name() {     Graph graph =