Glad that works. I'll keep an eye out for a pull request.
On Wed, Jan 20, 2021 at 7:03 AM Jan Jansen
wrote:
> I think a static protected method would quiet okay.
>
> On 2021/01/19 14:04:44, Stephen Mallette wrote:
> > Is there a way to do this so that createDefaultYamlConstructor() is not
> > p
I think a static protected method would quiet okay.
On 2021/01/19 14:04:44, Stephen Mallette wrote:
> Is there a way to do this so that createDefaultYamlConstructor() is not
> public? Perhaps you could make it protected scope and then create a
> JanusGraphServerSettings to extend it so you could
Is there a way to do this so that createDefaultYamlConstructor() is not
public? Perhaps you could make it protected scope and then create a
JanusGraphServerSettings to extend it so you could access it that way? I
guess I'm just thinking that Settings shouldn't publicly expose yaml
related details l
Yeah, It would be easiest solution. So we don't have to copy the constructor,
but can add our fields.
On 2021/01/15 16:38:59, Stephen Mallette wrote:
> Are you saying you only care about getting the Constructor object,
> modifying it and then using it to your own ends? I assume you would then
>
Are you saying you only care about getting the Constructor object,
modifying it and then using it to your own ends? I assume you would then
make your own Yaml parser:
Constructor modifiedConstructor = Settings.createDefaultYamlConstructor();
// do some changes to "modifiedConstructor"
Yaml yam
Basic idea would to do following:
https://gist.github.com/farodin91/b81f6e9bccbae88d04a0dc7006bf0b16#file-settings-java-L274-L346
Greetings,
Jan
On 2021/01/07 17:16:36, Stephen Mallette wrote:
> Could you be more specific about what you propose in your second idea? I
> guess i'd like to know
Could you be more specific about what you propose in your second idea? I
guess i'd like to know how you would like to get the Constructor and how it
would affect the API. Thanks
On Wed, Jan 6, 2021 at 7:13 AM wrote:
> Hi
>
>
> We (JanusGraph) are already automatically settings overwriting defaul
Hi
We (JanusGraph) are already automatically settings overwriting defaults of
gremlin server settings, see here
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-server/src/main/java/org/janusgraph/graphdb/server/utils/JanusGraphSettingsUtils.java.
We are working on adding a Grpc
