https://issues.apache.org/jira/browse/TINKERPOP-2138
Added a new `globalFunctionCacheEnabled` configuration to the
`GroovyCompilerGremlinPlugin` and an overriding setting for sessions on
`SessionOpProcessor` that disables the global function cache. In cases where
you don't need the cache (i.e.
Good catch and fix!
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1045 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1045 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1045 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1045 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2139
Prior to this change serialization exceptions were basically just logged
because any failure would signal a bad host and mark it as dead, but that's not
really what was happening obviously if the client was never even able to try to
send the
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1047 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
we tend to just use the "." rather than the "::" when referencing methods on
specific classes.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
It's an odd way to deal with `ConcurrentModificationException` but the code
that is throwing it is out of our hands so we can't really fix it at its source
very well. As i look at this one this morning, I wonder IF this does happen to
somehow create some form of infinite loop it's going to be re
I can make it a `for` loop, retry at most 5 times, log every retry attempt and
increase the pause between each retry. If they all fail, we just return
`ObjectWritable.class.toString()`, as you suggested earlier. No big deal, but
realistically, I don't think this can ever happen. Hitting the exce
I like what you proposed - a more defensive posture is better imo. thanks
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Ha, you're picky. "::" is the official notation for method references though.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
sorry - just trying to be consistent.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2140
This additional Travis build job checks whether the Docker build still works.
The job took 21 minutes [on
Travis](https://travis-ci.org/apache/tinkerpop/builds/484445855) which is still
faster than the Spark job which took 26 minutes. So, thi
Nice one.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1048 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1043 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
thanks for the explanation. i'm still fine with the version your upgrading to.
happy to review again when you've addressed the issues i'd noted.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1042 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.or
thanks for this - VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1048 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1031 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2144
Failures occurred on the first round of a SASL request when the negotiator was
being created and if an exception was tossed there neither the server nor
driver handled the situation well. By explicitly capturing and handling it, we
can now pr
[ pull request closed by FlorianHockmann ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1048 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
could you add some javadoc like our other strategies:
https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62
[ Full content available at: https://g
could you add some javadoc like our other strategies:
https://github.com/apache/tinkerpop/blob/e51bfc90fe6a863c17016c80fe53b4b5ccb97fd0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategy.java#L50-L62
actually, a bit more "explaining" inli
This is a pretty nice batch of test. Still thinking if there are cases that
are not covered
Are there any provider test suite tests that trigger this strategy?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev
This is a pretty nice batch of test. Still thinking if there are cases that
are not covered
Are there any existing provider test suite tests that trigger this strategy?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.or
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Other than the few minor comments I made, I think this looks good. You have
100% coverage on the new strategy which is cool. I can't help thinking that
there is yet some case that hasn't be covered but I'm not sure what case of
significance isn't in your tests already.
Only thing I could thin
Thanks for this - merged via CTR as the change is for additional tests and
Travis passed without issue.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1050 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I just put some breakpoints on the lines that mutate the traversal, but it
looks like the tests in the provider test suite all have pretty optimal
traversals, hence this strategy never changes any of them.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message
Might want to add one or two specifically for this strategy just so that it
gets exercised on graph provider systems.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
LGTM.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1046 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Makes sense, VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1046 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
This is so that simple custom type serializers can reuse the same logic
without having to put their type serializer into the same package
structure.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.
My intention was to make it `protected` initially (not package-private), thanks
@nastra for the fix!
I'll merge it via CTR once the build finishes.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache
My intention was to make it `protected` initially (not package-private), thanks
@nastra !
I'll merge it via CTR once the build finishes.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1046 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1047 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1049 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1047 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1044 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
A Frame may wrap a ReferenceCounted buffer, which is normally released
when it is written back to the client. However, if the Frame is dropped
by ResponseHandlerContext the buffer also has to be released.
---
This is a follow-up fix for #899
[ Full content available at: https://github.com/apache
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1052 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
thank you - merged this little fix as CTR
[ Full content available at: https://github.com/apache/tinkerpop/pull/1052 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Could you please add a line to the CHANGELOG.asciidoc to say that we added this?
Other than that - too bad we missed this in the first go round, thanks for
adding: VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org
@spmallette added line to the changelog
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1049 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1053 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1040 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Provide a way to resolve the `TypeSerializer` instance to use when there isn't
any direct match.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2150
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Please add an entry to CHANGELOG when you merge, but otherwise VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Please add an entry to CHANGELOG when you merge but otherwise VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
The new configuration option should be added to the
[docs](https://github.com/apache/tinkerpop/blob/TINKERPOP-2150/docs/src/reference/gremlin-applications.asciidoc#graphbinary).
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache
Nice catch @dkuppitz , will do!
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I'm going through the process of creating typescript definitions for the
javascript library, and I noticed a bug in Path#toString(). It incorrectly
attempts to call a non-existant local `objects` variable instead of calling the
class property `this.objects`.
[ Full content available at: https:/
Seperately, would you be interested in a PR to port the whole javascript
library over to typescript?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Adding typescript definitions is being discussed here:
https://issues.apache.org/jira/browse/TINKERPOP-2027
perhaps you could read through that and include any thoughts you might have. i
don't think anyone is working on that issue at this time, but you might want to
ask on that in any comments
I've updated the docs and added an entry to the CHANGELOG.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Thanks @thefliik , I've filed a ticket to keep track of this:
https://issues.apache.org/jira/browse/TINKERPOP-2152
Can you target branch `tp33` for this to be applied to the 3.3 line?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
@jorgebay in the `tp33` branch it looks like the Path#toString() method has
been removed entirely, so when/if that branch is merged into master this PR
will be unnecessary. Feel free to close.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed v
`tp33` continually merges to `master` - wonder why `toString()` isn't present
on that branch
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
The code in question on `tp33`:
https://github.com/apache/tinkerpop/blob/tp33/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js#L118-L139
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for
`toString()` was introduced as part of TK-1446, it didn't have a string
representation on the js side prior to that.
@thefliik sorry for the confusion, nvm.
Fixing it on `master` makes sense, VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was r
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Changed loop break check to break out of the connection creation loop if
greater than or equal to the expected amount of connections are created. A
situation exists where unless exactly the expected amount of connections are
made when checked, and infinite loop of connections may be opened.
[ F
Issue:
https://github.com/apache/tinkerpop/compare/master...IsaacBoy:TINKERPOP-2155
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Issue in JIRA: https://issues.apache.org/jira/browse/TINKERPOP-2155
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-2154
Ensures that reference counts of allocated buffers are set to 0 when there is a
failure during serialization.
Includes a test for memory allocation when introducing failures.
VOTE +1
[ Full content available at: https://github.com/apache/tin
i guess there isn't a better way to do that kind of stuff since we allocate
within the serializers themselves. oh well.
needs a changelog entry but VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1058 ]
This message was relayed via gitbox.apache.org for dev@tinkerp
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1058 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
thanks for submitting this - in principle your change makes sense to me so VOTE
+1 but i'll let @FlorianHockmann provide his thoughts since he probably knows
the most about this.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apa
Thanks for this contribution.
I also noticed problems with the way the connection pool now handles resizing
and closing of broken connections
([TINKERPOP-2135](https://issues.apache.org/jira/browse/TINKERPOP-2135)) which
are probably related. Improving this situation will most likely require a
[ pull request closed by jorgebay ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1058 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by IsaacBoy ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Cool. Does somebody manually initiate the merge into master?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
yes. it will get merged. typically we need 3 +1s from committers OR a single +1
and a seven day waiting period for objections:
http://tinkerpop.apache.org/docs/current/dev/developer/#rtc
either way, should merge shortly. as it's a small change i could probably just
merge it given florian's feed
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I didn't bother to create a ticket for this as it's more of a administrative
thing, but I've reworked the download page to have a dropdown list of the
archived versions. In that way, the page doesn't scroll so much and other
content lower in the page is more immediately visible. This should also
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1057 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[ pull request closed by spmallette ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
https://issues.apache.org/jira/browse/TINKERPOP-1435
Implemented `Duration`, `Char`, `ByteBuffer`, `Byte`, `BigInteger` and
`BigDecimal` which were the most critical ones right now. Tried to do
`InetAddress` but there didn't seem to be anything in Python suitable to
handled that type except for
The current instructions are:
https://tinkerpop.apache.org/docs/current/dev/developer/#_pmc_vote
> PMC Vote
> 4. d. Update Downloads page, when moving "Current Releases" to "Archived
> Releases" recall that the hyperlink must change to point to version in the
> Apache Archives.
With this, we wo
yes - i will update that before i merge.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Looks, good, much cleaner now. I haven't tested all the links, but I picked out
some random releases and all links worked as expected.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Firefox renders the dropdown as black.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache
Shouldn't we throw in case we exceed the range of a int64?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1060 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
It's looking good, I have a doubt: would addition of `ByteIO` and others
represent a breaking change for Python users? I mean the expected type was x
and now is y.
cc @aboudreault
[ Full content available at: https://github.com/apache/tinkerpop/pull/1060 ]
This message was relayed via gitbox.a
I pushed a fix. Looks like there is no 'bootstrap-select' class. I changed it
to use the standard bootstrap form/select -
https://getbootstrap.com/docs/3.3/css/#forms-controls
[ Full content available at: https://github.com/apache/tinkerpop/pull/1059 ]
This message was relayed via gitbox.ap
It is. But not sure if we can do otherwise if we want to add this serializer.
Stephen, is the server really rejecting the data if we send a gx:Int32 in the
range of the Byte possible values?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1060 ]
This message was relayed via
101 - 200 of 9557 matches
Mail list logo
