[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-20 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220732937 Dozens of manual tests later... VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1003 Setting up latest...

2016-05-20 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/317 TINKERPOP-1003 Setting up latest/current links for bins and docs. This issue addresses https://issues.apache.org/jira/browse/TINKERPOP-1003 You can merge this pull request into a Git re

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1301 Provide Javadoc f...

2016-05-20 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/314#discussion_r64040220 --- Diff: hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/script/ScriptOutputFormat.java --- @@ -29,6 +29,12 @@

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1301 Provide Javadoc f...

2016-05-20 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/314#discussion_r64039957 --- Diff: hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/script/ScriptOutputFormat.java --- @@ -29,6 +29,12 @@

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220440890 These are "master traversal" traversers. Even before when it was stored in sideeffects, those are ultimately stored in `Configuration` (`TRAVERSAL`). Its the

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-19 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220434331 Even if this PR gets another +1, please don't merge yet, as I'm still doing lots of manual tests these days. I'm still not sure if I like halted traversers

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1305: HALTED_TRAVERSER...

2016-05-19 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220427562 VOTE +1 - `$ docker/build.sh -t -i -n` is all good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1088 Preserve Cardinal...

2016-05-19 Thread pluradj
Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/313#issuecomment-220426912 inspected the code, ran `mvn clean install` cleanly, looks good to me VOTE: +1 --- If your project is set up for it, you can reply to this email a

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035: HALTED_TRAVERSER...

2016-05-19 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220387063 Can you rename this PR? You transposed the number and the wrong JIRA ticket is getting the updates. --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035: HALTED_TRAVERSER...

2016-05-19 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/316#issuecomment-220384591 This also solves https://issues.apache.org/jira/browse/TINKERPOP-1298 --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1035: HALTED_TRAVERSER...

2016-05-19 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/316 TINKERPOP-1035: HALTED_TRAVERSERS hold wrong information https://issues.apache.org/jira/browse/TINKERPOP-1305 @dkuppitz found a severe bug in 3.2.0 in OLAP traversal chains. Inte

[GitHub] incubator-tinkerpop pull request: Remove dashes from property keys

2016-05-18 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/315#issuecomment-220136689 @analytically did you take note of the discussion on the dev mailing list? would you mind going the extra step to update other tests that might be a pro

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1088 Preserve Cardinal...

2016-05-18 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/313#issuecomment-220081559 Looks good (and there's no typo in `kaiserslautern` ;)). VOTE: +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-tinkerpop pull request: Remove dashes from property keys

2016-05-17 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/315#issuecomment-219682265 My inclination is to merge this, but I've started a discussion on this PR on the dev list to make sure the community is ok with this change: https://lis

[GitHub] incubator-tinkerpop pull request: Remove dashes from property keys

2016-05-16 Thread analytically
GitHub user analytically opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/315 Remove dashes from property keys Our driver implementation doesn't allow dashes in property keys. Hence remove them from the gremlin-test. You can merge this pull request into a G

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-16 Thread pluradj
Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-219442641 Opened https://issues.apache.org/jira/browse/TINKERPOP-1303 for the help suggestions --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-16 Thread pluradj
Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-219436216 Thanks for the updates. Looks good. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1301 Provide Javadoc f...

2016-05-14 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/314 TINKERPOP-1301 Provide Javadoc for ScriptInput/OutputFormat's This trivial patch consolidates the Javadoc and links to the official reference documentation for the very powerful ScriptI

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-13 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/312#issuecomment-219201548 docker/build.sh -t -i -n succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1088 Preserve Cardinal...

2016-05-13 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/313 TINKERPOP-1088 Preserve Cardinality in Subgraph https://issues.apache.org/jira/browse/TINKERPOP-1088 Fixes a problem where cardinality is better respected with subgraph step.

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-13 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-219036360 I've rebased, made some changes and force pushed... > Running the visual traversal didn't seem to do anything. I didn't see any event changes fl

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-13 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/312#issuecomment-219033703 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop ...

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-13 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/312#issuecomment-219009355 `docker/build.sh -t -i -n` succeeded. VOTE: +1 Btw., nice code snippet in the docs. --- If your project is set up for it, you can reply

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-12 Thread pluradj
Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-218965743 I was able to get the graph to render in Gephi. I'm running Gephi 0.9.1 on Mac. Applying the layout and fiddling with the viz properties worked fine.

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1281 & TINKERPOP-1282 ...

2016-05-12 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/312 TINKERPOP-1281 & TINKERPOP-1282 & TINKERPOP-1299: OLAP chains and traverser propagation https://issues.apache.org/jira/browse/TINKERPOP-1281 https://issues.apache.org/jira/browse/TINK

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-12 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/308#issuecomment-218852572 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-12 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/309#issuecomment-218726779 merged - thanks @analytically --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1300 Fixed many broken...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1300 Fixed many broken...

2016-05-11 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/311#issuecomment-218665177 `docker/build.sh -t -i -n` succeeded. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-11 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218614568 Nice looking tests. ran `mvn clean install` - all good VOTE +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1300 Fixed many broken...

2016-05-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/311#issuecomment-218552985 VOTE +1. This is CTR'able in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1300 Fixed many broken...

2016-05-11 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/311 TINKERPOP-1300 Fixed many broken count asserts not being applied in test suite. https://issues.apache.org/jira/browse/TINKERPOP-1300 tested with `mvn clean install -Dinclude

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-11 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#discussion_r62851083 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerGraphComputer.java --- @@ -54,6 +56,12

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-11 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/309#issuecomment-218463603 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] incubator-tinkerpop pull request:

2016-05-11 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/commit/034eb9e94e85e392df8b428f16f3a9bd2790923d#commitcomment-17433176 In CHANGELOG.asciidoc: In CHANGELOG.asciidoc on line 47: @twilmes note that i removed this entry from chang

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-11 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/309#issuecomment-218445503 i was going to CTR this but since we started a vote VOTE +1 --- If your project is set up for it, you can reply to this email and have you

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-11 Thread analytically
Github user analytically commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#discussion_r62817317 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerGraphComputer.java --- @@ -54,6

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-10 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/309#issuecomment-218364623 Simple enough. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218364465 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218332211 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop ...

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/307 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/310#issuecomment-218266032 CHANGELOG ``` * `GraphFilter` helper methods are now more intelligent when determining edge direction/label legality. * Added `GraphFilterStr

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1293: Implement GraphF...

2016-05-10 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/310 TINKERPOP-1293: Implement GraphFilterStrategy as a default registration for GraphComputer https://issues.apache.org/jira/browse/TINKERPOP-1293 `GraphFilterStrategy` (traversal op

[GitHub] incubator-tinkerpop pull request: Broaden catch for computePath.

2016-05-10 Thread analytically
GitHub user analytically opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/309 Broaden catch for computePath. I'm getting `java.lang.IllegalArgumentException: URI is not hierarchical`, on OS/X, but don't get any context, therefore broaden the catch. You can

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1297 Updated the gephi...

2016-05-10 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/308 TINKERPOP-1297 Updated the gephi plugin to work on Gephi 0.9.x https://issues.apache.org/jira/browse/TINKERPOP-1297 Also Improved output of HTTP request errors to gephi. It i

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-10 Thread PommeVerte
Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/307#issuecomment-218174710 `mvn clean install` runs for me as well and the changes make sense. :) VOTE +1 --- If your project is set up for it, you can reply to this ema

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-10 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/307#issuecomment-218128585 This is an interesting change. I was surprised to see that much difference between `compile()` and `eval()`. `eval()` ultimately calls compile but does

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-07 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/307#issuecomment-217633168 Perfect. This will come in handy with all my Friendster benchmarking that uses `ScriptInputFormat`. Did a code review, makes perfect sense.

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1295 Precompile Script...

2016-05-06 Thread twilmes
GitHub user twilmes opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/307 TINKERPOP-1295 Precompile ScriptInputFormat scripts once during initialization of ScriptRecordReader This update precompiles an input script and then reads the input file using the com

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21 to fix memo...

2016-05-06 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/306#issuecomment-217556221 this looks good - merged to `tp31` and `master`. CTR --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21 to fix memo...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread twilmes
Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#issuecomment-217482023 Excellent stuff VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#discussion_r62347949 --- Diff: spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/interceptor/SparkStarBarrierI

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread twilmes
Github user twilmes commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#discussion_r62346986 --- Diff: spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/interceptor/SparkStarBarrie

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-06 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#discussion_r62347464 --- Diff: spark-gremlin/src/main/java/org/apache/tinkerpop/gremlin/spark/process/computer/traversal/strategy/optimization/interceptor/SparkStarBarrierI

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#issuecomment-217317238 Ran `docker/build.sh -t -i` and all of it worked nicely. Didn't even get the gremlin server integration test fail. not sure why travis tanked - @okram

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-05 Thread analytically
Github user analytically commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-217310350 #306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21 to fix memo...

2016-05-05 Thread analytically
GitHub user analytically opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/306 Bump SLF4J to 1.7.21 to fix memory leak. You can merge this pull request into a Git repository by running: $ git pull https://github.com/analytically/incubator-tinkerpop tp31

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#issuecomment-217265299 That has nothing to do with spark. That test seems to fail on some systems some of the times (of course, never fails locally so that i can observe it ha

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1286 Added recipes fra...

2016-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/304 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/305#issuecomment-217260649 ``` [INFO] Apache TinkerPop .. SUCCESS [4.770s] [INFO] Apache TinkerPop :: Gremlin Shaded SUCCESS [2.3

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-05 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-217235407 Do you still plan to re-submit this PR? What you had looked good on #303 but it didn't base off of the `tp31` branch. --- If your project is set up fo

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/302 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1288 & TINKERPOP-1290:...

2016-05-05 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/305 TINKERPOP-1288 & TINKERPOP-1290: VertexProgramInterceptor and GraphComputer TraversalStrategies https://issues.apache.org/jira/browse/TINKERPOP-1288 https://issues.apache.org/jira/bro

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1286 Added recipes fra...

2016-05-05 Thread twilmes
Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/304#issuecomment-217157663 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1286 Added recipes fra...

2016-05-04 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/304#issuecomment-217023364 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] incubator-tinkerpop pull request: TINKERPOP=1286 Added recipes fra...

2016-05-04 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/304 TINKERPOP=1286 Added recipes framework. https://issues.apache.org/jira/browse/TINKERPOP-1286 Sample docs for review are generated to here: http://tinkerpop.apache.or

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216955474 VOTE +1 - tested with `mvn clean install` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216949111 My other machine is my my usual dev machine. I was trying to optimize things by running full test suites on OpenStack CoreOS instances, that failed. I wil

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-04 Thread analytically
Github user analytically closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-04 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/303#issuecomment-216902930 Thanks but you created your PR against "master" again. When you create your PR, make sure to select the "tp31" branch from the drop down. --- If your p

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-04 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-216897117 Thanks for pointing this out. I think we should make this fix available on 3.1.x and 3.2.x. Can you please re-target this pull request for the `tp31` br

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-04 Thread analytically
Github user analytically commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-216902327 Done, #303. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-04 Thread analytically
GitHub user analytically opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/303 Bump SLF4J to 1.7.21 Releases 1.7.19 and 1.7.20 suffer from a memory leak. See http://www.slf4j.org/news.html. You can merge this pull request into a Git repository by running:

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-04 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-216893595 Ok - changes are good with: `$ docker/build.sh -t -i -n` --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216886769 That is a wierd `NullPointerException` in that the `graphProvider` of the test is null. ``` graphProvider = GraphManager.getGraphProvider

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216879128 Build worked properly on the other machine. VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216867769 That's the full log of the 2nd time it failed: https://gist.github.com/dkuppitz/406e2e89dc10b74aeaef9a11c4bb7718 --- If your project is set up for it, yo

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216862192 Another thing that is weird. `TinkerGraphStepStrategyTest` doesn't even use `TraversalVertexProgram` and thus, this failure is in no way related to the chang

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216856863 @dkuppitz --- I can't seem to reproduce this. Note that there is nothing in this PR that has to do with the testing infrastructure (`AbstractGremlinTest`) or

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-04 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216837485 I see test failures. ``` Results : Tests in error: TinkerGraphStepStrategyTest>AbstractGremlinTest.setup:80 ? NullPointer Tink

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-04 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-216825501 Removed the `ComputerResultStep` interruption check and rebased. Waiting for a clean build then will merge. --- If your project is set up for it, you c

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

2016-05-03 Thread analytically
GitHub user analytically opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/302 Bump SLF4J to 1.7.21 Releases 1.7.19 and 1.7.20 suffer from a memory leak. See http://www.slf4j.org/news.html. You can merge this pull request into a Git repository by running:

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1279: Add Iterable ...

2016-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-03 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-216542972 You don't need it in `ComputerResultStep` either as that is a simple `AbstractStep` and thus, gets the "interrupt check" from `next()/hasNext()` of `Abstract

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-03 Thread okram
Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/301#issuecomment-216533557 VOTE +1 -- integration tests and Blade cluster benchmarking/testing. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1120: If there is no v...

2016-05-03 Thread okram
GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/301 TINKERPOP-1120: If there is no view nor messages, don't create empty views/messages in SparkExecutor https://issues.apache.org/jira/browse/TINKERPOP-1120 The following PR effects

[GitHub] incubator-tinkerpop pull request: TINKERPOP-946 Interrupting Trave...

2016-05-03 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/299#issuecomment-216502810 I just pushed a change as you suggested @okram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1279: Add Iterable ...

2016-05-03 Thread dkuppitz
Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/300#issuecomment-216462211 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1279: Add Iterable ...

2016-05-02 Thread spmallette
Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/300#issuecomment-216323331 All good with `mvn clean install` - VOTE + 1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1279: Add Iterable ...

2016-05-02 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/300#discussion_r61778514 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/AndP.java --- @@ -29,11 +32,19 @@ */ publ

[GitHub] incubator-tinkerpop pull request: TINKERPOP-1268 Interactive and E...

2016-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

  1   2   3   4   5   6   7   8   9   10   >