Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user PommeVerte commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#issuecomment-151126326
I requested the merge against TINKERPOP3-910 (and not master) does this
have to go through a double vote? one here and then in 910?
---
If your project
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#issuecomment-151125911
It just occurred to me that we don't need a VOTE here. This is a PR to a
branch that is not a "release" branch - I can just merge this. Then I will
ma
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#issuecomment-151125008
I've run these tests locally when I added the code that I did in this
branch. `SimpleClient` is a wreck in this kind of test case, but not much we
can
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#issuecomment-151123789
The code looks clean and simple to me.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user PommeVerte commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#issuecomment-151122955
dur. It's a slow monday. I've made the change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/121#discussion_r42982777
--- Diff:
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
---
@@ -102,6 +102,10 @@ public Se
GitHub user PommeVerte opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/121
added tests around single channel in session and sessionless requests
I added the tests I had around this change. These pass:
```
mvn clean install -DincludeNeo4j
mvn
