DO NOT REPLY [Bug 42363] New: - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r536455 - /tomcat/container/tc5.5.x/webapps/docs/config/valve.xml

2007-05-09 Thread jfclere
Author: jfclere Date: Wed May 9 01:13:16 2007 New Revision: 536455 URL: http://svn.apache.org/viewvc?view=rev&rev=536455 Log: Arrange default value. Modified: tomcat/container/tc5.5.x/webapps/docs/config/valve.xml Modified: tomcat/container/tc5.5.x/webapps/docs/config/valve.xml URL: http:/

svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

2007-05-09 Thread jfclere
Author: jfclere Date: Wed May 9 01:14:37 2007 New Revision: 536456 URL: http://svn.apache.org/viewvc?view=rev&rev=536456 Log: Arrange the default value of pattern. Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml URL:

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r536456 - /tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

2007-05-09 Thread Takayuki Kaneko
Hi, IMO, you should arrenge the document like this. -default) corresponds to %h %l %u %t "%r" %s %b". +default) corresponds to %h %l %u %t "%r" %s %b. "common" pattern is defined at org.apache.catalina.valves.Constant public static final String COMMON_PATTERN = "%h %l %u %t \"%r\"

Re: Comet changes

2007-05-09 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I agree, but I don't understand how you can know if you can write without a write polling. If there are no events on read, I have the impression writing could be suspended for an indefinite amount of time. So

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 34509] - tag names that are xml:Name but not java identifier are not accepted

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r536518 - in /tomcat/tc6.0.x/trunk/res/procrun: amd64/tomcat6.exe amd64/tomcat6w.exe ia64/tomcat6.exe ia64/tomcat6w.exe tomcat6.exe tomcat6w.exe

2007-05-09 Thread mturk
Author: mturk Date: Wed May 9 06:32:57 2007 New Revision: 536518 URL: http://svn.apache.org/viewvc?view=rev&rev=536518 Log: Update fixed binaries that will do a thread dump on stdout redirected file even if the log level is < INFO Modified: tomcat/tc6.0.x/trunk/res/procrun/amd64/tomcat6.exe

svn commit: r536520 - in /tomcat/connectors/trunk/procrun/bin: amd64/tomcat5.exe amd64/tomcat5w.exe ia64/tomcat5.exe ia64/tomcat5w.exe tomcat5.exe tomcat5w.exe

2007-05-09 Thread mturk
Author: mturk Date: Wed May 9 06:35:30 2007 New Revision: 536520 URL: http://svn.apache.org/viewvc?view=rev&rev=536520 Log: Update fixed binaries that will do a thread dump on stdout redirected file even if the log level is < INFO Modified: tomcat/connectors/trunk/procrun/bin/amd64/tomcat5.

Re: Comet changes

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I agree, but I don't understand how you can know if you can write without a write polling. If there are no events on read, I have the impression writing could be suspended for an indefini

Re: [VOTE] Release build 6.0.13

2007-05-09 Thread Filip Hanik - Dev Lists
I'll vote friday morning, after I've had some more time for it :) Filip Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.13/ According to the release process, the 6.0.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Rémy --

svn commit: r536529 - in /tomcat/tc6.0.x/trunk/res/procrun: amd64/tomcat6.exe amd64/tomcat6w.exe ia64/tomcat6.exe ia64/tomcat6w.exe tomcat6.exe tomcat6w.exe

2007-05-09 Thread mturk
Author: mturk Date: Wed May 9 06:54:04 2007 New Revision: 536529 URL: http://svn.apache.org/viewvc?view=rev&rev=536529 Log: Fix binaries by using /D_UNICODE for library as well. Modified: tomcat/tc6.0.x/trunk/res/procrun/amd64/tomcat6.exe tomcat/tc6.0.x/trunk/res/procrun/amd64/tomcat6w.e

svn commit: r536532 - in /tomcat/connectors/trunk/procrun/bin: amd64/tomcat5.exe amd64/tomcat5w.exe ia64/tomcat5.exe ia64/tomcat5w.exe tomcat5.exe tomcat5w.exe

2007-05-09 Thread mturk
Author: mturk Date: Wed May 9 06:56:58 2007 New Revision: 536532 URL: http://svn.apache.org/viewvc?view=rev&rev=536532 Log: Fix binaries by using /D_UNICODE for library as well. Modified: tomcat/connectors/trunk/procrun/bin/amd64/tomcat5.exe tomcat/connectors/trunk/procrun/bin/amd64/tomc

Re: Comet changes

2007-05-09 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: So it uses a poller automatically, and the WRITE event would be sent when the socket is signaled by the poller, then. This is very similar. The only problem is that it could cause sync issues, since the servlet

DO NOT REPLY [Bug 42366] New: - Memory leak in newer mod_jk version when connection is abortet by the client

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r536540 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/io/BufferPool.java

2007-05-09 Thread fhanik
Author: fhanik Date: Wed May 9 07:18:25 2007 New Revision: 536540 URL: http://svn.apache.org/viewvc?view=rev&rev=536540 Log: volatile should ensure double locking to work properly Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/io/BufferPool.java Modified: tomcat/tc6.0.x/tr

Re: Comet changes

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: So it uses a poller automatically, and the WRITE event would be sent when the socket is signaled by the poller, then. This is very similar. The only problem is that it could cause sync is

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42367] New: - cookies=false setting in context.xml not being honored

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r536554 - in /tomcat/tc6.0.x/trunk/webapps/ROOT: index.html index.jsp

2007-05-09 Thread funkman
Author: funkman Date: Wed May 9 07:53:40 2007 New Revision: 536554 URL: http://svn.apache.org/viewvc?view=rev&rev=536554 Log: bad link : s/tomcat-docs/docs/ Modified: tomcat/tc6.0.x/trunk/webapps/ROOT/index.html tomcat/tc6.0.x/trunk/webapps/ROOT/index.jsp Modified: tomcat/tc6.0.x/trunk

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [VOTE] Release build 6.0.13

2007-05-09 Thread Yoav Shapira
Hola, On 5/8/07, Remy Maucherat <[EMAIL PROTECTED]> wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.13/ According to the release process, the 6.0.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [ X ] Stable Based on quick testing, no TCK etc. Yoav --

DO NOT REPLY [Bug 42359] - win64/jk-1.2.22/amd64 build of isapi_redirect.dll does not work on Windows 2003 R2

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: [VOTE] Release build 6.0.13

2007-05-09 Thread Mladen Turk
Remy Maucherat wrote: According to the release process, the 6.0.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable BTW, can you repack the binaries with the latest tomcat6.exe. At least it allows a thread dump to the stdout.log for standard log level. If it would require a new tag, just forg

Re: Comet changes

2007-05-09 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: true. lets see how it pans out in actual code, that might change our perspective. I was toying around with an alternative idea too, disallow any read or write all together unless it is done on a worker thread. gives us complete control, easier to implement. pu

DO NOT REPLY [Bug 42363] - Double-checked locking in BufferPool

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r536580 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioEndpoint.java

2007-05-09 Thread fhanik
Author: fhanik Date: Wed May 9 09:46:06 2007 New Revision: 536580 URL: http://svn.apache.org/viewvc?view=rev&rev=536580 Log: Separate out read vs write latches, simplify implementation, avoid concurrency issues and prepare for new comet strategies Modified: tomcat/tc6.0.x/trunk/java/org/a

Re: svn commit: r536580 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioEndpoint.java

2007-05-09 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: fhanik Date: Wed May 9 09:46:06 2007 New Revision: 536580 URL: http://svn.apache.org/viewvc?view=rev&rev=536580 Log: Separate out read vs write latches, simplify implementation, avoid concurrency issues and prepare for new comet strategies Do you have the API

Re: Comet changes

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: true. lets see how it pans out in actual code, that might change our perspective. I was toying around with an alternative idea too, disallow any read or write all together unless it is done on a worker thread. gives us complete control, ea

Re: Comet changes

2007-05-09 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: oh crap, we are thinking way different :), I was thinking the other way around Here is one event chain 1. CometProcessor.event(CometEvent.BEGIN/null) 2. Servlet calls CometEvent.setBlocking(false); 3. Servlet calls CometEvent.notify(READ) - the servlet wants to be

Re: svn commit: r536580 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioEndpoint.java

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: fhanik Date: Wed May 9 09:46:06 2007 New Revision: 536580 URL: http://svn.apache.org/viewvc?view=rev&rev=536580 Log: Separate out read vs write latches, simplify implementation, avoid concurrency issues and prepare for new comet strategie

Re: [VOTE] Release build 6.0.13

2007-05-09 Thread Remy Maucherat
Mladen Turk wrote: Remy Maucherat wrote: According to the release process, the 6.0.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable BTW, can you repack the binaries with the latest tomcat6.exe. At least it allows a thread dump to the stdout.log for standard log level. If it would require

DO NOT REPLY [Bug 42366] - Memory leak in newer mod_jk version when connection is abortet by the client

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Comet changes

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: oh crap, we are thinking way different :), I was thinking the other way around Here is one event chain 1. CometProcessor.event(CometEvent.BEGIN/null) 2. Servlet calls CometEvent.setBlocking(false); 3. Servlet calls CometEvent.notify(READ) -

Re: Comet changes

2007-05-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: oh crap, we are thinking way different :), I was thinking the other way around Here is one event chain 1. CometProcessor.event(CometEvent.BEGIN/null) 2. Servlet calls CometEvent.setBlocking(false); 3. Servlet calls CometEvent.notify(READ) -

Re: Comet changes

2007-05-09 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: 1. CometEvent.notify is a servlet calling container method,not a callback from the container The servlet calls the "notify" method, right ? 2. Introduce a new EventType -> NOTIFY 3. Keep the sub event type -> WRITE_COMPLETE, instead of having to busy poll Comet

DO NOT REPLY [Bug 42375] New: - Startup error logging is useless

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42360] - Custom Tag resue specs

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 42376] New: - java/lang/NoClassDefFoundError: java/lang/Object

2007-05-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu