Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: You could copy it to some sandbox or something, since there is lots of usable code in there like console mode httpd API client for testing modules, etc. It's trivial to svn cp -r 571005

Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread William A. Rowe, Jr.
Mladen Turk wrote: Right. Deleting entire trees from SVN should at least be preceded by some note of intention. +1. A heads up is always a good idea ;-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

svn commit: r571063 - in /tomcat/connectors/trunk/jk: native/ native/common/ native/iis/ native/iis/installer/ xdocs/miscellaneous/

2007-08-30 Thread rjung
Author: rjung Date: Thu Aug 30 00:45:42 2007 New Revision: 571063 URL: http://svn.apache.org/viewvc?rev=571063view=rev Log: Change JK version to 1.2.26-dev. Modified: tomcat/connectors/trunk/jk/native/STATUS.txt tomcat/connectors/trunk/jk/native/common/jk_version.h

svn commit: r571064 - in /tomcat/connectors/trunk/jk: BUILD.txt native/README.txt native/netscape/README

2007-08-30 Thread rjung
Author: rjung Date: Thu Aug 30 00:47:00 2007 New Revision: 571064 URL: http://svn.apache.org/viewvc?rev=571064view=rev Log: Fix file name BUILDING - BUILDING.txt in other readme files. Modified: tomcat/connectors/trunk/jk/BUILD.txt tomcat/connectors/trunk/jk/native/README.txt

Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread Mark Thomas
Mladen Turk wrote: [EMAIL PROTECTED] wrote: Author: markt Date: Wed Aug 29 18:14:11 2007 New Revision: 571006 URL: http://svn.apache.org/viewvc?rev=571006view=rev Log: Remove source for mod_proxy_ajp that moved to httpd some time ago. Why the hell did you do that? Because it hadn't

svn commit: r571126 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread markt
Author: markt Date: Thu Aug 30 05:09:55 2007 New Revision: 571126 URL: http://svn.apache.org/viewvc?rev=571126view=rev Log: Revert removal of ajp directory Added: tomcat/connectors/trunk/ajp/ - copied from r571005, tomcat/connectors/trunk/ajp/

Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread Mark Thomas
William A. Rowe, Jr. wrote: Mladen Turk wrote: Right. Deleting entire trees from SVN should at least be preceded by some note of intention. +1. A heads up is always a good idea ;-) Noted. Sorry for the hassle. Will do in future. Mark

svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread rjung
Author: rjung Date: Thu Aug 30 07:10:35 2007 New Revision: 571175 URL: http://svn.apache.org/viewvc?rev=571175view=rev Log: Match header names exactly against pre defined constants. Avoid possible confusion with custom header names using a standard header name as a prefix. Ported from a patch

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Match header names exactly against pre defined constants. p += 6; -if (memcmp(p, CHARSET, 7) == 0) +if (strcmp(p, CHARSET) == 0) Someone would say that this is over engineering :) memcmp *is always* faster

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Mladen Turk wrote: [EMAIL PROTECTED] wrote: Match header names exactly against pre defined constants. p += 6; -if (memcmp(p, CHARSET, 7) == 0) +if (strcmp(p, CHARSET) == 0) Someone would say that this is over engineering :) memcmp

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Rainer Jung
No problem, better safe than sorry. In fact there are a couple of memcmp in the same file (decoding http method), that are OK, because we already know that the string length is OK. For the headers the parsing strategy is slightly different and there is now prevention for matching longer

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: No problem, better safe than sorry. Right. It seems I always forget the ingenuity of the users that wish to extent the http spec :) However, I think that we can still use the memcmp with xxx\0. That would still be faster then figuring out the EOL with strcmp? Regards,

Tomcat 6 fails to start on Terminal Server

2007-08-30 Thread jhayden
Have installed Tomcat onto MS Terminal Server. However when attempting to start Tomcat it fails. Have tried version 5.5 and 6.0 and both give the same failure. Here are the logs below - [2007-08-30 15:34:10] [info] Running Service... [2007-08-30 15:34:10] [info] Starting service... [2007-08-30

re: TC6 source file licensing - last few files

2007-08-30 Thread Jeanfrancois Arcand
Hi Mark, sorry for the delay...vacation time :-) Subject: TC6 source file licensing - last few files Date: Sun, 05 Aug 2007 00:25:50 -0400 From: Mark Thomas [EMAIL PROTECTED] Reply-To: Tomcat Developers List dev@tomcat.apache.org To: Tomcat Developers List dev@tomcat.apache.org All, Sorry

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Rainer Jung
Mladen Turk wrote: Rainer Jung wrote: No problem, better safe than sorry. Right. It seems I always forget the ingenuity of the users that wish to extent the http spec :) However, I think that we can still use the memcmp with xxx\0. That would still be faster then figuring out the EOL with

Default to index.html over index.jsp in ROOT

2007-08-30 Thread jhayden
After changing port to 80 attmpting to use Tomcat as a HTTP server as well as a container. When entering http:\\localhost I am getting the standard Tomcat display. However its being drawn from the index.jsp rather than the index.html due the message on the page detailing

svn commit: r571202 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java webapps/docs/changelog.xml

2007-08-30 Thread pero
Author: pero Date: Thu Aug 30 08:14:48 2007 New Revision: 571202 URL: http://svn.apache.org/viewvc?rev=571202view=rev Log: DeltaManager sessionCounter must be also increment at relicated sessions. Modified:

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Rainer Jung
Mladen Turk wrote: Rainer Jung wrote: But the header could be shorter than the constant string. So there was a second problem with the old code, we eventually compared potentially uninitialized memory to string constants. Strictly speaking the result was not defined. Sorry, but you get

svn commit: r571204 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp: DataSender.java LocalStrings.properties mbeans-descriptors.xml

2007-08-30 Thread pero
Author: pero Date: Thu Aug 30 08:25:46 2007 New Revision: 571204 URL: http://svn.apache.org/viewvc?rev=571204view=rev Log: Made attribute createTime accessible for all DataSenders. Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: Yes Mladen, I know. But we never really use len :) I know, that we can do it with memcmp, but then you, me or someone else has to add a couple of if(len=...) before each memcmp(). Go ahead if you like to. Look, we have a local header[16] on which we copy toupper, and

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Rainer Jung
Mladen Turk wrote: Rainer Jung wrote: Yes Mladen, I know. But we never really use len :) I know, that we can do it with memcmp, but then you, me or someone else has to add a couple of if(len=...) before each memcmp(). Go ahead if you like to. Look, we have a local header[16] on which we

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: +/* Always do memcmp including the final \0-termination character. + */ switch (header[0]) { case 'A': -if (memcmp(p, CCEPT, 5) == 0) { +if (memcmp(p, CCEPT, 6) == 0) { Right, but like said this should be a if

Re: Tomcat 6 fails to start on Terminal Server

2007-08-30 Thread Pid
Try submitting this question to the Tomcat Users list. This list is for the developers of the server itself. p jhayden wrote: Have installed Tomcat onto MS Terminal Server. However when attempting to start Tomcat it fails. Have tried version 5.5 and 6.0 and both give the same failure. Here

svn commit: r571222 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-08-30 Thread rjung
Author: rjung Date: Thu Aug 30 09:04:19 2007 New Revision: 571222 URL: http://svn.apache.org/viewvc?rev=571222view=rev Log: Rollback patch in r571175. A slightly better patch will be coming next. Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Modified:

svn commit: r571226 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-08-30 Thread rjung
Author: rjung Date: Thu Aug 30 09:15:39 2007 New Revision: 571226 URL: http://svn.apache.org/viewvc?rev=571226view=rev Log: Redo the patch from r571175 (exact comparison of header names). Keep using memcmp, but add \0-termination byte to comparison. This works, because we know the header variable

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Jim Jagielski
On Aug 30, 2007, at 11:45 AM, Mladen Turk wrote: Rainer Jung wrote: +/* Always do memcmp including the final \0-termination character. + */ switch (header[0]) { case 'A': -if (memcmp(p, CCEPT, 5) == 0) { +if (memcmp(p, CCEPT, 6) == 0) { Right,

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Rainer Jung
Jim Jagielski wrote: On Aug 30, 2007, at 11:45 AM, Mladen Turk wrote: Rainer Jung wrote: +/* Always do memcmp including the final \0-termination character. + */ switch (header[0]) { case 'A': -if (memcmp(p, CCEPT, 5) == 0) { +if (memcmp(p, CCEPT,

svn commit: r571276 - in /tomcat/trunk: java/org/apache/catalina/session/StandardManager.java java/org/apache/catalina/startup/NamingRuleSet.java webapps/docs/config/cluster-manager.xml webapps/docs/c

2007-08-30 Thread fhanik
Author: fhanik Date: Thu Aug 30 12:14:43 2007 New Revision: 571276 URL: http://svn.apache.org/viewvc?rev=571276view=rev Log: forward port of bugfixes from 6.0 Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

DO NOT REPLY [Bug 43228] - StandardWrapper#countAllocated isn't thread-safe

2007-08-30 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=43228. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE.

svn commit: r571364 - in /tomcat/servletapi/servlet2.4-jsp2.0-tc5.x/jsr154/src/share/javax/servlet: http/package.html package.html

2007-08-30 Thread markt
Author: markt Date: Thu Aug 30 21:06:12 2007 New Revision: 571364 URL: http://svn.apache.org/viewvc?rev=571364view=rev Log: As per http://marc.info/?l=tomcat-devm=118848624422496w=2, correct the license text for these files. Modified:

svn commit: r571365 - in /tomcat/tc6.0.x/trunk/java/javax/servlet: http/package.html package.html

2007-08-30 Thread markt
Author: markt Date: Thu Aug 30 21:08:41 2007 New Revision: 571365 URL: http://svn.apache.org/viewvc?rev=571365view=rev Log: As per http://marc.info/?l=tomcat-devm=118848624422496w=2, correct the license text for these files. Modified: