Regarding JAAS logout patch (for bug 39231)

2009-08-15 Thread Konstantin Kolinko
The following patch is currently in voting for 5.5 and 6.0 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231 http://svn.apache.org/viewvc?rev=791900&view=rev http://svn.apache.org/viewvc?rev=792446&view=rev (Filip's suggestion) JAAS LoginContext expects a call to logout() I hav

Re: local changes on /www/tomcat.apache.org

2009-08-15 Thread Konstantin Kolinko
2009/8/13 Konstantin Kolinko : > 2009/8/13 Konstantin Kolinko : >> 26th of March, 2009 is certainly a Thursday this year, not a Friday. > Thursday >> >> Looks like someone was making corrections in a rush before the event. >> >> By the way, "Apache Tomcat - Apache Tomcat" (repeated twice) is a lame

svn commit: r804559 [3/3] - in /tomcat/site/trunk: docs/ xdocs/

2009-08-15 Thread kkolinko
Modified: tomcat/site/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/index.xml?rev=804559&r1=804558&r2=804559&view=diff == --- tomcat/site/trunk/xdocs/index.xml (original) +++ tomcat/site/t

svn commit: r804558 - /tomcat/site/trunk/build.xml

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 04:02:57 2009 New Revision: 804558 URL: http://svn.apache.org/viewvc?rev=804558&view=rev Log: Fix Ant warning Modified: tomcat/site/trunk/build.xml Modified: tomcat/site/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/build.xml?rev=80455

svn commit: r804557 - /tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 03:39:52 2009 New Revision: 804557 URL: http://svn.apache.org/viewvc?rev=804557&view=rev Log: Correct template for HTML META tag. It does not have 'value' attribute, but has 'content'. Also, do not publish e-mails. Modified: tomcat/site/trunk/xdocs/styleshee

svn commit: r804556 - /tomcat/site/trunk/xdocs/whoweare.xml

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 03:29:21 2009 New Revision: 804556 URL: http://svn.apache.org/viewvc?rev=804556&view=rev Log: Correct name, based on its mention in the following file: http://svn.apache.org/repos/asf/tomcat/archive/tc3.3.x/trunk/container/KEYS Modified: tomcat/site/trunk/xdo

svn commit: r804553 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 02:49:04 2009 New Revision: 804553 URL: http://svn.apache.org/viewvc?rev=804553&view=rev Log: Update wrong day of week Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://

DO NOT REPLY [Bug 47566] Update to NSIS 2.45

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r804551 - in /tomcat/tc5.5.x/trunk: STATUS.txt build/build.properties.default container/webapps/docs/changelog.xml

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 02:35:17 2009 New Revision: 804551 URL: http://svn.apache.org/viewvc?rev=804551&view=rev Log: Apply https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 Update to NSIS 2.45 NSIS 2.45 Release notes: http://sourceforge.net/project/shownotes.php?release_id=68804

svn commit: r804550 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt build.properties.default webapps/docs/changelog.xml

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 02:27:48 2009 New Revision: 804550 URL: http://svn.apache.org/viewvc?rev=804550&view=rev Log: Apply https://issues.apache.org/bugzilla/show_bug.cgi?id=47566 Update to NSIS 2.45 NSIS 2.45 Release notes: http://sourceforge.net/project/shownotes.php?release_id=68804

svn commit: r804549 - /tomcat/trunk/build.properties.default

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 02:17:52 2009 New Revision: 804549 URL: http://svn.apache.org/viewvc?rev=804549&view=rev Log: The problem at sourceforge was solved. Revert to the original configuration, but leave a comment there. Modified: tomcat/trunk/build.properties.default Modified: to

svn commit: r804547 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 02:08:44 2009 New Revision: 804547 URL: http://svn.apache.org/viewvc?rev=804547&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=8045

svn commit: r804545 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 01:58:37 2009 New Revision: 804545 URL: http://svn.apache.org/viewvc?rev=804545&view=rev Log: Add missed part of the patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/t

svn commit: r804544 - /tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java

2009-08-15 Thread kkolinko
Author: kkolinko Date: Sun Aug 16 01:55:25 2009 New Revision: 804544 URL: http://svn.apache.org/viewvc?rev=804544&view=rev Log: Return 'false' if nested copyDir call failed. It is part of the patch for issue 45403 that was applied in rev.804462 Modified: tomcat/trunk/java/org/apache/catalina/

RE: /dev/urandom usage

2009-08-15 Thread George Sexton
OK, I looked at this some more. What's really happening is ManagerBase is using /dev/urandom if it exists in getRandomBytes(). getRandom() is just a fallback if devRandomSource (/dev/urandom) doesn't exist. >From digging deeper, it looks like StandardContext instantiates a copy of StandardManager

DO NOT REPLY [Bug 40001] HTML pages should not use GET to restart web-apps.

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40001 lucenebugs2...@danielnaber.de changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #

DO NOT REPLY [Bug 40001] HTML pages should not use GET to restart web-apps.

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40001 --- Comment #4 from lucenebugs2...@danielnaber.de 2009-08-15 15:20:41 PDT --- Created an attachment (id=24139) suggested fix This patch changes the reload/start/stop/undeploy links to buttons and makes sure the servlet only reacts to POST

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-15 Thread Konstantin Kolinko
2009/8/14 Filip Hanik - Dev Lists : > On 08/14/2009 10:48 AM, Costin Manolache wrote: >> >> +1 - Executor seems the right interface, didn't exist when workers were >> started - ifanyone needs the pool behavior it can probably be implemented >> as >> an Executor. >> >> I assume you'll have some way

Eclipse project file for tc5.5.x

2009-08-15 Thread Konstantin Kolinko
Hi! I have prepared Eclipse project file to be put into the root folder of tc5.5, like we have that in tc6.0 and trunk. If anyone is interested, I put it here: http://people.apache.org/~kkolinko/2009-08-15_tc55_eclipse_project/ (just rename _classpath -> .classpath, _project -> .project) I just

Re: svn commit: r804530 - /tomcat/tc5.5.x/trunk/

2009-08-15 Thread Konstantin Kolinko
Mark, you could put your output into .settings/output, like the 6.0.x project does. ;) Anyway, I do not mind against this svn:ignore. It does no harm. 2009/8/16 : > Author: markt > Date: Sat Aug 15 20:44:01 2009 > New Revision: 804530 > > URL: http://svn.apache.org/viewvc?rev=804530&view=rev >

Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread Konstantin Kolinko
2009/8/15 Mark Thomas : > kkoli...@apache.org wrote: >> +  Note: >> +    - I cannot test bug 45403 on Windows, as it is Un*x-specific > > I assume you mean that you haven't been able to test this on *nix. If > not, ignore most of what I have written below :) > > There are a couple of options here.

svn commit: r804532 - /tomcat/tc5.5.x/trunk/connectors/jni/

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 20:47:12 2009 New Revision: 804532 URL: http://svn.apache.org/viewvc?rev=804532&view=rev Log: Ignore an output directory Modified: tomcat/tc5.5.x/trunk/connectors/jni/ (props changed) Propchange: tomcat/tc5.5.x/trunk/connectors/jni/ --

svn commit: r804530 - /tomcat/tc5.5.x/trunk/

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 20:44:01 2009 New Revision: 804530 URL: http://svn.apache.org/viewvc?rev=804530&view=rev Log: Add another ignore for Eclipse Modified: tomcat/tc5.5.x/trunk/ (props changed) Propchange: tomcat/tc5.5.x/trunk/

DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 --- Comment #17 from Mark Thomas 2009-08-15 20:55:36 BST --- Can you attach the simplest JSP that exhibits this error? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail

DO NOT REPLY [Bug 47688] Documentation update for BUILDING.txt

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47688 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r804514 - /tomcat/tc5.5.x/trunk/build/BUILDING.txt

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 18:45:24 2009 New Revision: 804514 URL: http://svn.apache.org/viewvc?rev=804514&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47688 Patch provided by sebb, with minor mods for line length Modified: tomcat/tc5.5.x/trunk/build/BUILDING.txt

DO NOT REPLY [Bug 43656] ELSupport.coerceToType modifies BigDecimal Values

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 Luke Kolin changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

DO NOT REPLY [Bug 41824] Unable to use nested type in TLD

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r804512 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/webapps/docs/changelog.xml jasper/src/share/org/apache/jasper/compiler/JspUtil.java

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 18:37:34 2009 New Revision: 804512 URL: http://svn.apache.org/viewvc?rev=804512&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 Need to use canonical rather than binary form when writing code Modified: tomcat/tc5.5.x/trunk/STATUS.txt

DO NOT REPLY [Bug 24739] Control of secure flag when establishing sessions through https using cookies

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=24739 Mark Thomas changed: What|Removed |Added CC||colinwilsons...@bluecycle.c

DO NOT REPLY [Bug 28780] Need non-secure JSESSIONID cookies

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=28780 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 29141] JNDI Datasource HOW-TO server.xml config example doesn't work

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=29141 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 33967] add a parameter to Context

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=33967 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 34616] Cookie authorization in Tomcat.

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=34616 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r804507 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 18:16:45 2009 New Revision: 804507 URL: http://svn.apache.org/viewvc?rev=804507&view=rev Log: Vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=804507&

svn commit: r804502 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 18:04:52 2009 New Revision: 804502 URL: http://svn.apache.org/viewvc?rev=804502&view=rev Log: Few votes, remove an applied patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.

svn commit: r804501 - in /tomcat/tc6.0.x/trunk: ./ build.xml dist.xml extras.xml

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 18:03:46 2009 New Revision: 804501 URL: http://svn.apache.org/viewvc?rev=804501&view=rev Log: Port Rainer's comment improvement from trunk Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/build.xml tomcat/tc6.0.x/trunk/dist.xml

DO NOT REPLY [Bug 41824] Unable to use nested type in TLD

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 --- Comment #3 from Mark Thomas 2009-08-15 18:59:57 BST --- This has been fixed in 6.0.x and will be included in 6.0.21 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving

svn commit: r804499 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/compiler/JspUtil.java webapps/docs/changelog.xml

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 17:59:51 2009 New Revision: 804499 URL: http://svn.apache.org/viewvc?rev=804499&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41824 Need to use canonical rather than binary form when writing code Modified: tomcat/tc6.0.x/trunk/ (props ch

svn commit: r804497 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 17:49:54 2009 New Revision: 804497 URL: http://svn.apache.org/viewvc?rev=804497&view=rev Log: Withdraw old access log patch. Propose new one. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/

svn commit: r804495 - /tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 17:40:40 2009 New Revision: 804495 URL: http://svn.apache.org/viewvc?rev=804495&view=rev Log: Replace syncs with threadlocals. Improve the logic that determines when to generate a new format string Modified: tomcat/trunk/java/org/apache/catalina/valves/ExtendedA

svn commit: r804463 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 12:10:45 2009 New Revision: 804463 URL: http://svn.apache.org/viewvc?rev=804463&view=rev Log: Withdraw old patch. Vote for new one. Include svn ref and additional testing info Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt U

svn commit: r804462 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappLoader.java

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 12:07:42 2009 New Revision: 804462 URL: http://svn.apache.org/viewvc?rev=804462&view=rev Log: Apply Konstantin's new patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 Modified: tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.propertie

DO NOT REPLY [Bug 45403] Tomcat does not reload application

2009-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 --- Comment #5 from Mark Thomas 2009-08-15 13:06:47 BST --- The proposed patch failed to obtain the required votes. A new patch has been applied to trunk and proposed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.c

svn commit: r804461 - /tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java

2009-08-15 Thread markt
Author: markt Date: Sat Aug 15 12:06:24 2009 New Revision: 804461 URL: http://svn.apache.org/viewvc?rev=804461&view=rev Log: Revert r701358 for https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 Modified: tomcat/trunk/java/org/apache/naming/resources/FileDirContext.java Modified: tomca

Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread Mark Thomas
kkoli...@apache.org wrote: > + -1: kkolinko: ( > + FileDirContext#file() contains a check that file.canRead() is true. > + A side-effect of this patch will be that files that are not readable > + will be excluded from the enumeration provided by FileDirContext#list() > + or Fil