Re: Gump failures

2010-02-08 Thread Bill Barker
Yes, there was a typo in the Gump metadata defining the value of jdt.jar. I've checked in a fix to the Gump repository so hopefully it should work for the next Gump run. Of course, I could have given Gump a valid place to download, but that is a waste of time downloading things it doesn't need

Re: Gump failures

2010-02-08 Thread Konstantin Kolinko
Regarding Gump failures with building tomcat-trunk: Looking here http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html I see Command Line /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.mer

buildbot failure in ASF Buildbot on tomcat-6-trunk

2010-02-08 Thread buildbot
The Buildbot has detected a new failure of tomcat-6-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/50 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/tc6.0.x/

svn commit: r907869 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 01:17:18 2010 New Revision: 907869 URL: http://svn.apache.org/viewvc?rev=907869&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=

svn commit: r907866 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 01:09:38 2010 New Revision: 907866 URL: http://svn.apache.org/viewvc?rev=907866&view=rev Log: vote and proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS

svn commit: r907864 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 01:06:01 2010 New Revision: 907864 URL: http://svn.apache.org/viewvc?rev=907864&view=rev Log: Fix parsing bug spotted when reviewing r907538 Allowing #{} expressions to be parsed even when they are disabled breaks ${} expressions if they are intermixed with them.

svn commit: r907862 - /tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 01:02:12 2010 New Revision: 907862 URL: http://svn.apache.org/viewvc?rev=907862&view=rev Log: Additional test from review of r907538 Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java Modified: tomcat/trunk/test/org/apache/jasper/compiler

svn commit: r907860 - /tomcat/trunk/test/webapp/bug48668b.jsp

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 01:01:23 2010 New Revision: 907860 URL: http://svn.apache.org/viewvc?rev=907860&view=rev Log: Additional test from review of r907538 Modified: tomcat/trunk/test/webapp/bug48668b.jsp Modified: tomcat/trunk/test/webapp/bug48668b.jsp URL: http://svn.apache.org

svn commit: r907855 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-08 Thread kkolinko
Author: kkolinko Date: Tue Feb 9 00:18:24 2010 New Revision: 907855 URL: http://svn.apache.org/viewvc?rev=907855&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=907

DO NOT REPLY [Bug 48004] setHeader() does not replace the previous value for a "Server"

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48004 --- Comment #4 from quartz 2010-02-08 14:51:27 UTC --- This fix is imcomplete. There should be a distinction between setting a header to an empty string "" and setting it to null (which should clear the header entirely since there is no .r

buildbot success in ASF Buildbot on tomcat-trunk

2010-02-08 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/80 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 90

DO NOT REPLY [Bug 48694] WebappClassLoader deadlock if web application uses it's own classloader

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 --- Comment #2 from aullr...@blackducksoftware.com 2010-02-08 14:27:08 UTC --- This fix works for us here. It's not checked into trunk yet, though? In our case a well known 3rd party library calls first WebappClassLoader.load(...), catche

DO NOT REPLY [Bug 48170] Unnecessary synchronization by JspFactory.getDefaultFactory contributes to stability problems

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48170 --- Comment #4 from Mark Thomas 2010-02-08 14:24:41 UTC --- Fixed in trunk and proposed for 6.0.x Note as a part of the JSP API, the changes permitted are limited. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?ta

svn commit: r907827 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 22:22:10 2010 New Revision: 907827 URL: http://svn.apache.org/viewvc?rev=907827&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=907

svn commit: r907825 - /tomcat/trunk/java/javax/servlet/jsp/JspFactory.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 22:20:55 2010 New Revision: 907825 URL: http://svn.apache.org/viewvc?rev=907825&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48170 Remove unnecessary syncs that cause issues under heavy load Modified: tomcat/trunk/java/javax/servlet/jsp/J

buildbot success in ASF Buildbot on tomcat-6-trunk

2010-02-08 Thread buildbot
The Buildbot has detected a restored build of tomcat-6-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/47 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/tc6.0

buildbot failure in ASF Buildbot on tomcat-trunk

2010-02-08 Thread buildbot
The Buildbot has detected a new failure of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/79 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 90781

svn commit: r907824 - /tomcat/trunk/java/javax/servlet/jsp/JspFactory.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 22:15:36 2010 New Revision: 907824 URL: http://svn.apache.org/viewvc?rev=907824&view=rev Log: Tab police and line length Modified: tomcat/trunk/java/javax/servlet/jsp/JspFactory.java Modified: tomcat/trunk/java/javax/servlet/jsp/JspFactory.java URL: http://svn

DO NOT REPLY [Bug 48109] Improve binaryStream processing in WebappClassLoader#findResourceInternal

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48109 --- Comment #1 from Mark Thomas 2010-02-08 14:08:51 UTC --- Fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You ar

svn commit: r907821 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 22:08:38 2010 New Revision: 907821 URL: http://svn.apache.org/viewvc?rev=907821&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=907

svn commit: r907819 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 22:07:24 2010 New Revision: 907819 URL: http://svn.apache.org/viewvc?rev=907819&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48109 Extent try catch block (diff is a lot simpler if you ignore whitespace) to ensure InputStream is closed. Modif

svn commit: r907768 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardServer.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 19:29:53 2010 New Revision: 907768 URL: http://svn.apache.org/viewvc?rev=907768&view=rev Log: Log when a valid shutdown command is received. This may help in tracking down "Tomcat just stops" style reports. Modified: tomcat/trunk/java/org/apache/catalina/core/L

DO NOT REPLY [Bug 48694] WebappClassLoader deadlock if web application uses it's own classloader

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 --- Comment #1 from Mark Thomas 2010-02-08 10:28:29 UTC --- I'd like to avoid making WebappClassLoader#loadClass synchronized if at all possible. Could you try this patch instead? Index: java/org/apache/catalina/loader/WebappClassLoader.ja

svn commit: r907727 - /tomcat/trunk/java/org/apache/naming/factory/ResourceLinkFactory.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 17:07:28 2010 New Revision: 907727 URL: http://svn.apache.org/viewvc?rev=907727&view=rev Log: Allow the global naming context to be reset. Useful when running multiple embedded instances in series since it allows each instance to configure its own global naming con

svn commit: r907721 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 16:47:47 2010 New Revision: 907721 URL: http://svn.apache.org/viewvc?rev=907721&view=rev Log: Get logic right way around Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java URL:

svn commit: r907720 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 16:45:08 2010 New Revision: 907720 URL: http://svn.apache.org/viewvc?rev=907720&view=rev Log: Avoid adding the package twice Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 --- Comment #4 from Boris Folgmann 2010-02-08 08:29:26 UTC --- That's really bad because that worked up to 6.0.18. I can't remember any problems with such JSPs since tomcat 4 and 5. What about a compatibility switch to keep all that 3rd pa

svn commit: r907717 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 16:25:13 2010 New Revision: 907717 URL: http://svn.apache.org/viewvc?rev=907717&view=rev Log: Ensure appBase is valid. Prevents spurious stacktraces in tests Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/trunk/test

svn commit: r907713 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 16:13:21 2010 New Revision: 907713 URL: http://svn.apache.org/viewvc?rev=907713&view=rev Log: Make the tesst easier to debug Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/trunk/test/org/apache/catalina/startup/Tomc

DO NOT REPLY [Bug 48689] Jar abstraction for Jasper

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48689 --- Comment #5 from Jarek Gawor 2010-02-08 08:01:38 UTC --- Thanks for the pointers. I am aware of that code but it doesn't really help or address the problem described in this bug. Jasper shouldn't require (as it doesn't really need) a jar

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 Kris Schneider changed: What|Removed |Added Resolution|FIXED |INVALID -- Configure bugmail: ht

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 Kris Schneider changed: What|Removed |Added Resolution|INVALID |FIXED --- Comment #3 from Kris Sc

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 --- Comment #1 from Boris Folgmann 2010-02-08 07:29:50 UTC --- To make it even more clear, this works: But getProperty always fails when the bean is not created with useBean. It's not specific to . Other constructions also fail. -- C

DO NOT REPLY [Bug 48701] New: jsp:getProperty broken for certain cases

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 Summary: jsp:getProperty broken for certain cases Product: Tomcat 6 Version: 6.0.24 Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P2

DO NOT REPLY [Bug 48685] Spnego Support in Tomcat

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685 jfclere changed: What|Removed |Added CC||jfcl...@gmail.com -- Configure bugmail:

svn commit: r907653 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 13:32:08 2010 New Revision: 907653 URL: http://svn.apache.org/viewvc?rev=907653&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=907

svn commit: r907652 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoader.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 13:29:13 2010 New Revision: 907652 URL: http://svn.apache.org/viewvc?rev=907652&view=rev Log: More memory leak protection on reload. Use of java.util.Timer Modified: tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties tomcat/trunk/java/org/a

svn commit: r907651 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 13:27:45 2010 New Revision: 907651 URL: http://svn.apache.org/viewvc?rev=907651&view=rev Log: Protect against NPE whilst running the test Modified: tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java Modified: tomcat/trunk/test/o

Re: SPNEGO/NEGOTIATE implementation for Apache Geronimo

2010-02-08 Thread Ashish Jain
Dear Developers, I have successfully developed a patch which enables spnego authentication in Tomcat. This patch also enables fallback in case Spnego authentication fails. Can you kindly review and provide comments on the attached patch. Here is the link for the bug raised in b'zilla ( https://iss

Re: Tagging Tomcat Native 1.1.20

2010-02-08 Thread jean-frederic clere
On 02/08/2010 08:25 AM, Mladen Turk wrote: > Hi, > > We have a nasty bug that crashes the JVM on shutdown cause > by Library.terminate call while we are inside Socket.accept > > The reason for crash is that we reference later in code the > memory that was already destroyed with apr_pool_terminate

svn commit: r907646 - in /tomcat/trunk/test/org/apache/catalina/loader: ./ TestWebappClassLoaderMemoryLeak.java

2010-02-08 Thread markt
Author: markt Date: Mon Feb 8 12:57:08 2010 New Revision: 907646 URL: http://svn.apache.org/viewvc?rev=907646&view=rev Log: Add a test case for TimerThread thread/memory leaks on reload as I have some ideas on how to safely terminate those threads Added: tomcat/trunk/test/org/apache/catalin

Re: svn commit: r907538 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2010-02-08 Thread Mark Thomas
On 08/02/2010 12:49, Konstantin Kolinko wrote: > 2010/2/8 : >> Author: markt >> Date: Mon Feb 8 02:00:58 2010 >> New Revision: 907538 >> >> URL: http://svn.apache.org/viewvc?rev=907538&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668 >> Don't look for EL matches (w

DO NOT REPLY [Bug 48584] Error or ACCESS_VIOLATION on shutdown

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48584 --- Comment #11 from Mladen Turk 2010-02-08 04:55:03 UTC --- It is caused by calling Library.terminate before all sockets are closed, Checking for tcn_global_pool is safe because it is set to NULL before it is actually destroyed. -- Confi

Re: svn commit: r907538 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2010-02-08 Thread Konstantin Kolinko
2010/2/8 : > Author: markt > Date: Mon Feb  8 02:00:58 2010 > New Revision: 907538 > > URL: http://svn.apache.org/viewvc?rev=907538&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668 > Don't look for EL matches (which swallow the EL match string) if EL is not > enabled

DO NOT REPLY [Bug 48584] Error or ACCESS_VIOLATION on shutdown

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48584 --- Comment #10 from Konstantin Kolinko 2010-02-08 04:46:37 UTC --- I still wonder, what is causing this at the Java side: (see 5. in Comment 8): what is closing those sockets and whether it is possible to wait for termination of those Ac

DO NOT REPLY [Bug 48688] Tomcat apache-tomcat-6.0.24 service fails with jdk-6u18-windows-i586

2010-02-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48688 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[g...@vmgump]: Project tomcat-trunk (in module tomcat-trunk) failed

2010-02-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk has an issue affecting its community integration. This issue

Re: Enable RAW headers by default in IIS Tomcat connector

2010-02-08 Thread Tim Whittington
OK, the most conservative change will be to enable USE_RAW_HEADERS in the makefiles/projects and leave the code untouched - I'll make the change after 1.2.29 is out. cheers tim On Mon, Feb 8, 2010 at 9:03 PM, Rainer Jung wrote: > On 08.02.2010 08:46, Mladen Turk wrote: > >> On 02/08/2010 08:38

Re: Enable RAW headers by default in IIS Tomcat connector

2010-02-08 Thread Rainer Jung
On 08.02.2010 08:46, Mladen Turk wrote: On 02/08/2010 08:38 AM, Tim Whittington wrote: There's a USE_RAW_HEADERS define that will force the use of the raw HTTP headers and avoid this problem, so I'd propose that we make that behaviour the default. I agree with having it default, but is it poss