Re: jk/cluster - intelligent systems load

2010-02-15 Thread Mladen Turk
On 02/16/2010 12:24 AM, Mark Thomas wrote: On 15/02/2010 21:52, Filip Hanik - Dev Lists wrote: why not just a servlet filter? +1. I was going to suggest the same thing. Why not reusing the clustering code for that. It would allow to pre-redirect the requests without doing the actual ping

Re: svn commit: r909979 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread Konstantin Kolinko
2010/2/15 Mark Thomas : > On 14/02/2010 06:47, kkoli...@apache.org wrote: >> +    2. isImplemetedAsFragment() method is wrong. >> +       1) A fragment can also be created with when calling >> a tag, >> +         when the attribute is declared being of type JspFragment. >> +         -see JSP.5.10

svn commit: r910395 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestScriptingVariabler.java webapp/bug48616b.jsp

2010-02-15 Thread kkolinko
Author: kkolinko Date: Tue Feb 16 04:52:38 2010 New Revision: 910395 URL: http://svn.apache.org/viewvc?rev=910395&view=rev Log: Additional test for BZ 48616 Added: tomcat/trunk/test/webapp/bug48616b.jsp (with props) Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestScriptingVar

svn commit: r910394 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread kkolinko
Author: kkolinko Date: Tue Feb 16 04:36:31 2010 New Revision: 910394 URL: http://svn.apache.org/viewvc?rev=910394&view=rev Log: proposals Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #22 from Konstantin Kolinko 2010-02-16 04:14:49 UTC --- Created an attachment (id=24993) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24993) 2010-02-16_tc55_bug42390_bug48616.patch Patch for Tomcat 5.5 -- Confi

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #21 from Konstantin Kolinko 2010-02-16 04:01:29 UTC --- Created an attachment (id=24992) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24992) 2010-02-16_tc6_bug42390_bug48616.patch Patch for Tomcat 6.0 -- Config

Redeclaration of variables by tag handler (BZ 48616, 42390)

2010-02-15 Thread Konstantin Kolinko
I prepared a patch for BZ 48616, 42390 for trunk, see comment 20 in BZ 48616: https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c20 Unless there are complaints, and if it passes TCK, it can be applied. The solution to the issue was a bit unexpected for me, but I think it is for the better

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #20 from Konstantin Kolinko 2010-02-16 03:23:00 UTC --- Created an attachment (id=24991) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24991) 2010-02-16_tc7_bug42390_bug48616.patch Patch for trunk that - reverts r

svn commit: r910373 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread markt
Author: markt Date: Tue Feb 16 00:51:45 2010 New Revision: 910373 URL: http://svn.apache.org/viewvc?rev=910373&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=910373&

DO NOT REPLY [Bug 48742] Can't upload file with mod_jk 1.2.29-dev.

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48742 --- Comment #1 from Eiji Takahashi 2010-02-16 00:49:31 UTC --- This issue reproduced by the simpler way. I used the following. httpd-2.2.3-31.el5.centos.2 mod_jk 1.2.28 and 1.2.29-dev Tomcat 5.5.28 First, appropriately configuring t

DO NOT REPLY [Bug 48498] 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48498 --- Comment #5 from Mark Thomas 2010-02-16 00:48:14 UTC --- As much as it pains me to have to add a workaround in Tomcat for a Java bug you have a fair point that hiding the compilation error is a nasty side-effect. Workaround added to 7.0

svn commit: r910371 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread markt
Author: markt Date: Tue Feb 16 00:46:58 2010 New Revision: 910371 URL: http://svn.apache.org/viewvc?rev=910371&view=rev Log: Proposed Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=910

svn commit: r910370 - in /tomcat/trunk/java/org/apache/jasper: compiler/JavacErrorDetail.java resources/LocalStrings.properties

2010-02-15 Thread markt
Author: markt Date: Tue Feb 16 00:46:07 2010 New Revision: 910370 URL: http://svn.apache.org/viewvc?rev=910370&view=rev Log: Workaround Java 6/7 bug described in https://issues.apache.org/bugzilla/show_bug.cgi?id=48498 Avoid the ArrayIndexOutOfBoundsException Modified: tomcat/trunk/java/org/

DO NOT REPLY [Bug 48569] Not able to replicate Servlet Context Attributes

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48569 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48566] ImplicitTagLibraryInfo - not respecting JSP version from tag file

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48566 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: jk/cluster - intelligent systems load

2010-02-15 Thread Mark Thomas
On 15/02/2010 21:52, Filip Hanik - Dev Lists wrote: > On 02/15/2010 04:38 AM, Henri Gomez wrote: >> 2010/2/12 Mark Thomas: >> >>> On 12/02/2010 15:20, Henri Gomez wrote: >>> Hi to all, Some times ago, we discuss about mod_jk/cluster and more intelligent strategy to be us

Re: [PROPOSAL] Make Lifecycle mandatory rather than optional

2010-02-15 Thread Mark Thomas
On 15/02/2010 14:42, Konstantin Kolinko wrote: Thanks for the feedback. All my comments below are preliminary ideas I have had whilst trying to figure out how best to clean this up. Nothing is absolute at this stage but whichever way I thought of things adding Lifecycle to Container always seemed

Re: jk/cluster - intelligent systems load

2010-02-15 Thread Filip Hanik - Dev Lists
On 02/15/2010 04:38 AM, Henri Gomez wrote: 2010/2/12 Mark Thomas: On 12/02/2010 15:20, Henri Gomez wrote: Hi to all, Some times ago, we discuss about mod_jk/cluster and more intelligent strategy to be use for the dispatching system. One point was to get system load informations abou

Re: [PROPOSAL] Make Lifecycle mandatory rather than optional

2010-02-15 Thread Filip Hanik - Dev Lists
+1 works for me On 02/15/2010 03:23 AM, Mark Thomas wrote: Currently, Lifecycle is an optional interface for components. I'd like to make it mandatory for Server, Service and Container. My reasons for this are: 1. Much of the current implementation depends on Lifecycle (e.g. JNDI, configuration

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-15 Thread Jim Jagielski
Give me 24hrs... I'll be able to test tomorrow AM. On Feb 15, 2010, at 1:54 PM, Mladen Turk wrote: > On 02/10/2010 11:19 AM, Mladen Turk wrote: >> Hi, >> > > Ping. Anyone? > > > Regards > -- > ^TM > > - > To unsubscribe, e-

Re: [VOTE] Release Apache Tomcat Native 1.1.20

2010-02-15 Thread Mladen Turk
On 02/10/2010 11:19 AM, Mladen Turk wrote: Hi, Ping. Anyone? Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48498] 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48498 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|I

DO NOT REPLY [Bug 48565] Stack trace when tomcat service is down

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48565 --- Comment #3 from oscar 2010-02-15 17:36:25 UTC --- Hi, In tomcat 5.5 when a member goes down the other node just inform it but it did not raise a java stack trace. I think would be better to display a simple message instead of an ugly

DO NOT REPLY [Bug 48565] Stack trace when tomcat service is down

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48565 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48545] truststorePass used in JSSESocketFactory should be optional (nillable)

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48545 --- Comment #1 from Mark Thomas 2010-02-15 17:17:34 UTC --- Thanks for the patch. It has been applied to 7.0.x and proposed for 6.0.x For future reference, please provide patches in diff -u format as they are easier to work with. Also, pat

svn commit: r910268 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread markt
Author: markt Date: Mon Feb 15 17:16:28 2010 New Revision: 910268 URL: http://svn.apache.org/viewvc?rev=910268&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=910

svn commit: r910266 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java webapps/docs/config/http.xml

2010-02-15 Thread markt
Author: markt Date: Mon Feb 15 17:14:27 2010 New Revision: 910266 URL: http://svn.apache.org/viewvc?rev=910266&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48545 Truststores don't have to have passwords Based on a patch by 'smmwpf54' Modified: tomcat/trunk/java/org/apa

DO NOT REPLY [Bug 48701] jsp:getProperty broken for certain cases

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48701 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|I

DO NOT REPLY [Bug 48498] 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48498 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [PROPOSAL] Make Lifecycle mandatory rather than optional

2010-02-15 Thread Konstantin Kolinko
2010/2/15 Mark Thomas : > Currently, Lifecycle is an optional interface for components. I'd like > to make it mandatory for Server, Service and Container. +1, Let's make it mandatory. I agree with 1.,2.,3. of your reasons. Cannot comment on 4. as I do not know that subject. Is there any outline

DO NOT REPLY [Bug 48685] Spnego Support in Tomcat

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685 --- Comment #4 from ashish.j...@in.ibm.com 2010-02-15 12:01:18 UTC --- Created an attachment (id=24987) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24987) Updated patch for Spnego support in tomcat Kindly review and apply. -

DO NOT REPLY [Bug 48685] Spnego Support in Tomcat

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48685 --- Comment #3 from ashish.j...@in.ibm.com 2010-02-15 11:59:00 UTC --- My sincere apologies that patch did not make the standard of tomcat community. I have reformatted the patch and uploading a new one. To use this the only requirement is

Re: jk/cluster - intelligent systems load

2010-02-15 Thread Henri Gomez
2010/2/12 Mark Thomas : > On 12/02/2010 15:20, Henri Gomez wrote: >> Hi to all, >> >> Some times ago, we discuss about mod_jk/cluster and more intelligent >> strategy to be use for the dispatching system. >> >> One point was to get system load informations about the various Tomcat >> instances invo

DO NOT REPLY [Bug 48743] Make the SLEEP variable in catalina.sh settable from the environment.

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48743 --- Comment #1 from Mark Thomas 2010-02-15 11:08:19 UTC --- The default could be made an environment variable rather than hard coding to 5 (simple patch) but this is already configurable. Use: ./catalina.sh stop n to have Tomcat wait n sec

[PROPOSAL] Make Lifecycle mandatory rather than optional

2010-02-15 Thread Mark Thomas
Currently, Lifecycle is an optional interface for components. I'd like to make it mandatory for Server, Service and Container. My reasons for this are: 1. Much of the current implementation depends on Lifecycle (e.g. JNDI, configuration) and breaks if the component doesn't implement Lifecycle 2.

Re: svn commit: r909979 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-02-15 Thread Mark Thomas
On 14/02/2010 06:47, kkoli...@apache.org wrote: > +1. There is a copy-paste issue in the patch: > + vec.add(tagVarInfos[i]); call was replaced by vec.add(varInfos[i]); > + which is wrong. This error is not present in trunk. Fixed. > +2. isImplemetedAsFragment() method is wrong.

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #19 from agharta 2010-02-15 08:25:25 UTC --- (In reply to comment #18) > The fix/workaround mentioned in this ticket does not work. My last reply was > replying to the comment before that doing checks would be a nightmare (to m

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #18 from DSEyers 2010-02-15 08:17:07 UTC --- The fix/workaround mentioned in this ticket does not work. My last reply was replying to the comment before that doing checks would be a nightmare (to many code changes/testing) and

svn commit: r910172 - /tomcat/trunk/build.properties.default

2010-02-15 Thread markt
Author: markt Date: Mon Feb 15 08:09:39 2010 New Revision: 910172 URL: http://svn.apache.org/viewvc?rev=910172&view=rev Log: Spacing Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.propertie

svn commit: r910171 - /tomcat/trunk/build.properties.default

2010-02-15 Thread markt
Author: markt Date: Mon Feb 15 08:09:05 2010 New Revision: 910171 URL: http://svn.apache.org/viewvc?rev=910171&view=rev Log: Update to dbcp 1.4 release that supports JDBC4 and compiles on Java 6 Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default U

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #17 from agharta 2010-02-15 08:03:57 UTC --- (In reply to comment #15) > Reviewing the fix to this issue, > I cannot find any provision in the JSP specification to support the requested > behaviour. > > The question is, when we