Re: svn commit: r933881 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2010-04-14 Thread Keiichi Fujino
2010/4/14 Mladen Turk : > On 04/14/2010 10:48 AM, kfuj...@apache.org wrote: >> >> Author: kfujino >> >> Modified: >>     tomcat/trunk/java/org/apache/catalina/session/StandardManager.java >> >> +                        session.expire(); >> +                    } >>                      sessionCount

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 15/04/2010 01:31, sebb wrote: On 14/04/2010, Mark Thomas wrote: On 14/04/2010 21:06, sebb wrote: ... > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > Copyright 19...@year@ I'll take a look. Same problem in extras/tomcat-juli-adapters.jar This is ex

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 15/04/2010 01:44, Ivan wrote: Hi, Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last time I check it, it seems that ServletContainerInitializer has not been implemented yet. Thanks ! Yep. That looks like a (fairly large) oversight. I'll go back through the spec and s

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 15/04/2010, Ivan wrote: > Usually, I trust the real codes more :-) > Just grep the Tomcat trunk codes with 'ServletContainerInitializer', I only > found an empty if block in AnnotationProcessor.java file. In that case maybe you have found a discrepancy between the release notes and the code

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Ivan
Usually, I trust the real codes more :-) Just grep the Tomcat trunk codes with 'ServletContainerInitializer', I only found an empty if block in AnnotationProcessor.java file. 2010/4/15 sebb > The RELEASE-NOTES file says: > > > = > Bundled APIs: > = > A standard installat

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
The RELEASE-NOTES file says: = Bundled APIs: = A standard installation of Tomcat 7.0 makes all of the following APIs available for use by web applications (by placing them in "lib"): * servlet-api.jar (Servlet 3.0 API) On 15/04/2010, Ivan wrote: > Hi, >Just wonder

DO NOT REPLY [Bug 49130] New: NSIS - clarify that service is always installed

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49130 Summary: NSIS - clarify that service is always installed Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Ivan
Hi, Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last time I check it, it seems that ServletContainerInitializer has not been implemented yet. Thanks ! 2010/4/15 sebb > On 14/04/2010, Mark Thomas wrote: > > On 14/04/2010 21:06, sebb wrote: > > ... > > > > There is a mino

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: ... > > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > > Copyright 19...@year@ > > I'll take a look. > Same problem in extras/tomcat-juli-adapters.jar

DO NOT REPLY [Bug 49122] Update of ROOT application index.html

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 --- Comment #2 from Mark Thomas 2010-04-14 19:34:37 EDT --- I like the addition of the announce list but the larger test feels a little 'in your face'. Could you reduce the font size for the blod bits to be closer to the previous version?

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread William A. Rowe Jr.
On 4/14/2010 5:32 PM, sebb wrote: > On 14/04/2010, William A. Rowe Jr. wrote: >> On 4/14/2010 4:22 PM, sebb wrote: >> > >> > Also, SVN is considered by some to be publishing code (e.g. links are >> > usually published on the web-site) so better safe than sorry. >> >> >> SVN is a development/wor

DO NOT REPLY [Bug 49024] Enhance RemoteIpFilter docs

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49024 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934239 - /tomcat/trunk/webapps/docs/config/filter.xml

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 23:17:26 2010 New Revision: 934239 URL: http://svn.apache.org/viewvc?rev=934239&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49024 Enhance the RemoteIpFilter docs Patch provided by Cyrille Le Clerc Modified: tomcat/trunk/webapps/docs/conf

DO NOT REPLY [Bug 49129] DigestAuthenticator.md5Helper - possible incorrect lazy initialisation

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934238 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 23:13:45 2010 New Revision: 934238 URL: http://svn.apache.org/viewvc?rev=934238&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified: tomcat/t

DO NOT REPLY [Bug 49127] SimpleTcpReplicationManager.startInternal() ignores Exception

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49127 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal

DO NOT REPLY [Bug 49129] New: DigestAuthenticator.md5Helper - possible incorrect lazy initialisation

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Summary: DigestAuthenticator.md5Helper - possible incorrect lazy initialisation Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: N

DO NOT REPLY [Bug 49128] loader.WebappClassLoader.start() ignores Exception

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49128 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal

DO NOT REPLY [Bug 49128] New: loader.WebappClassLoader.start() ignores Exception

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49128 Summary: loader.WebappClassLoader.start() ignores Exception Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal

DO NOT REPLY [Bug 49126] jasper.compiler.Generator.createJspId() can generate negative number

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49126 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal

DO NOT REPLY [Bug 49127] New: SimpleTcpReplicationManager.startInternal() ignores Exception

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49127 Summary: SimpleTcpReplicationManager.startInternal() ignores Exception Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 49125] toString on byte[] array probably is not correct

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49125 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal

DO NOT REPLY [Bug 49126] New: jasper.compiler.Generator.createJspId() can generate negative number

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49126 Summary: jasper.compiler.Generator.createJspId() can generate negative number Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 49124] util.http.FastHttpDateFormat odd synchronisation

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49124 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49125] New: toString on byte[] array probably is not correct

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49125 Summary: toString on byte[] array probably is not correct Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Pr

DO NOT REPLY [Bug 49124] New: util.http.FastHttpDateFormat odd synchronisation

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49124 Summary: util.http.FastHttpDateFormat odd synchronisation Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Pr

DO NOT REPLY [Bug 49118] Inefficient use of String concatenation in loop

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934234 - /tomcat/trunk/java/javax/servlet/http/HttpServlet.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:50:35 2010 New Revision: 934234 URL: http://svn.apache.org/viewvc?rev=934234&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Use StringBuilder rather than concatenation Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java Mo

DO NOT REPLY [Bug 49110] runtime.JspFactoryImpl$PageContextPool needs to be static

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49110 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934233 - /tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:47:57 2010 New Revision: 934233 URL: http://svn.apache.org/viewvc?rev=934233&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49110 Make inner class static to prevent possible memory leak - found by FindBugs Modified: tomcat/trunk/java/org

DO NOT REPLY [Bug 49109] RealmBase.authenticate uses toString on byte array

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49109 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934232 - in /tomcat/trunk/java/org/apache/catalina: Realm.java realm/CombinedRealm.java realm/LockOutRealm.java realm/RealmBase.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:43:37 2010 New Revision: 934232 URL: http://svn.apache.org/viewvc?rev=934232&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49109 Remove unused authenticate() method with a broken default impl Modified: tomcat/trunk/java/org/apache/catal

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, William A. Rowe Jr. wrote: > On 4/14/2010 4:22 PM, sebb wrote: > > > > Also, SVN is considered by some to be publishing code (e.g. links are > > usually published on the web-site) so better safe than sorry. > > > SVN is a development/work product area. Although now we have dist.

DO NOT REPLY [Bug 49108] Eliminate double-check of same value and fix fallthrough warning

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49108 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49107] Document fallthrough, Eclipse-fashion

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49107 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49106] Unused imports

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49106 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934225 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:29:34 2010 New Revision: 934225 URL: http://svn.apache.org/viewvc?rev=934225&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49106 Remove unused import Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Modified: tomcat/tru

DO NOT REPLY [Bug 49105] Javadoc corrections

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49105 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934224 - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalin

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:27:59 2010 New Revision: 934224 URL: http://svn.apache.org/viewvc?rev=934224&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49105 Misc Javadoc corrections. Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java tomcat/trunk/java

DO NOT REPLY [Bug 49104] Fix up some raw types

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49104 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934223 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpProtocol.java coyote/http11/Http11Protocol.java tomcat/util/net/JIoEndpoint.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:24:17 2010 New Revision: 934223 URL: http://svn.apache.org/viewvc?rev=934223&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49104 Generics Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java tomcat/trunk/java/org/apach

DO NOT REPLY [Bug 49103] Missing annotations

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49103 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r934222 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11NioProtocol.java coyote/http11/Http11Protocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/NioEndpoint.java tomcat/

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:19:33 2010 New Revision: 934222 URL: http://svn.apache.org/viewvc?rev=934222&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49103 Add @Override where appropriate Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

DO NOT REPLY [Bug 49102] coyote.ajp.Constants - 3 "constant" arrays are mutable

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal

DO NOT REPLY [Bug 49101] All constants in tribes.transport.Constants are mutable

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49101 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark

svn commit: r934219 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: EnclosingMethod.java LocalVariableTypeTable.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 22:10:35 2010 New Revision: 934219 URL: http://svn.apache.org/viewvc?rev=934219&view=rev Log: CPL allows us to elect to distribute under a later version of the license so elect to distribute under EPL as we are already using EPL for Eclipse JDT. Modified: tomca

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread William A. Rowe Jr.
On 4/14/2010 4:22 PM, sebb wrote: > > Also, SVN is considered by some to be publishing code (e.g. links are > usually published on the web-site) so better safe than sorry. SVN is a development/work product area. Although now we have dist.apache.org/ which is, pretty clearly, a dist'ribution poin

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 21:31, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: >> 2 files in BCEL have IBM headers; these headers are presumably OK, but >> the NOTICE file probably needs to mention IBM. Not sure why the BCEL >> source archive does not do so in its NOTICE file. That might be an >> error

svn commit: r934207 - /tomcat/trunk/build.xml

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 21:40:13 2010 New Revision: 934207 URL: http://svn.apache.org/viewvc?rev=934207&view=rev Log: Don't include modules in the src release Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?re

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 22:22, sebb wrote: > On 14/04/2010, Mark Thomas wrote: >> On 14/04/2010 21:06, sebb wrote: >> > Many of the java and xml files in tomcat-lite don't have AL headers. >> >> Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) > > It's currently in the source arc

svn commit: r934203 - in /tomcat/trunk: build.xml res/META-INF/jasper-jdt.jar.notice res/META-INF/jsp-api.jar.notice res/META-INF/servlet-api.jar.notice

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 21:25:20 2010 New Revision: 934203 URL: http://svn.apache.org/viewvc?rev=934203&view=rev Log: Parametrise current year in all embedded NOTICE files Don't use the same property name for different output files Modified: tomcat/trunk/build.xml tomcat/trunk/res/

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: > > Many of the java and xml files in tomcat-lite don't have AL headers. > > Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) It's currently in the source archives. Also, SVN is considered by some to

svn commit: r934192 - in /tomcat/trunk/res: config.ini jvm.ini

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 20:51:19 2010 New Revision: 934192 URL: http://svn.apache.org/viewvc?rev=934192&view=rev Log: Add license headers to NSIS files Modified: tomcat/trunk/res/config.ini tomcat/trunk/res/jvm.ini Modified: tomcat/trunk/res/config.ini URL: http://svn.apache.org/

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 21:06, sebb wrote: > Many of the java and xml files in tomcat-lite don't have AL headers. Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) > The following other files don't have AL headers: > > res/config.ini > res/jvm.ini > test/org/apache/coyote/http11/Te

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Filip Hanik - Dev Lists
On 04/14/2010 01:58 PM, Rainer Jung wrote: On 14.04.2010 20:52, Mladen Turk wrote: On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive!

svn commit: r934173 - in /tomcat/trunk/test/org/apache: coyote/http11/TestInternalInputBuffer.java naming/resources/TestBaseDirContext.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 20:18:14 2010 New Revision: 934173 URL: http://svn.apache.org/viewvc?rev=934173&view=rev Log: AL2 header Modified: tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java

svn commit: r934170 - /tomcat/trunk/res/jvm.ini

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 20:11:59 2010 New Revision: 934170 URL: http://svn.apache.org/viewvc?rev=934170&view=rev Log: Tomcat 7 needs Java 6 Modified: tomcat/trunk/res/jvm.ini Modified: tomcat/trunk/res/jvm.ini URL: http://svn.apache.org/viewvc/tomcat/trunk/res/jvm.ini?rev=934170&r1=9

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready for t

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Rainer Jung
On 14.04.2010 20:52, Mladen Turk wrote: On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! 8 core i7 does the remaining :) Naaa, s

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Harry Metske
INFO: Starting Servlet Engine: Apache Tomcat/7.0.0-RC1 Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive webtest.war Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application director

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mladen Turk
On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! 8 core i7 does the remaining :) Cheers -- ^TM -

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Rainer Jung
On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! Cheers, Rainer - To unsubscribe,

DO NOT REPLY [Bug 49100] Mutable public constants: MemberImpl.TRIBES_MBR_BEGIN/END

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49100 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark

svn commit: r934067 - /tomcat/trunk/RELEASE-NOTES

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 18:00:34 2010 New Revision: 934067 URL: http://svn.apache.org/viewvc?rev=934067&view=rev Log: Add info on API stability to the release. Modified: tomcat/trunk/RELEASE-NOTES Modified: tomcat/trunk/RELEASE-NOTES URL: http://svn.apache.org/viewvc/tomcat/trunk/REL

setRequest method on HttpServletRequestWrapper

2010-04-14 Thread Unmesh Joshi
Hi, I was going through tomcat source code. (Specifically ApplicationDispatcher.java). The way HttpServletRequestWrapper is used there, puzzled me. What is the intent of all the methods of HttpServletRequestWrapper class in servlet api? Specifically HttpServletRequestWrapper's setRequest method lo

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 11:34, Mark Thomas wrote: > The 7.0.0-RC1 tag is > [ ] Broken - do not release > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > [ ] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > >

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread jean-frederic clere
On 04/14/2010 04:13 PM, Mladen Turk wrote: > On 04/14/2010 03:35 PM, jean-frederic clere wrote: >> On 04/14/2010 12:34 PM, Mark Thomas wrote: >> >> The APR gives some errors for example Address already in use:8080 >> on my Linux box. All other test/plaforms look ok. >> > > Seems you have a broken

DO NOT REPLY [Bug 49082] ExpressionFactory.newInstance needs to be privileged

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r933972 - /tomcat/trunk/java/javax/el/ExpressionFactory.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 14:46:07 2010 New Revision: 933972 URL: http://svn.apache.org/viewvc?rev=933972&view=rev Log: Fully fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java Modified: tomcat/trunk/java/javax/el/Exp

DO NOT REPLY [Bug 49082] ExpressionFactory.newInstance needs to be privileged

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 Robert Goff changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread jean-frederic clere
On 04/14/2010 03:50 PM, Mark Thomas wrote: > On 14/04/2010 14:35, jean-frederic clere wrote: >> On 04/14/2010 12:34 PM, Mark Thomas wrote: > >>> The 7.0.0-RC1 tag is >>> [ ] Broken - do not release >>> [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 >>> [X] Beta - go ahead and

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mladen Turk
On 04/14/2010 03:35 PM, jean-frederic clere wrote: On 04/14/2010 12:34 PM, Mark Thomas wrote: The APR gives some errors for example Address already in use:8080 on my Linux box. All other test/plaforms look ok. Seems you have a broken linux box :) Here is mine dump on RHEL-5 Apr 14, 2010 4:0

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, Mladen Turk wrote: > On 04/14/2010 12:34 PM, Mark Thomas wrote: > > > > > The 7.0.0-RC1 tag is > > [ ] Broken - do not release > > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > > [X] Stable - g

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 14:35, jean-frederic clere wrote: > On 04/14/2010 12:34 PM, Mark Thomas wrote: >> The 7.0.0-RC1 tag is >> [ ] Broken - do not release >> [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 >> [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > > The APR g

DO NOT REPLY [Bug 49122] Update of ROOT application index.html

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 --- Comment #1 from Pid 2010-04-14 09:41:54 EDT --- Created an attachment (id=25295) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25295) Modified ROOT app index.html -- Configure bugmail: https://issues.apache.org/bugzilla/u

DO NOT REPLY [Bug 49122] New: Update of ROOT application index.html

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 Summary: Update of ROOT application index.html Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread jean-frederic clere
On 04/14/2010 12:34 PM, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready

Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread Filip Hanik - Dev Lists
On 04/14/2010 07:07 AM, Konstantin Kolinko wrote: 2010/4/13 Filip Hanik - Dev Lists: This makes zero sense and I would do a -1 on this commit and the bug in general. What effectively has happened here is that there has been a public API change without any justification. Since this is a muta

Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread Konstantin Kolinko
2010/4/13 Filip Hanik - Dev Lists : > This makes zero sense and I would do a -1 on this commit and the bug in > general. > What effectively has happened here is that there has been a public API > change without any justification. > > Since this is a mutable field, you've now made it non mutable. an

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mladen Turk
On 04/14/2010 12:34 PM, Mark Thomas wrote: The 7.0.0-RC1 tag is [ ] Broken - do not release [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 [X] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 Teste

DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r933921 - in /tomcat/trunk/java/org/apache/catalina/mbeans: MBeanFactory.java mbeans-descriptors.xml

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 12:07:04 2010 New Revision: 933921 URL: http://svn.apache.org/viewvc?rev=933921&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 Add support for adding Services and Engines via JMX Based on a patch by Chamith Buddhika Modified: tomcat/t

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
On 14/04/2010 12:02, sebb wrote: > On 14/04/2010, Mark Thomas wrote: >> Please test this release candidate and provide feedback. > > Some bugs reported against Tomcat 7 may require API changes to fix. > Are API changes going to be possible once the RC has been released? Yes. I still have some L

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread sebb
On 14/04/2010, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready for t

Re: Need help in setting up virtual url for tomcat 5

2010-04-14 Thread Xie Xiaodong
us...@tomcat.apache.org On Wed, Apr 14, 2010 at 12:42 PM, Vivek Kanchan wrote: > please give me the id.. > thanks > > > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, April 14, 2010 4:02 PM > To: Tomcat Developers List > Subject: Re: Need help in sett

Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread sebb
On 14/04/2010, Mark Thomas wrote: > On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote: > > This makes zero sense and I would do a -1 on this commit and the bug in > > general. > > What effectively has happened here is that there has been a public API > > change without any justification. > >

RE: Need help in setting up virtual url for tomcat 5

2010-04-14 Thread Vivek Kanchan
please give me the id.. thanks -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Wednesday, April 14, 2010 4:02 PM To: Tomcat Developers List Subject: Re: Need help in setting up virtual url for tomcat 5 On 14/04/2010 11:29, Vivek Kanchan wrote: > HI, > > I have set

[VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1

2010-04-14 Thread Mark Thomas
All, After the experience of the recent 6.0.x releases, I wanted to try an alternative approach and use explicit release candidates for 7.0.x. I'm expecting to tweak the release process as we go. The first Tomcat 7 release candiate is ready for testing. 7.0.0-RC1 can be obtained from: http://peop

Re: Need help in setting up virtual url for tomcat 5

2010-04-14 Thread Mark Thomas
On 14/04/2010 11:29, Vivek Kanchan wrote: > HI, > > I have setup tomcat 5 for a customer, now i need to use virtual url and por= > t > t other than 8080 , please let me know how to do it , what files to change = > for these. Please use the Tomcat users mailing list. Mark

Need help in setting up virtual url for tomcat 5

2010-04-14 Thread Vivek Kanchan
HI, I have setup tomcat 5 for a customer, now i need to use virtual url and por= t t other than 8080 , please let me know how to do it , what files to change = for these. Thanks, Vivyek kanchan - To unsubscribe, e-mail: dev-uns

DO NOT REPLY [Bug 49120] gc new capacity of JVM is gradually reducing when webapp(tomcat) started

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49120 Pid changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49120] New: gc new capacity of JVM is gradually reducing when webapp(tomcat) started

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49120 Summary: gc new capacity of JVM is gradually reducing when webapp(tomcat) started Product: Tomcat 5 Version: 5.5.13 Platform: Sun OS/Version: Linux Status: NE

svn commit: r933907 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread markt
Author: markt Date: Wed Apr 14 10:14:34 2010 New Revision: 933907 URL: http://svn.apache.org/viewvc?rev=933907&view=rev Log: Alternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49089 Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Modified: tomc

Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java

2010-04-14 Thread Mark Thomas
On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote: > This makes zero sense and I would do a -1 on this commit and the bug in > general. > What effectively has happened here is that there has been a public API > change without any justification. > > Since this is a mutable field, you've now made i

DO NOT REPLY [Bug 49118] New: Inefficient use of String concatenation in loop

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Summary: Inefficient use of String concatenation in loop Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Pri

Re: svn commit: r933881 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java

2010-04-14 Thread Mladen Turk
On 04/14/2010 10:48 AM, kfuj...@apache.org wrote: Author: kfujino Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java +session.expire(); +} sessionCounter++; Seems we are using the sessionCounter a

DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 Ruediger Pluem changed: What|Removed |Added Attachment #25291|Patch against Tomcat trunk |Patch against Tomcat 6.0 d

DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #5 from Ruediger Pluem 2010-04-14 05:15:01 EDT --- Created an attachment (id=25292) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25292) Patch against Tomcat trunk -- Configure bugmail: https://issues.apache.org/

DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #4 from Ruediger Pluem 2010-04-14 05:14:34 EDT --- Created an attachment (id=25291) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25291) Patch against Tomcat trunk -- Configure bugmail: https://issues.apache.org/

DO NOT REPLY [Bug 49116] Memory leak by HttpSession.

2010-04-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49116 --- Comment #2 from Keiichi Fujino 2010-04-14 04:57:53 EDT --- Fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- Y

  1   2   >