svn:eol-style info for our new committers

2010-12-06 Thread Rainer Jung
There's the useful http://www.apache.org/dev/svn-eol-style.txt to configure svn. It is linked together with other useful info in the version control section of http://www.apache.org/dev/ Regards, Rainer - To

Re: Automated FindBugs Reportg

2010-12-06 Thread Henri Gomez
I got some news. Adding Tomcat 5.5 / 7.x to nemo will require some study, since projects will require some works (build.xml/build.properties). It's usually faster for Mavenised projects but sadly Tomcat is still ant based :( 2010/12/6 Henri Gomez henri.go...@gmail.com I'll ask them :-) Le 5

svn commit: r1042639 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 13:36:48 2010 New Revision: 1042639 URL: http://svn.apache.org/viewvc?rev=1042639view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Implement a common base class for ProtocolHandler implementations that will handle

svn commit: r1042648 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 14:02:19 2010 New Revision: 1042648 URL: http://svn.apache.org/viewvc?rev=1042648view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Start to pull stuff up into the base class Modified:

svn commit: r1042651 - /tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 14:09:14 2010 New Revision: 1042651 URL: http://svn.apache.org/viewvc?rev=1042651view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Modified:

DO NOT REPLY [Bug 50326] Problem with DBCP 1.3 /jdk 6 and oracle spatial

2010-12-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50326 Nils Hildebrand nils.hildebr...@bamf.bund.de changed: What|Removed |Added Status|RESOLVED

svn commit: r1042670 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 15:01:34 2010 New Revision: 1042670 URL: http://svn.apache.org/viewvc?rev=1042670view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Start to pull more getters/setters and the generic attribute handling. Note that the

svn commit: r1042681 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 15:43:52 2010 New Revision: 1042681 URL: http://svn.apache.org/viewvc?rev=1042681view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up more getters/setters. Modified:

svn commit: r1042696 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpAprProtocol.java AjpProtocol.java Constants.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 16:04:33 2010 New Revision: 1042696 URL: http://svn.apache.org/viewvc?rev=1042696view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java

svn commit: r1042706 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/http11/ webapps/docs/config/

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 16:26:17 2010 New Revision: 1042706 URL: http://svn.apache.org/viewvc?rev=1042706view=rev Log: Fix mix-up of connectionUploadTimeout and connectionTimeout Use connectionUploadTimeout consistently as attribute name Document connectionUploadTimeout Modified:

svn commit: r1042708 - in /tomcat/trunk: ./ conf/ webapps/

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 16:29:25 2010 New Revision: 1042708 URL: http://svn.apache.org/viewvc?rev=1042708view=rev Log: Revert svn-ignore property changes made in r1042482 Modified: tomcat/trunk/ (props changed) tomcat/trunk/conf/ (props changed) tomcat/trunk/webapps/

svn commit: r1042713 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 16:37:16 2010 New Revision: 1042713 URL: http://svn.apache.org/viewvc?rev=1042713view=rev Log: Fix another mix-up of connectionUploadTimeout and connectionTimeout Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Modified:

svn commit: r1042716 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocolHandler.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 16:41:06 2010 New Revision: 1042716 URL: http://svn.apache.org/viewvc?rev=1042716view=rev Log: Since the address is exposed to sub-components, expose the port as well. Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocolHandler.java Modified:

Re: svn commit: r1042713 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java

2010-12-06 Thread sebb
On 6 December 2010 16:37, ma...@apache.org wrote: Author: markt Date: Mon Dec  6 16:37:16 2010 New Revision: 1042713 URL: http://svn.apache.org/viewvc?rev=1042713view=rev Log: Fix another mix-up of connectionUploadTimeout and connectionTimeout Modified:    

svn commit: r1042726 - in /tomcat/trunk/java/org/apache: coyote/AbstractProtocolHandler.java coyote/ajp/AbstractAjpProtocol.java coyote/ajp/AjpProtocol.java coyote/http11/AbstractHttp11Protocol.java t

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 17:16:53 2010 New Revision: 1042726 URL: http://svn.apache.org/viewvc?rev=1042726view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up timeout getters/setters. Use -1 consistently for the default value of

Re: svn commit: r1042495 - /tomcat/trunk/webapps/docs/changelog.xml

2010-12-06 Thread Sylvain Laurent
Are you using an automatic formatter ? if yes, which one ? Can you share its settings? On 6 déc. 2010, at 01:17, ma...@apache.org wrote: Author: markt Date: Mon Dec 6 00:17:43 2010 New Revision: 1042495 URL: http://svn.apache.org/viewvc?rev=1042495view=rev Log: Line-length Modified:

svn commit: r1042761 - /tomcat/trunk/build.xml

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 19:20:57 2010 New Revision: 1042761 URL: http://svn.apache.org/viewvc?rev=1042761view=rev Log: Get the tests running again on the command line Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: svn:eol-style info for our new committers

2010-12-06 Thread Sylvain Laurent
Thanks, and sorry for the incorrect svn properties and formatting. I'll try to compile a list of things to take care of for new committers and put it into the wiki. On 6 déc. 2010, at 12:00, Rainer Jung wrote: There's the useful http://www.apache.org/dev/svn-eol-style.txt to configure

Re: svn commit: r1042495 - /tomcat/trunk/webapps/docs/changelog.xml

2010-12-06 Thread Mark Thomas
On 06/12/2010 06:28, Sylvain Laurent wrote: Are you using an automatic formatter ? Nope. if yes, which one ? Can you share its settings? Although if I need one I tend to use Eclipse defaults but with spaces rather than tabs. Mark On 6 déc. 2010, at 01:17, ma...@apache.org wrote:

svn commit: r1042775 - /tomcat/trunk/webapps/docs/config/http.xml

2010-12-06 Thread kkolinko
Author: kkolinko Date: Mon Dec 6 20:19:03 2010 New Revision: 1042775 URL: http://svn.apache.org/viewvc?rev=1042775view=rev Log: Correct a typo Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL:

svn commit: r1042783 - in /tomcat/tc6.0.x/trunk/webapps/docs: changelog.xml logging.xml

2010-12-06 Thread kkolinko
Author: kkolinko Date: Mon Dec 6 20:38:26 2010 New Revision: 1042783 URL: http://svn.apache.org/viewvc?rev=1042783view=rev Log: Port logging documentation updates from TC7. (Actually, just a copy: there is nothing TC7 specific there yet). This includes rewritten introductory section,

svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/

2010-12-06 Thread slaurent
Author: slaurent Date: Mon Dec 6 20:49:14 2010 New Revision: 1042786 URL: http://svn.apache.org/viewvc?rev=1042786view=rev Log: bug 49159: Improve ThreadLocal memory leak clean-up https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 Various fixes after review by markt : formatting, use

Re: svn commit: r1042482 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/tomcat/util/threads/ res/confinstall/ webapps/ webapps/docs/ webap

2010-12-06 Thread Sylvain Laurent
I fixed most of your points except one, see below. On 6 déc. 2010, at 01:09, Mark Thomas wrote: On 05/12/2010 22:54, slaur...@apache.org wrote: Author: slaurent Date: Sun Dec 5 22:54:05 2010 New Revision: 1042482 URL: http://svn.apache.org/viewvc?rev=1042482view=rev General comments:

Re: svn commit: r1042482 - in /tomcat/trunk: ./ conf/ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/tomcat/util/threads/ res/confinstall/ webapps/ webapps/docs/ webap

2010-12-06 Thread Mark Thomas
On 06/12/2010 21:01, Sylvain Laurent wrote: I fixed most of your points except one, see below. +protected void processContainerRemoveChild(Container parent, Container child) { + +if (log.isDebugEnabled()) +log.debug(Process removeChild[parent= + parent + ,child= +

Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/

2010-12-06 Thread Mark Thomas
On 06/12/2010 20:49, slaur...@apache.org wrote: Author: slaurent Date: Mon Dec 6 20:49:14 2010 New Revision: 1042786 URL: http://svn.apache.org/viewvc?rev=1042786view=rev @@ -63,7 +72,7 @@ public class ThreadLocalLeakPreventionLi try { Lifecycle lifecycle =

svn commit: r1042798 - in /tomcat/trunk/java/org/apache/catalina: LifecycleException.java connector/Connector.java connector/LocalStrings.properties

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 21:25:07 2010 New Revision: 1042798 URL: http://svn.apache.org/viewvc?rev=1042798view=rev Log: Include root cause in LifecycleException stack traces Modified: tomcat/trunk/java/org/apache/catalina/LifecycleException.java

svn commit: r1042814 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java ajp/AbstractAjpProtocol.java http11/AbstractHttp11JsseProtocol.java http11/AbstractHttp11Protocol.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 22:06:52 2010 New Revision: 1042814 URL: http://svn.apache.org/viewvc?rev=1042814view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up JMX related methods Tidy up the remaining protocol specific methods Modified:

svn commit: r1042815 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-12-06 Thread kkolinko
Author: kkolinko Date: Mon Dec 6 22:14:06 2010 New Revision: 1042815 URL: http://svn.apache.org/viewvc?rev=1042815view=rev Log: Proposal for bug 50201 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1042816 - /tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 22:19:35 2010 New Revision: 1042816 URL: http://svn.apache.org/viewvc?rev=1042816view=rev Log: Fix auto-completion snafu Modified: tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java Modified:

svn commit: r1042850 - in /tomcat/trunk/java/org/apache: coyote/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2010-12-06 Thread markt
Author: markt Date: Mon Dec 6 23:22:44 2010 New Revision: 1042850 URL: http://svn.apache.org/viewvc?rev=1042850view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Add the necessary plumbing for the AbstractProtocolHandler to perform the JMX

svn commit: r1042873 - in /tomcat/trunk/java/org/apache: coyote/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2010-12-06 Thread markt
Author: markt Date: Tue Dec 7 00:08:38 2010 New Revision: 1042873 URL: http://svn.apache.org/viewvc?rev=1042873view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up the concrete destroy() method - required a fair bit of refactoring Pull up the