DO NOT REPLY [Bug 51656] NullPointerException in host-manager application (in javax.servlet.GenericServlet.getServletContext during logging)

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51656 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51654] NullPointerException in startup (org.apache.catalina.startup.HostConfig.filterAppPaths) due to missing app base

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51654 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1157949 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ webapps/docs/

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 18:59:03 2011 New Revision: 1157949 URL: http://svn.apache.org/viewvc?rev=1157949&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51654 Log an error message if an appBase is specified that is not a directory and disable automatic deployment to p

svn commit: r1157947 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 18:56:59 2011 New Revision: 1157947 URL: http://svn.apache.org/viewvc?rev=1157947&view=rev Log: Correct location Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/view

DO NOT REPLY [Bug 50353] Calling asyncContext.getResponse() returns null after async timeout

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50353 --- Comment #8 from Mark Thomas 2011-08-15 18:53:33 UTC --- http://java.net/projects/servlet-spec/lists and post to the users list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving

DO NOT REPLY [Bug 50353] Calling asyncContext.getResponse() returns null after async timeout

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50353 --- Comment #7 from David 2011-08-15 18:51:00 UTC --- Agreed - null is not specified (by the API) though it did provide a route in setting a local var and then testing for null (assuming the reference passed had volatile handling). Though

svn commit: r1157943 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/deploy/ java/org/apache/catalina/manager/ java/org/apache/catalina/startup

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 18:50:25 2011 New Revision: 1157943 URL: http://svn.apache.org/viewvc?rev=1157943&view=rev Log: Clean-up I do not intend to back-port (non-critical and changes the Host API) Modified: tomcat/trunk/java/org/apache/catalina/Host.java tomcat/trunk/java/org/apac

svn commit: r1157939 - in /tomcat/trunk/java/org/apache/catalina/startup: HostConfig.java LocalStrings.properties LocalStrings_es.properties LocalStrings_ja.properties

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 18:38:16 2011 New Revision: 1157939 URL: http://svn.apache.org/viewvc?rev=1157939&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51654 Log an error message if an appBase is specified that is not a directory and disable automatic deployment to p

DO NOT REPLY [Bug 50353] Calling asyncContext.getResponse() returns null after async timeout

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50353 --- Comment #6 from Mark Thomas 2011-08-15 18:37:30 UTC --- NPE is also unchecked so the end result is the same and now there is a clearer explanation of what went wrong. Any API changes will require a change to the Servlet specification.

DO NOT REPLY [Bug 50353] Calling asyncContext.getResponse() returns null after async timeout

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50353 --- Comment #5 from David 2011-08-15 18:32:35 UTC --- It now throws IllegalStateException which is an unchecked exception. I don't think i'm splitting hairs here, that I strongly believe it should be throwing a checked exception. Maybe th

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #2 from wheleph 2011-08-15 17:35:46 UTC --- Thanks for the prompt fix! I think it's also worth including in Tomcat 6 which is widely used now because this seems to be inaccuracy in implementation of Servlet specification. How do

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1157909 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/session/Benchmarks.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 16:54:51 2011 New Revision: 1157909 URL: http://svn.apache.org/viewvc?rev=1157909&view=rev Log: Fix benchmark tests Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/Benchmarks.java Propchange: tomcat/tc

svn commit: r1157908 - /tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 16:53:42 2011 New Revision: 1157908 URL: http://svn.apache.org/viewvc?rev=1157908&view=rev Log: Fix benchmark tests Modified: tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java Modified: tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java U

svn commit: r1157904 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardContextValve.java java/org/apache/catalina/core/StandardHostValve.java test/org/apache/catalina/core/TestStand

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 16:36:27 2011 New Revision: 1157904 URL: http://svn.apache.org/viewvc?rev=1157904&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 Move application level error page handling from the Host to the Context. This ensures that application error

DO NOT REPLY [Bug 51583] ConnectionPool.close() always waits one second unnecessarily

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1157884 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-15 Thread fhanik
Author: fhanik Date: Mon Aug 15 15:19:33 2011 New Revision: 1157884 URL: http://svn.apache.org/viewvc?rev=1157884&view=rev Log: update doco for bug fix Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.

svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-15 Thread fhanik
Author: fhanik Date: Mon Aug 15 15:06:35 2011 New Revision: 1157874 URL: http://svn.apache.org/viewvc?rev=1157874&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

svn commit: r1157872 - /tomcat/tc7.0.x/trunk/RELEASE-NOTES

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 15:03:57 2011 New Revision: 1157872 URL: http://svn.apache.org/viewvc?rev=1157872&view=rev Log: Not planning any Comet API removals Modified: tomcat/tc7.0.x/trunk/RELEASE-NOTES Modified: tomcat/tc7.0.x/trunk/RELEASE-NOTES URL: http://svn.apache.org/viewvc/tomc

svn commit: r1157869 - /tomcat/tc6.0.x/tags/TOMCAT_6_0_33/

2011-08-15 Thread jfclere
Author: jfclere Date: Mon Aug 15 15:00:08 2011 New Revision: 1157869 URL: http://svn.apache.org/viewvc?rev=1157869&view=rev Log: Oops a bit too early. Removed: tomcat/tc6.0.x/tags/TOMCAT_6_0_33/ - To unsubscribe, e-mail: de

Re: is this acceptor threadsafe?

2011-08-15 Thread Filip Hanik - Dev Lists
On 8/15/2011 6:34 AM, Ҷï wrote: /** * Server socket acceptor thread. */ protected class Acceptor implements Runnable { /** * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor.

svn commit: r1157860 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 14:25:05 2011 New Revision: 1157860 URL: http://svn.apache.org/viewvc?rev=1157860&view=rev Log: Remove unused method Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.j

svn commit: r1157855 - /tomcat/tc6.0.x/tags/TOMCAT_6_0_33/

2011-08-15 Thread jfclere
Author: jfclere Date: Mon Aug 15 14:12:40 2011 New Revision: 1157855 URL: http://svn.apache.org/viewvc?rev=1157855&view=rev Log: Release 6.0.33 Added: tomcat/tc6.0.x/tags/TOMCAT_6_0_33/ (props changed) - copied from r1157854, tomcat/tc6.0.x/trunk/ Propchange: tomcat/tc6.0.x/tags/TOMC

svn commit: r1157853 - /tomcat/tc6.0.x/trunk/build.properties.default

2011-08-15 Thread jfclere
Author: jfclere Date: Mon Aug 15 14:11:04 2011 New Revision: 1157853 URL: http://svn.apache.org/viewvc?rev=1157853&view=rev Log: Ready for release. Modified: tomcat/tc6.0.x/trunk/build.properties.default Modified: tomcat/tc6.0.x/trunk/build.properties.default URL: http://svn.apache.org/view

svn commit: r1157852 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-08-15 Thread jfclere
Author: jfclere Date: Mon Aug 15 14:05:12 2011 New Revision: 1157852 URL: http://svn.apache.org/viewvc?rev=1157852&view=rev Log: Remove my proposal... It needs more work. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/to

svn commit: r1157847 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 13:52:18 2011 New Revision: 1157847 URL: http://svn.apache.org/viewvc?rev=1157847&view=rev Log: Also seeing similar failures with NIO & APR Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java Modified: tomcat/trunk/test/org/apach

svn commit: r1157834 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 13:14:12 2011 New Revision: 1157834 URL: http://svn.apache.org/viewvc?rev=1157834&view=rev Log: Better fix for timing issues on Linux with unit tests Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java Modified: tomcat/trunk/test

svn commit: r1157832 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 13:03:34 2011 New Revision: 1157832 URL: http://svn.apache.org/viewvc?rev=1157832&view=rev Log: Attempt to fix timing issues on Linux unit tests Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContextValve.java Modified: tomcat/trunk/test/org/

is this acceptor threadsafe?

2011-08-15 Thread 叶茂
/** * Server socket acceptor thread. */ protected class Acceptor implements Runnable { /** * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor. */ public void run() {

svn commit: r1157810 - in /tomcat/trunk: java/org/apache/catalina/core/StandardContextValve.java java/org/apache/catalina/core/StandardHostValve.java test/org/apache/catalina/core/TestStandardContextV

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 12:29:58 2011 New Revision: 1157810 URL: http://svn.apache.org/viewvc?rev=1157810&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 Move custom error handling from Host to Context. Added: tomcat/trunk/test/org/apache/catalina/core/TestSt

DO NOT REPLY [Bug 51580] Severe error deploying WAR application (ExpandWar error)

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51580 Mark Thomas changed: What|Removed |Added Severity|major |enhancement --- Comment #9 from Mark

svn commit: r1157768 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/NamingContextListener.java webapps/docs/changelog.xml

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 10:46:09 2011 New Revision: 1157768 URL: http://svn.apache.org/viewvc?rev=1157768&view=rev Log: Unregisters MBean of DataSource when web application stops. (kfujino) Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomca

DO NOT REPLY [Bug 49929] AJP APR connector to mod_jk can result in SEND_BODY_CHUNK message after END_RESPONSE message

2011-08-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49929 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

svn commit: r1157766 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 10:41:54 2011 New Revision: 1157766 URL: http://svn.apache.org/viewvc?rev=1157766&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49929 No definitive information that this is the fix but back-porting Mladen's fix from 7.0.x should fix it. Modif

svn commit: r1157763 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-08-15 Thread markt
Author: markt Date: Mon Aug 15 10:29:08 2011 New Revision: 1157763 URL: http://svn.apache.org/viewvc?rev=1157763&view=rev Log: Fix typo Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomca