Re: svn commit: r1170485 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

2011-09-26 Thread Konstantin Kolinko
2011/9/26 Konstantin Kolinko knst.koli...@gmail.com: 2011/9/14  kfuj...@apache.org: Author: kfujino Date: Wed Sep 14 09:05:40 2011 New Revision: 1170485 URL: http://svn.apache.org/viewvc?rev=1170485view=rev Log: Additional fix for r1170479. Make sure calling disconnect() when only

svn commit: r1175690 - /tomcat/trunk/webapps/docs/tomcat-docs.xsl

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 06:38:51 2011 New Revision: 1175690 URL: http://svn.apache.org/viewvc?rev=1175690view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 Use slightly different color for code tags Modified: tomcat/trunk/webapps/docs/tomcat-docs.xsl

DO NOT REPLY [Bug 50923] Difficult to pick out valid values from config descriptions

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923 --- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-26 06:52:00 UTC --- I changed the color for code tags in trunk in r1175690. Generated documentation is available at buildbot. Please review. I am hesitant to introduce

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Konstantin Kolinko
2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 17:05:08 2011 New Revision: 1173251 URL: http://svn.apache.org/viewvc?rev=1173251view=rev Log: Don't add to Poller when socket is closing to prevent NPEs. Modified:    tomcat/tc7.0.x/trunk/   (props changed)    

DO NOT REPLY [Bug 43478] Using client flush before commit loses headers

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43478 --- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-26 07:17:40 UTC --- (In reply to comment #4) is there any plan to backport this patch to Apache 2.2? As far as I see this is already covered by the following commit in

Re: Mailing list for the Tomcat Maven Plugin

2011-09-26 Thread Olivier Lamy
2011/9/25 Konstantin Kolinko knst.koli...@gmail.com: 2011/9/14 Olivier Lamy ol...@apache.org: Hello Folks, I wonder if we have to create separates mailing lists or using the default tomcat mls ? (some users ping me directly to have separates) Let me know what is your opinion on that ? There

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2011-09-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-09-26 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.

svn commit: r1175713 - /tomcat/trunk/java/org/apache/juli/OneLineFormatter.java

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:39:05 2011 New Revision: 1175713 URL: http://svn.apache.org/viewvc?rev=1175713view=rev Log: Add thread name to OneLineFormatter. Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.java Modified:

svn commit: r1175717 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:43:03 2011 New Revision: 1175717 URL: http://svn.apache.org/viewvc?rev=1175717view=rev Log: Add thread name to juli OneLineFormatter. Merge of r1175713 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1175721 - in /tomcat/tc6.0.x/trunk: java/org/apache/juli/DateFormatCache.java java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 08:55:14 2011 New Revision: 1175721 URL: http://svn.apache.org/viewvc?rev=1175721view=rev Log: Backport (copy in) JULI OneLineFormatter plus DateFormatCache helper class from TC 7 JULI. Added: tomcat/tc6.0.x/trunk/java/org/apache/juli/DateFormatCache.java

svn commit: r1175723 - in /tomcat/tc6.0.x/trunk: java/org/apache/juli/DateFormatCache.java java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 09:00:26 2011 New Revision: 1175723 URL: http://svn.apache.org/viewvc?rev=1175723view=rev Log: Oups, revert r1175721, we are RTC. Will propose instead, sorry for the noise. Removed: tomcat/tc6.0.x/trunk/java/org/apache/juli/DateFormatCache.java

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2011-09-26 Thread Konstantin Kolinko
2011/9/26 Bill Barker billbar...@apache.org [checkstyle] Running Checkstyle 5.5-SNAPSHOT on 2069 files [checkstyle] /srv/gump/public/workspace/tomcat-trunk/java/org/apache/tomcat/util/http/fileupload/util/Streams.java:179:59: Got an exception - expecting '5', found '0' [checkstyle]

svn commit: r1175736 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/modeler/BaseModelMBean.java

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 09:16:33 2011 New Revision: 1175736 URL: http://svn.apache.org/viewvc?rev=1175736view=rev Log: Merged revisions r1174322, r1174329 from tomcat/trunk: Document thrown exception. This suppresses Exception is never thrown warning in Eclipse. Modified:

svn commit: r1175744 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread rjung
Author: rjung Date: Mon Sep 26 09:31:52 2011 New Revision: 1175744 URL: http://svn.apache.org/viewvc?rev=1175744view=rev Log: Proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1175778 - in /tomcat/site/trunk: docs/security-5.html docs/security-6.html docs/security-7.html xdocs/security-5.xml xdocs/security-6.xml xdocs/security-7.xml

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 10:36:53 2011 New Revision: 1175778 URL: http://svn.apache.org/viewvc?rev=1175778view=rev Log: Add CVE-2011-1184 Modified: tomcat/site/trunk/docs/security-5.html tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/docs/security-7.html

svn propchange: r1159309 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1159309 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:38:59 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:38:59 2011 @@ -1 +1,2 @@ Add additional configuration options

svn propchange: r1158180 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1158180 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:39:23 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:39:23 2011 @@ -1 +1,2 @@ Add additional configuration options

svn propchange: r1087655 - svn:log

2011-09-26 Thread markt
Author: markt Revision: 1087655 Modified property: svn:log Modified: svn:log at Mon Sep 26 10:40:00 2011 -- --- svn:log (original) +++ svn:log Mon Sep 26 10:40:00 2011 @@ -1 +1,2 @@ Add additional configuration options

[SECURITY] CVE-2011-1184 Apache Tomcat - Multiple weaknesses in HTTP DIGEST authentication

2011-09-26 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CVE-2011-1184 Apache Tomcat - Multiple weaknesses in HTTP DIGEST authentication Severity: Moderate Vendor: The Apache Software Foundation Versions Affected: - - Tomcat 7.0.0 to 7.0.11 - - Tomcat 6.0.0 to 6.0.32 - - Tomcat 5.5.0 to 5.5.33 - -

svn commit: r1175798 - /tomcat/trunk/RUNNING.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 11:14:23 2011 New Revision: 1175798 URL: http://svn.apache.org/viewvc?rev=1175798view=rev Log: Improve RUNNING.txt by adding the following: - Mention that CATALINA_HOME should have a correct value or be absent (BZ 51806) - Mention environment variables that are

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Mark Thomas
On 26/09/2011 08:00, Konstantin Kolinko wrote: 2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 17:05:08 2011 New Revision: 1173251 URL: http://svn.apache.org/viewvc?rev=1173251view=rev Log: Don't add to Poller when socket is closing to prevent NPEs. Modified:

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #14 from Harikrishnadhas Krishnaraj harikrishnadha...@capgemini.com 2011-09-26 13:06:20 UTC --- I'm Eagerly looking out tomcat to implement the Web Socket -- Configure bugmail:

svn commit: r1175889 - in /tomcat/trunk/test/org/apache/catalina/tribes/test/channel: TestDataIntegrity.java TestMulticastPackages.java TestUdpPackages.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:44:48 2011 New Revision: 1175889 URL: http://svn.apache.org/viewvc?rev=1175889view=rev Log: Remove unused code Modified: tomcat/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

svn commit: r1175891 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/test/channel/ webapps/docs/

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:46:50 2011 New Revision: 1175891 URL: http://svn.apache.org/viewvc?rev=1175891view=rev Log: Remove unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java

DO NOT REPLY [Bug 51893] New: JMX notification/Exception for empty/exhausted connection pool

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51893 Bug #: 51893 Summary: JMX notification/Exception for empty/exhausted connection pool Product: Tomcat Modules Version: unspecified Platform: PC OS/Version:

svn commit: r1175896 - in /tomcat/trunk: java/org/apache/catalina/startup/Embedded.java java/org/apache/catalina/valves/StuckThreadDetectionValve.java test/org/apache/tomcat/util/threads/TestLimitLatc

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 14:59:59 2011 New Revision: 1175896 URL: http://svn.apache.org/viewvc?rev=1175896view=rev Log: Fix some FindBugs warnings Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java

svn commit: r1175897 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Embedded.java java/org/apache/catalina/valves/StuckThreadDetectionValve.java test/org/apache/tomcat/util/threads/Te

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:01:21 2011 New Revision: 1175897 URL: http://svn.apache.org/viewvc?rev=1175897view=rev Log: Fix some FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Embedded.java

svn commit: r1175907 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:32:07 2011 New Revision: 1175907 URL: http://svn.apache.org/viewvc?rev=1175907view=rev Log: Fix a FindBugs warning Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java URL:

svn commit: r1175908 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 15:32:53 2011 New Revision: 1175908 URL: http://svn.apache.org/viewvc?rev=1175908view=rev Log: Fix a FindBugs warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java Propchange:

Re: svn commit: r1173251 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11AprProtocol.java

2011-09-26 Thread Mark Thomas
On 26/09/2011 13:46, Mark Thomas wrote: On 26/09/2011 08:00, Konstantin Kolinko wrote: 2011/9/20 ma...@apache.org: Author: markt Date: Tue Sep 20 17:05:08 2011 New Revision: 1173251 URL: http://svn.apache.org/viewvc?rev=1173251view=rev Log: Don't add to Poller when socket is closing to

svn commit: r1175933 - /tomcat/trunk/TOMCAT-NEXT.txt

2011-09-26 Thread markt
Author: markt Date: Mon Sep 26 16:15:25 2011 New Revision: 1175933 URL: http://svn.apache.org/viewvc?rev=1175933view=rev Log: Add to the Tomcat 8 TODOs Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL:

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #3 from Stephan Maminakis maminakis.step...@ensco.com 2011-09-26 17:48:19 UTC --- Mark, I have just upgraded from 7.0.20 to 7.0.21 and I think this resolution has affected a very simple error page that I have had in my web app

DO NOT REPLY [Bug 51894] New: Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 Bug #: 51894 Summary: Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat Product: Tomcat 7 Version: 7.0.21 Platform:

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #1 from Jacob Wu j...@digitalmeasures.com 2011-09-26 18:32:13 UTC --- Created attachment 27598 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27598 Demonstration -- Configure bugmail:

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #2 from Christopher Schultz ch...@christopherschultz.net 2011-09-26 19:01:24 UTC --- I'm not a Spring user: does the mvc:default-servlet-handler/ in demo-servlet.xml configure Spring's front controller to act like the default

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #3 from Jacob Wu j...@digitalmeasures.com 2011-09-26 19:08:08 UTC --- mvc:default-servlet-handler/ configures spring to forward requests for static content along to the servlet container's default servlet.

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #4 from Jacob Wu j...@digitalmeasures.com 2011-09-26 19:14:26 UTC --- I should also mention that we tried dynamically including static content in Jetty and it worked as we had expected. The attached sample also works in Jetty

svn commit: r1176101 - in /tomcat/site/trunk: docs/security-6.html xdocs/security-6.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:18:25 2011 New Revision: 1176101 URL: http://svn.apache.org/viewvc?rev=1176101view=rev Log: Add release date Modified: tomcat/site/trunk/docs/security-6.html tomcat/site/trunk/xdocs/security-6.xml Modified: tomcat/site/trunk/docs/security-6.html URL:

svn commit: r1176103 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:33:11 2011 New Revision: 1176103 URL: http://svn.apache.org/viewvc?rev=1176103view=rev Log: Add CVE number. Sort issues by number. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1176109 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:47:03 2011 New Revision: 1176109 URL: http://svn.apache.org/viewvc?rev=1176109view=rev Log: Add CVE number. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1176126 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:12:02 2011 New Revision: 1176126 URL: http://svn.apache.org/viewvc?rev=1176126view=rev Log: Simplify code in NioEndpoint$Poller. The events.size() call is costly, because it is a loop that counts entries in a linked queue. Actually it is not needed here at

svn commit: r1176118 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 22:54:37 2011 New Revision: 1176118 URL: http://svn.apache.org/viewvc?rev=1176118view=rev Log: Add issue that was missed in changelog (r1172317). Add CVE number to DIGEST authentication issue. Modified:

svn commit: r1176128 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:23:20 2011 New Revision: 1176128 URL: http://svn.apache.org/viewvc?rev=1176128view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1176132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-09-26 Thread kkolinko
Author: kkolinko Date: Mon Sep 26 23:44:05 2011 New Revision: 1176132 URL: http://svn.apache.org/viewvc?rev=1176132view=rev Log: Add revision numbers for issues that have been fixed in TC7: r1138132, r1175897 Remove ConcurrentHashMap tuning proposal (it is unlikely to have so many CPUs that it

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 --- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-27 00:30:44 UTC --- Please provide a WAR file (without Spring libraries - those can be downloaded), so that it can be tested. Thus I cannot test the app itself. Testing

DO NOT REPLY [Bug 51894] Dynamic includes (with jsp:include or in Java code) of static content fails with Spring + Tomcat

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51894 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

DO NOT REPLY [Bug 51653] ServletRequestListener.requestDestroyed is called before request leaves a webapp

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51653 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-27 00:49:36 UTC --- (In reply to comment #3) I have just upgraded from 7.0.20 to 7.0.21 and I think this resolution has affected a very simple error page that I have

DO NOT REPLY [Bug 51883] NullPointerException in StandardContextValve.invoke

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51883 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-27 00:55:40 UTC --- It looks a lot like bug 51494 (NPE in StandardContextValve if request is being processed while webapp is being redeployed), but that should have been

DO NOT REPLY [Bug 18500] Host aliases to match by regular expression

2011-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=18500 --- Comment #10 from Konstantin Kolinko knst.koli...@gmail.com 2011-09-27 01:12:47 UTC --- (In reply to comment #9) I just wouldn't watch to mix-and-match too many name-matching styles or things are going to get seriously ridiculous

svn commit: r1176157 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/modeler/ManagedBean.java java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDigesterSource.java java/org/apach

2011-09-26 Thread kkolinko
Author: kkolinko Date: Tue Sep 27 01:21:08 2011 New Revision: 1176157 URL: http://svn.apache.org/viewvc?rev=1176157view=rev Log: Merged revision 1174325 from tomcat/trunk: Fix a small number of Eclipse warnings. - Unused code - Unnecessary null checks Modified: tomcat/tc7.0.x/trunk/