https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #20 from Konstantin Kolinko 2011-10-15
03:02:36 UTC ---
(In reply to comment #19)
> $127.0.0.1
> Of course, the regex is invalid. BUT THE CONTEXT RELOADS!!
The regex is valid. There is nothing syntactically wrong with it
On Tue, Oct 11, 2011 at 14:09, Francis Galiegue wrote:
[...]
>
> Yes, I was kind of wondering whether the .get*() methods required
> symmetry with .put*(). So, this is one of my questions answered.
>
> Along with the question of why Remote{Host,Addr}Filter cleared allow
> and deny before assigning
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
--- Comment #19 from Francis Galiegue 2011-10-14 23:16:06
UTC ---
Well, my filter is not the only one affected.
I also added this to web.xml:
host
org.apache.catalina.filters.RemoteHostFilter
deny
$127.0.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
Francis Galiegue changed:
What|Removed |Added
Attachment #27691|0 |1
is obsolete|
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|
Author: markt
Date: Fri Oct 14 20:59:19 2011
New Revision: 1183499
URL: http://svn.apache.org/viewvc?rev=1183499&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Port fix (r1183494) from trunk
Fix the NPE if an error occurs during comet processing
Add test cases for error
Author: markt
Date: Fri Oct 14 20:55:42 2011
New Revision: 1183498
URL: http://svn.apache.org/viewvc?rev=1183498&view=rev
Log:
Port refactoring (r1183493) from trunk
Move the access log validation to the TesterAccessLogValve so that is is
available to all tests that use the valve.
Modified:
t
Author: markt
Date: Fri Oct 14 20:50:57 2011
New Revision: 1183494
URL: http://svn.apache.org/viewvc?rev=1183494&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Fix the NPE if an error occurs during comet processing
Add test cases for errors during comet processing
Ensur
Author: markt
Date: Fri Oct 14 20:46:15 2011
New Revision: 1183493
URL: http://svn.apache.org/viewvc?rev=1183493&view=rev
Log:
Move the access log validation to the TesterAccessLogValve so that is is
available to all tests that use the valve.
Modified:
tomcat/trunk/test/org/apache/catalina/co
Author: markt
Date: Fri Oct 14 20:40:17 2011
New Revision: 1183492
URL: http://svn.apache.org/viewvc?rev=1183492&view=rev
Log:
Clean-up
- remove trailing whitespace
- add final where appropriate
- add {...} where appropriate
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdap
On Oct 14, 2011, at 6:05 AM, Olivier Lamy wrote:
> 2011/10/14 Mark Thomas :
>> On 14/10/2011 09:15, Konstantin Kolinko wrote:
>>> 2011/10/14 David Blevins :
We've been using plain Tomcat zips for creating TomEE in the
OpenEJB maven build for a while now. So far that has been done by
>>
On 14/10/2011 15:00, Konstantin Kolinko wrote:
> 2011/10/14 Mark Thomas :
>>> How? Some git push (or haw it is called there?) that writes directly
>>> to the repository?
>>
>> git svn dcommit
>>
>> See:
>> http://wiki.apache.org/general/GitAtApache
>>
>> I had been through the process once to res
On Fri, Oct 14, 2011 at 20:08, Mark Thomas wrote:
> On 14/10/2011 19:00, Francis Galiegue wrote:
>> [...] The trouble is
>> that I don't feel like git svn cloning directly given that my
>> bandwidth is very poor and the Apache SVN repo has a number of commits
>> in the 7 digit range (even if the f
On 14/10/2011 19:00, Francis Galiegue wrote:
> Hello,
>
> I have lost the discussion, but remember one thing having been
> discussed today about the git repo for tomcat 7.x being broken because
> its trunk followed 8.0-dev instead (I did notice that but thought it
> was on purpose).
>
> Do 8.0.x
Great Olivier
Impatient to see it in action, best of both worlds
Le 14 oct. 2011 à 19:37, Olivier Lamy a écrit :
> Hello,
> I can maybe help here.
> A solution I have in mind to not change sources layout.
> http://svn.apache.org/repos/asf/tomcat/trunk/
> /maven/pom.xml (root pom.xml
Hello,
I have lost the discussion, but remember one thing having been
discussed today about the git repo for tomcat 7.x being broken because
its trunk followed 8.0-dev instead (I did notice that but thought it
was on purpose).
Do 8.0.x and 7.x differ enough that I'll have to re-clone my repo and
Hello,
I can maybe help here.
A solution I have in mind to not change sources layout.
http://svn.apache.org/repos/asf/tomcat/trunk/
/maven/pom.xml (root pom.xml here)
/tomcat-coyote/pom.xml
etc.. one module for each artifact to produce
p
2011/10/14 Henri Gomez :
>>
>> This is the first time that I can recall that anyone has stated that
>> there is a requirement for this.
>>
>
> I should say many companies, including mine are injecting full Tomcat (as
> zip) in their enterprise repositories (Archiva/Nexus/Artifactory powered)
Are a
On 14/10/2011 17:53, Henri Gomez wrote:
>> Granted, the Tomcat project currently has no interest in using Maven as
>> a build system but that doesn't mean Maven is ignored. A lot of work
>> went into improving the Maven artefacts for Tomcat 7.
>
>
> Use of Maven was allready discussed many times
>
>
> Binary dependencies for any build process do not belong in svn. The
> infra team doesn't go looking for them but where a project is found
> using them then they will be encouraged to use a more appropriate
> approach. The more excessive the usage, the stronger the encouragement.
> The odd ja
On 14/10/2011 17:40, David Jencks wrote:
>
> On Oct 14, 2011, at 9:18 AM, Mark Thomas wrote:
>
>> On 14/10/2011 17:09, David Jencks wrote:
>>> If using a non-tomcat groupId is the only choice I'd keep the
>>> openejb copy in apache svn.
>>
>> That is not an option that is acceptable to the ASF i
>
> This is the first time that I can recall that anyone has stated that
> there is a requirement for this.
>
I should say many companies, including mine are injecting full Tomcat (as
zip) in their enterprise repositories (Archiva/Nexus/Artifactory powered)
> Granted, the Tomcat project currentl
On Oct 14, 2011, at 9:18 AM, Mark Thomas wrote:
> On 14/10/2011 17:09, David Jencks wrote:
>> If using a non-tomcat groupId is the
>> only choice I'd keep the openejb copy in apache svn.
>
> That is not an option that is acceptable to the ASF infrastructure team.
In this context, it's pretty mu
On 14/10/2011 17:09, David Jencks wrote:
>
> On Oct 14, 2011, at 4:06 AM, Mark Thomas wrote:
>> Since the requirements for this are driven by the OpenEJB project
>> and - as far as I am aware - they are the only folks with this
>> requirement, I suggest that OpenEJB runs with this and publishes
>
On 14/10/2011 17:09, David Jencks wrote:
> If using a non-tomcat groupId is the
> only choice I'd keep the openejb copy in apache svn.
That is not an option that is acceptable to the ASF infrastructure team.
Mark
-
To unsubscrib
On Oct 14, 2011, at 4:06 AM, Mark Thomas wrote:
> On 14/10/2011 09:15, Konstantin Kolinko wrote:
>> 2011/10/14 David Blevins :
>>> We've been using plain Tomcat zips for creating TomEE in the
>>> OpenEJB maven build for a while now. So far that has been done by
>>> publishing the Tomcat zips to
Author: kkolinko
Date: Fri Oct 14 16:07:51 2011
New Revision: 1183404
URL: http://svn.apache.org/viewvc?rev=1183404&view=rev
Log:
Add build date and version to documentation pages
Automate copyright end date
It is based on r962466
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/t
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
--- Comment #11 from Mark Thomas 2011-10-14 15:03:08 UTC ---
(In reply to comment #9)
> > 5. If I put breakpoint on the request.recycle() call above, the call stack
> > is:
> >
> > CoyoteAdapter.event(Request, Response, SocketStatus) line
2011/10/14 Mark Thomas :
> On 14/10/2011 14:51, Konstantin Kolinko wrote:
>> 2011/10/14 Mark Thomas :
>>> On 14/10/2011 14:10, Konstantin Kolinko wrote:
2011/10/14 :
> Author: markt
> Date: Fri Oct 14 12:55:55 2011
> New Revision: 1183340
>
> URL: http://svn.apache.org/vie
On 14/10/2011 14:51, Konstantin Kolinko wrote:
> 2011/10/14 Mark Thomas :
>> On 14/10/2011 14:10, Konstantin Kolinko wrote:
>>> 2011/10/14 :
Author: markt
Date: Fri Oct 14 12:55:55 2011
New Revision: 1183340
URL: http://svn.apache.org/viewvc?rev=1183340&view=rev
Log:
2011/10/14 Mark Thomas :
> On 14/10/2011 14:10, Konstantin Kolinko wrote:
>> 2011/10/14 :
>>> Author: markt
>>> Date: Fri Oct 14 12:55:55 2011
>>> New Revision: 1183340
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1183340&view=rev
>>> Log:
>>> Fix typo
>>>
>>> Modified:
>>> tomcat/trunk/java/o
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Mark Thomas changed:
What|Removed |Added
CC|ma...@apache.org|
--
Configure bugmail: https://issu
On 14/10/2011 14:10, Konstantin Kolinko wrote:
> 2011/10/14 :
>> Author: markt
>> Date: Fri Oct 14 12:55:55 2011
>> New Revision: 1183340
>>
>> URL: http://svn.apache.org/viewvc?rev=1183340&view=rev
>> Log:
>> Fix typo
>>
>> Modified:
>>tomcat/trunk/java/org/apache/catalina/startup/ContextConf
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923
Sebb changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
--- Comment #10 from viola.lu 2011-10-14 13:25:24 UTC ---
Hi, Mark:
Sorry to add you to the cc list without notification in advance. I tried to
send email to ma...@apache.org, but rejected, and you are the NIO connector
code owner, so i d
2011/10/14 :
> Author: markt
> Date: Fri Oct 14 12:55:55 2011
> New Revision: 1183340
>
> URL: http://svn.apache.org/viewvc?rev=1183340&view=rev
> Log:
> Fix typo
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
>
> ...
> [... 2667 lines stripped ...]
again...
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Konstantin Kolinko changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|I
2011/10/14 Mark Thomas :
> On 14/10/2011 09:15, Konstantin Kolinko wrote:
>> 2011/10/14 David Blevins :
>>> We've been using plain Tomcat zips for creating TomEE in the
>>> OpenEJB maven build for a while now. So far that has been done by
>>> publishing the Tomcat zips to a maven repo in svn. Not
On 14/10/2011 00:20, Mark Thomas wrote:
> On 14/10/2011 00:07, Konstantin Kolinko wrote:
>> 2011/10/14 :
>>> Author: markt
>>> Date: Thu Oct 13 22:28:22 2011
>>> New Revision: 1183142
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1183142&view=rev
>>> Log:
>>> Cache the result of parsing global and
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
2011/10/14 Mark Thomas :
> If binding to a random port is to be supported I think it needs to be an
> explicit choice - e.g. by setting a special value such as "auto" - and
> ideally needs to be supported by all connectors.
>
2011/10/14 Olivier Lamy :
> Do we agree on the fact that after been star
Author: markt
Date: Fri Oct 14 12:55:55 2011
New Revision: 1183340
URL: http://svn.apache.org/viewvc?rev=1183340&view=rev
Log:
Fix typo
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
-
To unsubsc
Author: markt
Date: Fri Oct 14 12:55:04 2011
New Revision: 1183339
URL: http://svn.apache.org/viewvc?rev=1183339&view=rev
Log:
Revert to previous approach to generating InputSource objects for web.xml files
Obtain last modified times from the SystemID of the InputSource
Modified:
tomcat/trunk
2011/10/14 Mark Thomas :
> On 14/10/2011 09:27, Olivier Lamy wrote:
>> 2011/10/10 Konstantin Kolinko :
>>> 2011/10/9 Olivier Lamy :
tomcat.getConnector().setPort( 0 );
>>>
>>> 1) Look at how TomcatBaseTest assigns subsequent port numbers,
>>> starting with 8001.
>>>
>>> http://svn.apache.org/v
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923
--- Comment #13 from Konstantin Kolinko 2011-10-14
12:31:10 UTC ---
Using lightcyan background in r1183328.
Backported to TC7 in r1183329 for 7.0.23.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--
Author: kkolinko
Date: Fri Oct 14 12:29:15 2011
New Revision: 1183329
URL: http://svn.apache.org/viewvc?rev=1183329&view=rev
Log:
Merged revision 1183328 from tomcat/trunk:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923
Documentation: Use default color, but lightcyan background for code
https://issues.apache.org/bugzilla/show_bug.cgi?id=52028
Bug #: 52028
Summary: Embeded Tomcat using a Connector with a random port
(port 0)
Product: Tomcat 7
Version: trunk
Platform: All
OS/Version: All
Author: kkolinko
Date: Fri Oct 14 12:26:04 2011
New Revision: 1183328
URL: http://svn.apache.org/viewvc?rev=1183328&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50923
Documentation: Use default color, but lightcyan background for code tags.
Based on a suggestion by sebb.
Proper
On 14/10/2011 09:27, Olivier Lamy wrote:
> 2011/10/10 Konstantin Kolinko :
>> 2011/10/9 Olivier Lamy :
>>> tomcat.getConnector().setPort( 0 );
>>
>> 1) Look at how TomcatBaseTest assigns subsequent port numbers,
>> starting with 8001.
>>
>> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/
2011/10/14 Henri Gomez :
>>> 3) There are several Connector/Endpoint implementations in Tomcat.
>>> While java.net.ServerSocket does support port number of "0", I am not
>>> sure that APR-based implementation does allow it.
>> Sure but the use case is just to start a http/https (apr can be
>> omit
2011/10/13 Mark Thomas :
> On 13/10/2011 09:03, jean-frederic clere wrote:
...
>>> 3) The above issues are already mentioned on the generic security page
>>> (security.html), but on security-6.html page there is no direct link
>>> back to security.html unless you pay attention to the site menu on t
Author: kkolinko
Date: Fri Oct 14 11:16:35 2011
New Revision: 1183305
URL: http://svn.apache.org/viewvc?rev=1183305&view=rev
Log:
Correct punctuation.
Modified:
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/docs/security-6.html
tomcat/site/trunk/docs/security-7.html
tom
Author: kkolinko
Date: Fri Oct 14 11:11:58 2011
New Revision: 1183302
URL: http://svn.apache.org/viewvc?rev=1183302&view=rev
Log:
Update other security pages.
Replaced direct mail@ address with a link to security.html page.
Modified:
tomcat/site/trunk/docs/security-3.html
tomcat/site/trun
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
Mark Thomas changed:
What|Removed |Added
CC|viola...@gmail.com |
--- Comment #7 from Mark Thomas 20
On 14/10/2011 09:15, Konstantin Kolinko wrote:
> 2011/10/14 David Blevins :
>> We've been using plain Tomcat zips for creating TomEE in the
>> OpenEJB maven build for a while now. So far that has been done by
>> publishing the Tomcat zips to a maven repo in svn. Not the best
>> idea to have them
Author: kkolinko
Date: Fri Oct 14 11:01:30 2011
New Revision: 1183296
URL: http://svn.apache.org/viewvc?rev=1183296&view=rev
Log:
Amend security pages for Tomcat 5.5 and 7.0.
Add links to build instructions.
Modified:
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/docs/security-
Author: olamy
Date: Fri Oct 14 10:46:48 2011
New Revision: 1183290
URL: http://svn.apache.org/viewvc?rev=1183290&view=rev
Log:
add trademark notes on footer
Modified:
tomcat/maven-plugin/trunk/src/site/site.xml
Modified: tomcat/maven-plugin/trunk/src/site/site.xml
URL:
http://svn.apache.org
Author: kkolinko
Date: Fri Oct 14 10:41:28 2011
New Revision: 1183288
URL: http://svn.apache.org/viewvc?rev=1183288&view=rev
Log:
Update summary section on security-6.html page.
The pages for other Tomcat versions will be updated later.
Modified:
tomcat/site/trunk/docs/security-6.html
tom
Author: olamy
Date: Fri Oct 14 09:52:15 2011
New Revision: 1183268
URL: http://svn.apache.org/viewvc?rev=1183268&view=rev
Log:
inherit reports and modules for sub modules site
Modified:
tomcat/maven-plugin/trunk/src/site/site.xml
Modified: tomcat/maven-plugin/trunk/src/site/site.xml
URL:
ht
Author: olamy
Date: Fri Oct 14 09:43:13 2011
New Revision: 1183265
URL: http://svn.apache.org/viewvc?rev=1183265&view=rev
Log:
add integration test to ensure we start https and ajp in tomcat7 plugin
Added:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/test/keystore
Modified:
tomcat/
Author: olamy
Date: Fri Oct 14 09:27:43 2011
New Revision: 1183258
URL: http://svn.apache.org/viewvc?rev=1183258&view=rev
Log:
add integration test to ensure we start https and ajp in tomcat6 plugin
Added:
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/test/keystore
Modified:
tomcat/m
>> 3) There are several Connector/Endpoint implementations in Tomcat.
>> While java.net.ServerSocket does support port number of "0", I am not
>> sure that APR-based implementation does allow it.
> Sure but the use case is just to start a http/https (apr can be
> omitted) connector on any random f
2011/10/10 Konstantin Kolinko :
> 2011/10/9 Olivier Lamy :
>> tomcat.getConnector().setPort( 0 );
>
> 1) Look at how TomcatBaseTest assigns subsequent port numbers,
> starting with 8001.
>
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?view=markup#l
2011/10/14 David Blevins :
> We've been using plain Tomcat zips for creating TomEE in the OpenEJB maven
> build for a while now. So far that has been done by publishing the Tomcat
> zips to a maven repo in svn. Not the best idea to have them in svn, so we're
> trying to get them in the actual
except some webapps included in distrib are not in central repo:
* manager
* host-manager
* examples
* docs
* ROOT
2011/10/14 Henri Gomez :
>>> The goal is to have this as a maven artifact:
>>>
>>>
>>> http://www.apache.org/dist/tomcat/tomcat-7/v7.0.22/bin/apache-tomcat-7.0.22.zip
>>
>> You
>> The goal is to have this as a maven artifact:
>>
>>
>> http://www.apache.org/dist/tomcat/tomcat-7/v7.0.22/bin/apache-tomcat-7.0.22.zip
>
> You really need this file? I think you just use the jars in the file,
> correct?
David, why do you want to use a complete distro instead of
independants art
On 10/14/2011 09:17 AM, David Blevins wrote:
On Oct 14, 2011, at 12:07 AM, jean-frederic clere wrote:
On 10/14/2011 02:01 AM, David Blevins wrote:
We've been using plain Tomcat zips for creating TomEE in the OpenEJB maven
build for a while now. So far that has been done by publishing the To
https://issues.apache.org/bugzilla/show_bug.cgi?id=52009
viola.lu changed:
What|Removed |Added
CC||ma...@apache.org
--
Configure bugmail:
On Oct 14, 2011, at 12:07 AM, jean-frederic clere wrote:
> On 10/14/2011 02:01 AM, David Blevins wrote:
>> We've been using plain Tomcat zips for creating TomEE in the OpenEJB maven
>> build for a while now. So far that has been done by publishing the Tomcat
>> zips to a maven repo in svn. No
On 10/14/2011 02:01 AM, David Blevins wrote:
We've been using plain Tomcat zips for creating TomEE in the OpenEJB maven
build for a while now. So far that has been done by publishing the Tomcat zips
to a maven repo in svn. Not the best idea to have them in svn, so we're trying
to get them in
70 matches
Mail list logo
