Hi!
I am working on a patch that prevents RequestFilterValve from starting
on configuration errors.
Current versions:
http://people.apache.org/~kkolinko/patches/2011-10-26_tc6_RequestFilterValve_v3.patch
http://people.apache.org/~kkolinko/patches/2011-10-26_tc55_RequestFilterValve_v3.patch
Author: kkolinko
Date: Wed Oct 26 23:14:10 2011
New Revision: 1189533
URL: http://svn.apache.org/viewvc?rev=1189533&view=rev
Log:
Vote. Now it works. It was a glitch in testing. More on dev@.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn
Author: kkolinko
Date: Wed Oct 26 23:02:46 2011
New Revision: 1189524
URL: http://svn.apache.org/viewvc?rev=1189524&view=rev
Log:
Update, but remove my vote. TC6 patch does not work.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.o
Author: kkolinko
Date: Wed Oct 26 23:00:56 2011
New Revision: 1189523
URL: http://svn.apache.org/viewvc?rev=1189523&view=rev
Log:
proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?re
Author: kkolinko
Date: Wed Oct 26 21:53:15 2011
New Revision: 1189493
URL: http://svn.apache.org/viewvc?rev=1189493&view=rev
Log:
Update description and propose CsrfPreventionFilter patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apa
Author: kkolinko
Date: Wed Oct 26 21:33:43 2011
New Revision: 1189482
URL: http://svn.apache.org/viewvc?rev=1189482&view=rev
Log:
Merged revision 1189477 from tomcat/trunk:
Followup to r1189256
Correct typo in i18n message: RemoteIpValve is a different beast
Add Javadoc for new fields in RequestFi
Author: kkolinko
Date: Wed Oct 26 21:27:24 2011
New Revision: 1189477
URL: http://svn.apache.org/viewvc?rev=1189477&view=rev
Log:
Followup to r1189256
Correct typo in i18n message: RemoteIpValve is a different beast
Add Javadoc for new fields in RequestFilterValve
Modified:
tomcat/trunk/java/
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744
--- Comment #11 from Leonid Mikhailov 2011-10-26 21:24:19
UTC ---
Here you go:
javax.naming.NamingException: Context is read only
at org.apache.naming.NamingContext.checkWritable(NamingContext.java:941)
at org.apache.naming.Naming
Author: kkolinko
Date: Wed Oct 26 21:21:40 2011
New Revision: 1189474
URL: http://svn.apache.org/viewvc?rev=1189474&view=rev
Log:
Update proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS
2011/10/27 Francis Galiegue :
> On Wed, Oct 26, 2011 at 22:40, wrote:
>> Author: kkolinko
>> Date: Wed Oct 26 20:40:20 2011
>> New Revision: 1189436
>>
> [...]
>
> Ouch. My proposal has just become a lot more complicated :p
That is Tomcat 6.
For Tomcat 7+ you do not need to implement a Lifecycle
On Wed, Oct 26, 2011 at 22:40, wrote:
> Author: kkolinko
> Date: Wed Oct 26 20:40:20 2011
> New Revision: 1189436
>
[...]
Ouch. My proposal has just become a lot more complicated :p
--
Francis Galiegue, fgalie...@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tool
Author: kkolinko
Date: Wed Oct 26 20:40:20 2011
New Revision: 1189436
URL: http://svn.apache.org/viewvc?rev=1189436&view=rev
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re
Author: markt
Date: Wed Oct 26 20:12:27 2011
New Revision: 1189423
URL: http://svn.apache.org/viewvc?rev=1189423&view=rev
Log:
MBean deregistration is not responsible for clearing the serivce. This happens
during destroy()
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/
Author: markt
Date: Wed Oct 26 20:10:19 2011
New Revision: 1189420
URL: http://svn.apache.org/viewvc?rev=1189420&view=rev
Log:
Fix typo
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/FilterBase.java
Propchange: tomcat/tc7.0.x/trunk
Author: markt
Date: Wed Oct 26 19:51:38 2011
New Revision: 1189414
URL: http://svn.apache.org/viewvc?rev=1189414&view=rev
Log:
MBean deregistration should not be breaking the link between Connector
and Service. Connector destroy is the right place for that.
Modified:
tomcat/trunk/java/org/apa
Author: markt
Date: Wed Oct 26 19:50:46 2011
New Revision: 1189413
URL: http://svn.apache.org/viewvc?rev=1189413&view=rev
Log:
Fix typo
Modified:
tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java
Modified: tomcat/trunk/java/org/apache/catalina/filters/FilterBase.java
URL:
http:/
On 26/10/2011 20:42, Francis Galiegue wrote:
> On Wed, Oct 26, 2011 at 21:40, Mark Thomas wrote:
>
>>>
>>> + * @return true if a problem should trigger the
>>> failure of this
>>
>> So?
>>
>
> true.
Got it. Tx. I'll fix that in a sec.
Mark
-
On Wed, Oct 26, 2011 at 21:40, Mark Thomas wrote:
>>
>> + * @return true if a problem should trigger the
>> failure of this
>
> So?
>
true.
--
Francis Galiegue, fgalie...@gmail.com
"It seems obvious [...] that at least some 'business intelligence'
tools invest so much intelligence on the
On 26/10/2011 20:24, Francis Galiegue wrote:
> On Wed, Oct 26, 2011 at 21:17, Mark Thomas wrote:
>> On 26/10/2011 20:07, Francis Galiegue wrote:
>>> Hello,
>>>
>>> It has been now three weeks since I opened this enhancement request:
>>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
On Wed, Oct 26, 2011 at 21:17, Mark Thomas wrote:
> On 26/10/2011 20:07, Francis Galiegue wrote:
>> Hello,
>>
>> It has been now three weeks since I opened this enhancement request:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
>>
>> I am confident enough with this patch that I ac
On 26/10/2011 20:07, Francis Galiegue wrote:
> Hello,
>
> It has been now three weeks since I opened this enhancement request:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
>
> I am confident enough with this patch that I actually use it instead
> of the existing RemoteAddrValve (
Author: kkolinko
Date: Wed Oct 26 19:14:01 2011
New Revision: 1189394
URL: http://svn.apache.org/viewvc?rev=1189394&view=rev
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #22 from Mark Thomas 2011-10-26 19:09:37 UTC ---
Since this is security related, requesting FIPS and the native library not
supporting it should prevent Tomcat from starting. You probably want to trap
the exception and throw a n
Author: kkolinko
Date: Wed Oct 26 19:10:25 2011
New Revision: 1189393
URL: http://svn.apache.org/viewvc?rev=1189393&view=rev
Log:
Merged revision 1189386 from tomcat/trunk:
In DeltaSession.setId(String): fix duplicate resetDeltaRequest() call.
It occurred via super.setId(id) calling overridden Del
Hello,
It has been now three weeks since I opened this enhancement request:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51953
I am confident enough with this patch that I actually use it instead
of the existing RemoteAddrValve (since my implementation doesn't get
confused by ::1 just to c
Author: kkolinko
Date: Wed Oct 26 19:01:58 2011
New Revision: 1189386
URL: http://svn.apache.org/viewvc?rev=1189386&view=rev
Log:
In DeltaSession.setId(String): fix duplicate resetDeltaRequest() call.
It occurred via super.setId(id) calling overridden DeltaSession.setId(id, true).
Modified:
Author: kkolinko
Date: Wed Oct 26 18:55:56 2011
New Revision: 1189382
URL: http://svn.apache.org/viewvc?rev=1189382&view=rev
Log:
Avoid an unnecessary session ID change notice.
Notice of changed session ID by JvmRouteBinderValve is unnecessary to
BackupManager.
In BackupManager, change of sessi
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #21 from Christopher Schultz
2011-10-26 18:44:18 UTC ---
(In reply to comment #20)
> Chris, did you put together an updated patch for this?
I have a patch sitting in my local svn working copy of TC 8 trunk: I haven't
gotten a
Author: kkolinko
Date: Wed Oct 26 18:29:37 2011
New Revision: 1189364
URL: http://svn.apache.org/viewvc?rev=1189364&view=rev
Log:
Simplify changelog entry. Fix linewrap.
Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
https://issues.apache.org/bugzilla/show_bug.cgi?id=52049
--- Comment #4 from Konstantin Kolinko 2011-10-26
18:18:38 UTC ---
Updated 5.5 docs as well in r1189356 - will be in 5.5.35.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this
Author: kkolinko
Date: Wed Oct 26 18:19:25 2011
New Revision: 1189356
URL: http://svn.apache.org/viewvc?rev=1189356&view=rev
Log:
CTR: Docs
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52049
Improve setup instructions for running as a Windows service
- remove references to specific Windo
Sorry. Will post there.
--cheers,
Rohit
On Wed, Oct 26, 2011 at 11:21 AM, Mark Thomas wrote:
> On 26/10/2011 03:13, Rohit Kelapure wrote:
>> Dear All,
>>
>> After going through the thread renewal code in
>> /tomcat-8.0.x/java/org/apache/tomcat/util/threads/TaskQueue.java ,
>> /tomcat-8.0.x/java/
On 26/10/2011 03:13, Rohit Kelapure wrote:
> Dear All,
>
> After going through the thread renewal code in
> /tomcat-8.0.x/java/org/apache/tomcat/util/threads/TaskQueue.java ,
> /tomcat-8.0.x/java/org/apache/tomcat/util/threads/ThreadPoolExecutor.java
> and the bug (Improve ThreadLocal memory leak
Author: markt
Date: Wed Oct 26 15:06:19 2011
New Revision: 1189258
URL: http://svn.apache.org/viewvc?rev=1189258&view=rev
Log:
Make configuration issues for security related valves and filters result in the
failure of the valve or filter rather than just a warning message.
Modified:
tomcat/t
Author: markt
Date: Wed Oct 26 15:02:01 2011
New Revision: 1189256
URL: http://svn.apache.org/viewvc?rev=1189256&view=rev
Log:
Make configuration issues for security related valves and filters result in the
failure of the valve or filter rather than just a warning message.
Modified:
tomcat/t
Author: kkolinko
Date: Wed Oct 26 14:38:55 2011
New Revision: 1189243
URL: http://svn.apache.org/viewvc?rev=1189243&view=rev
Log:
CTR: Docs
Merged revision 1189240 from tomcat/trunk:
Update logging documentation:
group together the files that are put in lib/ when configuring log4j logging.
Some us
Author: kkolinko
Date: Wed Oct 26 14:36:12 2011
New Revision: 1189242
URL: http://svn.apache.org/viewvc?rev=1189242&view=rev
Log:
Merged revision 1189240 from tomcat/trunk:
Update logging documentation:
group together the files that are put in lib/ when configuring log4j logging.
Some users were c
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066
--- Comment #2 from Alexander Pogrebnyak
2011-10-26 14:31:26 UTC ---
(In reply to comment #1)
There may be quite a few clients down the call chain that require the knowledge
that interrupt is in progress, and clearing of the interrupted f
Author: kkolinko
Date: Wed Oct 26 14:32:46 2011
New Revision: 1189240
URL: http://svn.apache.org/viewvc?rev=1189240&view=rev
Log:
Update logging documentation:
group together the files that are put in lib/ when configuring log4j logging.
Some users were confused and put one file into bin/.
Modifi
https://issues.apache.org/bugzilla/show_bug.cgi?id=52092
--- Comment #1 from Rainer Jung 2011-10-26 14:16:35
UTC ---
I'm +1 for TC 8 and +0 for TC 7 (not a clear +1 because of user compatibility
reasons)
Rainer
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
-
https://issues.apache.org/bugzilla/show_bug.cgi?id=52066
--- Comment #1 from Konstantin Kolinko 2011-10-26
14:13:51 UTC ---
1. Thread.interrupted() - clears the flag
2. new SQLException() - bails out
It does sx.initCause(ex), so original InterruptedException is still there.
Do you have trouble
Author: kkolinko
Date: Wed Oct 26 14:02:40 2011
New Revision: 1189224
URL: http://svn.apache.org/viewvc?rev=1189224&view=rev
Log:
Followup to deprecating the auth method names constants in
authenticator.Constants
Add Javadoc comment that points to replacements.
Replace use of the old constants wi
Author: kkolinko
Date: Wed Oct 26 13:19:13 2011
New Revision: 1189193
URL: http://svn.apache.org/viewvc?rev=1189193&view=rev
Log:
Align Clock2.java implementation with current trunk.
It covers revisions r1050653 (already in tc7.0.x), r1187755, r1189183.
Fixes Eclipse warnings in the class and trim
Author: kkolinko
Date: Wed Oct 26 13:08:35 2011
New Revision: 1189183
URL: http://svn.apache.org/viewvc?rev=1189183&view=rev
Log:
Align two copies of Clock2.java
/webapps/examples/jsp/plugin/applet/Clock2.java
/webapps/examples/WEB-INF/jsp/applet/Clock2.java
Just removes an empty line.
I am not s
2011/10/26 Mark Thomas :
> On 26/10/2011 11:51, Konstantin Kolinko wrote:
>> 2011/10/15 Mark Thomas :
>>> On 15/10/2011 11:02, Konstantin Kolinko wrote:
How do you run git? Do you use Cygwin, or maybe TortoiseGit?
>>>
>>> http://code.google.com/p/msysgit/downloads/list
>>>
I think http://
On 26/10/2011 13:41, Konstantin Kolinko wrote:
> 2011/10/23 :
>> Author: markt
>> Date: Sat Oct 22 23:24:31 2011
>> New Revision: 1187826
>>
>> URL: http://svn.apache.org/viewvc?rev=1187826&view=rev
>> Log:
>> Fix some low-hanging FindBugs fruit
>>
>> Modified:
>>tomcat/trunk/java/org/apache/t
On 26/10/2011 11:51, Konstantin Kolinko wrote:
> 2011/10/15 Mark Thomas :
>> On 15/10/2011 11:02, Konstantin Kolinko wrote:
>>> How do you run git? Do you use Cygwin, or maybe TortoiseGit?
>>
>> http://code.google.com/p/msysgit/downloads/list
>>
>>> I think http://wiki.apache.org/general/GitAtApach
2011/10/23 :
> Author: markt
> Date: Sat Oct 22 23:24:31 2011
> New Revision: 1187826
>
> URL: http://svn.apache.org/viewvc?rev=1187826&view=rev
> Log:
> Fix some low-hanging FindBugs fruit
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>
> tomcat/trunk/module
Author: kkolinko
Date: Wed Oct 26 12:19:26 2011
New Revision: 1189163
URL: http://svn.apache.org/viewvc?rev=1189163&view=rev
Log:
Remove trailing whitespace from bat, sh, res/tomcat.nsi and textual files in /,
/bin, /res
It is merge of revisions r1187805, r1187827 from tomcat/trunk,
but with exc
Author: kkolinko
Date: Wed Oct 26 11:57:37 2011
New Revision: 1189147
URL: http://svn.apache.org/viewvc?rev=1189147&view=rev
Log:
Merged revision 1187775 from tomcat/trunk:
Remove trailing whitespace from the files in /conf
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/
https://issues.apache.org/bugzilla/show_bug.cgi?id=52092
Bug #: 52092
Summary: Please make AsyncFileHandler and OneLineFormatter the
default for logging.properties
Product: Tomcat 7
Version: unspecified
Platform: All
Author: kkolinko
Date: Wed Oct 26 11:42:16 2011
New Revision: 1189140
URL: http://svn.apache.org/viewvc?rev=1189140&view=rev
Log:
Merged revision 1188301 from tomcat/trunk:
Ignore .git dir when building src distro (markt)
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/tr
https://issues.apache.org/bugzilla/show_bug.cgi?id=51744
Konstantin Kolinko changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|F
Author: kkolinko
Date: Wed Oct 26 10:58:56 2011
New Revision: 1189132
URL: http://svn.apache.org/viewvc?rev=1189132&view=rev
Log:
Merged revision 1189129 from tomcat/trunk:
Correct a typo
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/h
Author: kkolinko
Date: Wed Oct 26 10:57:36 2011
New Revision: 1189129
URL: http://svn.apache.org/viewvc?rev=1189129&view=rev
Log:
Correct a typo
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/mapper/TestMapperWelcomeFiles.java
Modified:
tomcat/trunk/test/org/apache/tomcat/util/htt
Author: kkolinko
Date: Wed Oct 26 10:54:20 2011
New Revision: 1189125
URL: http://svn.apache.org/viewvc?rev=1189125&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=11
Done in trunk and merged into 7.0.
Best regards,
Konstantin Kolinko
2011/10/26 Konstantin Kolinko :
> Can you add descriptive comment in the file itself and ASL license?
>
> 2011/10/26 :
>> Author: markt
>> Date: Tue Oct 25 21:34:21 2011
>> New Revision: 1188930
>>
>> URL: http://svn.apache.org/
2011/10/15 Mark Thomas :
> On 15/10/2011 11:02, Konstantin Kolinko wrote:
>> How do you run git? Do you use Cygwin, or maybe TortoiseGit?
>
> http://code.google.com/p/msysgit/downloads/list
>
>> I think http://wiki.apache.org/general/GitAtApache might need to be updated
>> to reflect the issue, but
https://issues.apache.org/bugzilla/show_bug.cgi?id=52091
--- Comment #1 from Taiki Sugawara 2011-10-26 10:41:29
UTC ---
Created attachment 27851
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27851
Reduce lock patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs
https://issues.apache.org/bugzilla/show_bug.cgi?id=52091
Bug #: 52091
Summary: TagHandlerPool is slow when high concurrently
Product: Tomcat 7
Version: 7.0.19
Platform: PC
OS/Version: Linux
Status: NEW
Severity:
Author: kkolinko
Date: Wed Oct 26 10:34:57 2011
New Revision: 1189118
URL: http://svn.apache.org/viewvc?rev=1189118&view=rev
Log:
Merged revisions 1188930, 1189116 from tomcat/trunk:
.gitignore files
r1188930:
Git ignores empty directories and the unit tests require this directory to be
present f
Author: kkolinko
Date: Wed Oct 26 10:30:11 2011
New Revision: 1189116
URL: http://svn.apache.org/viewvc?rev=1189116&view=rev
Log:
Followup to r1188930
Add license header to .gitignore
Added svn:eol-style=native
Modified:
tomcat/trunk/.gitignore (contents, props changed)
tomcat/trunk/tes
Author: markt
Date: Wed Oct 26 10:26:08 2011
New Revision: 1189115
URL: http://svn.apache.org/viewvc?rev=1189115&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1
https://issues.apache.org/bugzilla/show_bug.cgi?id=50570
--- Comment #20 from Mark Thomas 2011-10-26 09:33:44 UTC ---
Chris, did you put together an updated patch for this?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail becau
64 matches
Mail list logo
