To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test has an issue affecting its community integration.
This i
2012/1/10 Rainer Jung :
> I analyzed a fun problem a few weeks ago. Someone was using the shared
> loader extensively (TC 5.5). They observed performance problems and thread
> dumps showed, that often the class loader locking was the culprit.
>
> Code was inside loadClass(). Now it turned out, it w
https://issues.apache.org/bugzilla/show_bug.cgi?id=52448
Bug #: 52448
Summary: Cache jar indexes in WebappClassLoader to speed up
resources lookup
Product: Tomcat 7
Version: unspecified
Platform: PC
OS/Version: Win
Rainer,
On 1/10/12 5:37 PM, Rainer Jung wrote:
> It would matter if they take the reedom to return something new if
> loadClass() is called for a class that was already loaded - and
> something changed for the CL. For example a custom CL could check every
> now and then whether the classes have dy
Hi Chris,
On 10.01.2012 22:03, Christopher Schultz wrote:
Rainer,
On 1/10/12 5:43 AM, Rainer Jung wrote:
Now loadClass() in the WebappClasLoader does:
- check own class cache
- check super class cache
- try loading from system loader
- call Class.forName with parent loader (which calls loadCl
Add an archetype project sample
---
Key: MTOMCAT-114
URL: https://issues.apache.org/jira/browse/MTOMCAT-114
Project: Apache Tomcat Maven Plugin
Issue Type: Improvement
Reporter: Olivier Lamy
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #10 from Mark Thomas 2012-01-10 22:11:09 UTC ---
JSP and Servlet TCK pass for trunk (apart from the Servlet signature tests that
are expected to fail since some changes have already been made for Servlet
3.1).
I'll look at back
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #9 from Mark Thomas 2012-01-10 21:05:26 UTC ---
Unit tests now work on trunk. I'm just running the TCK before I look at
back-porting it.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
---
Rainer,
On 1/10/12 5:43 AM, Rainer Jung wrote:
> Now loadClass() in the WebappClasLoader does:
>
> - check own class cache
> - check super class cache
> - try loading from system loader
> - call Class.forName with parent loader (which calls loadClass() there)
> [only if "delegated", which is *n
Author: markt
Date: Tue Jan 10 21:03:15 2012
New Revision: 1229733
URL: http://svn.apache.org/viewvc?rev=1229733&view=rev
Log:
Whitespace and Javadoc fixes. No functional change.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/C2BConv
Author: markt
Date: Tue Jan 10 21:02:53 2012
New Revision: 1229731
URL: http://svn.apache.org/viewvc?rev=1229731&view=rev
Log:
Add test case
Added:
tomcat/trunk/test/org/apache/catalina/connector/TestOutputBuffer.java
Added: tomcat/trunk/test/org/apache/catalina/connector/TestOutputBuffer.ja
Author: markt
Date: Tue Jan 10 21:02:17 2012
New Revision: 1229730
URL: http://svn.apache.org/viewvc?rev=1229730&view=rev
Log:
Align spelling of message key
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java
tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.p
Author: markt
Date: Tue Jan 10 21:01:32 2012
New Revision: 1229729
URL: http://svn.apache.org/viewvc?rev=1229729&view=rev
Log:
Improve logging
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/C2BConverter.java
tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties
Mod
Author: markt
Date: Tue Jan 10 21:00:50 2012
New Revision: 1229728
URL: http://svn.apache.org/viewvc?rev=1229728&view=rev
Log:
Add a BufferedWriter to the Converter
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/C2BConverter.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/buf
Author: markt
Date: Tue Jan 10 21:00:10 2012
New Revision: 1229727
URL: http://svn.apache.org/viewvc?rev=1229727&view=rev
Log:
Additional flush required.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Outp
Author: markt
Date: Tue Jan 10 20:59:27 2012
New Revision: 1229726
URL: http://svn.apache.org/viewvc?rev=1229726&view=rev
Log:
First pass at a fix for BZ 52328
Modified:
tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
Modified: tomcat/trunk/java/org/apache/catalina/connecto
Author: markt
Date: Tue Jan 10 20:54:50 2012
New Revision: 1229724
URL: http://svn.apache.org/viewvc?rev=1229724&view=rev
Log:
Whitespace and Javadoc fixes. No functional change.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/C2BConverter.java
Modified: tomcat/trunk/java/org/apache/t
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #8 from Mark Thomas 2012-01-10 19:30:56 UTC ---
That initial patch is no good. It triggers a bunch of unit test failures. I am
working on an improved patch now.
--
Configure bugmail: https://issues.apache.org/bugzilla/userpref
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #7 from Mark Thomas 2012-01-10 18:00:37 UTC ---
If I insert a Buffer before the converter then the figures drop to:
20ms without wrapping
7ms with wrapping
Clearly the CoyoteWriter has some in-built overhead that adding a Buffe
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #6 from Mark Thomas 2012-01-10 16:19:31 UTC ---
Forgot to add the performance numbers for adding 100,000 single characters
through a Writer.
Before
129ms without wrapping the Writer in a BufferedWriter
37ms with wrapping the Wr
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #5 from Mark Thomas 2012-01-10 16:16:22 UTC ---
Created attachment 28132
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28132
Initial ideas
My initial idea (attached) was quite simple. There isn't the buffering I
th
On 10.01.2012 11:57, Konstantin Kolinko wrote:
2012/1/10 Rainer Jung:
On 10.01.2012 05:27, Konstantin Kolinko wrote:
2012/1/10 Konstantin Kolinko:
2012/1/9 Konstantin Kolinko:
2012/1/7 Rainer Jung:
Maybe enable the accesslog during testing with test.accesslog=true,
so one
can check afte
Author: rjung
Date: Tue Jan 10 14:42:38 2012
New Revision: 1229561
URL: http://svn.apache.org/viewvc?rev=1229561&view=rev
Log:
Move MBean dump code from JMXProxyServlet into
a utility class.
Use the new class to also dumps MBean info when
the TestRegistration unit test fails.
Backport of r122953
Author: rjung
Date: Tue Jan 10 14:36:06 2012
New Revision: 1229558
URL: http://svn.apache.org/viewvc?rev=1229558&view=rev
Log:
Remove some stale attributes from MBeans
and set one attribute to is="true".
Backport of r1229533 from trunk as far as it applies.
Modified:
tomcat/tc7.0.x/trunk/jav
Author: rjung
Date: Tue Jan 10 14:14:34 2012
New Revision: 1229549
URL: http://svn.apache.org/viewvc?rev=1229549&view=rev
Log:
Reduce code duplication introduced in r1229536:
Use common MBeanDumper class for JMXProxyServlet
and Mean unit tests.
Added:
tomcat/trunk/java/org/apache/catalina/mbe
Author: rjung
Date: Tue Jan 10 13:37:25 2012
New Revision: 1229536
URL: http://svn.apache.org/viewvc?rev=1229536&view=rev
Log:
Add output of MBean details to TestRegistration
in case unexpected MBeans were found.
Added:
tomcat/trunk/test/org/apache/catalina/mbeans/MBeanDumper.java (with pro
Author: rjung
Date: Tue Jan 10 13:32:38 2012
New Revision: 1229533
URL: http://svn.apache.org/viewvc?rev=1229533&view=rev
Log:
Remove some stale MBean attribute descriptions:
- compilerClasspath
- eventProvider
- mappingObject
- randomFile
- randomFileCurrent
- saveConfig
- staticResources
- stati
Author: olamy
Date: Tue Jan 10 13:27:11 2012
New Revision: 1229532
URL: http://svn.apache.org/viewvc?rev=1229532&view=rev
Log:
documentation on run mojo
Added:
tomcat/maven-plugin/trunk/src/site/apt/run-mojo-features.apt.vm (with
props)
Modified:
tomcat/maven-plugin/trunk/src/site/apt/
Author: olamy
Date: Tue Jan 10 13:27:01 2012
New Revision: 1229531
URL: http://svn.apache.org/viewvc?rev=1229531&view=rev
Log:
remove System.exit
Modified:
tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java
Modified:
tomcat/maven-pl
Author: olamy
Date: Tue Jan 10 13:26:49 2012
New Revision: 1229530
URL: http://svn.apache.org/viewvc?rev=1229530&view=rev
Log:
fix README regarding SNAPSHOT deployment and section on site deploy
Modified:
tomcat/maven-plugin/trunk/README.txt
Modified: tomcat/maven-plugin/trunk/README.txt
URL
Author: olamy
Date: Tue Jan 10 13:26:41 2012
New Revision: 1229529
URL: http://svn.apache.org/viewvc?rev=1229529&view=rev
Log:
fix trademark footer
Modified:
tomcat/maven-plugin/trunk/src/site/site.xml
Modified: tomcat/maven-plugin/trunk/src/site/site.xml
URL:
http://svn.apache.org/viewvc/t
Hello,
2012/1/10 Konstantin Kolinko :
> 2012/1/5 Olivier Lamy :
>> Hello,
>> I'd like to release a first version of Tomcat Maven Plugin.
>> As it's the first version here and some features have been added, this
>> version will be called 2.0-beta-1.
>>
>> I will do that early next week.
>>
>> Let m
2012/1/5 Olivier Lamy :
> Hello,
> I'd like to release a first version of Tomcat Maven Plugin.
> As it's the first version here and some features have been added, this
> version will be called 2.0-beta-1.
>
> I will do that early next week.
>
> Let me know if you have any comments.
>
1. IIRC you h
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #4 from Konstantin Kolinko 2012-01-10
11:21:03 UTC ---
(In reply to comment #3)
> the most efficient way to fix this is to remove the
> calls to conv.flush() after every write. The C2BConvertor already has a
> buffer,
> so let
On 10/01/2012 10:43, Rainer Jung wrote:
> I wonder whether we want to improve caching in the WebappLoader. Of
> course most deployments no longer use shared or common to share many
> application classes, but it is still a supported feature and for some
> classes like JDBC it is standard.
I think a
Author: olamy
Date: Tue Jan 10 11:10:10 2012
New Revision: 1229509
URL: http://svn.apache.org/viewvc?rev=1229509&view=rev
Log:
update doc with mojo available in 6 or/and 7
Modified:
tomcat/maven-plugin/trunk/src/site/apt/container-goals.apt
tomcat/maven-plugin/trunk/src/site/apt/context-g
Author: olamy
Date: Tue Jan 10 11:10:01 2012
New Revision: 1229508
URL: http://svn.apache.org/viewvc?rev=1229508&view=rev
Log:
add note on limitations for mojo not available with tomcat7 plugin
Modified:
tomcat/maven-plugin/trunk/src/site/apt/index.apt.vm
Modified: tomcat/maven-plugin/trunk/
Author: olamy
Date: Tue Jan 10 11:09:48 2012
New Revision: 1229507
URL: http://svn.apache.org/viewvc?rev=1229507&view=rev
Log:
add link to generated jira changelog from home page
Modified:
tomcat/maven-plugin/trunk/src/site/apt/index.apt.vm
Modified: tomcat/maven-plugin/trunk/src/site/apt/in
Author: olamy
Date: Tue Jan 10 11:09:37 2012
New Revision: 1229506
URL: http://svn.apache.org/viewvc?rev=1229506&view=rev
Log:
remove not needed repository
Modified:
tomcat/maven-plugin/trunk/pom.xml
Modified: tomcat/maven-plugin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-
Author: olamy
Date: Tue Jan 10 11:09:28 2012
New Revision: 1229505
URL: http://svn.apache.org/viewvc?rev=1229505&view=rev
Log:
add link to war/jar exec doc on the home page
Modified:
tomcat/maven-plugin/trunk/src/site/apt/executable-war-jar.apt.vm
tomcat/maven-plugin/trunk/src/site/apt/in
Author: olamy
Date: Tue Jan 10 11:09:19 2012
New Revision: 1229504
URL: http://svn.apache.org/viewvc?rev=1229504&view=rev
Log:
update documentation with new options available in jar exec cli
Modified:
tomcat/maven-plugin/trunk/src/site/apt/executable-war-jar.apt.vm
Modified: tomcat/maven-plu
2012/1/10 Rainer Jung :
> On 10.01.2012 05:27, Konstantin Kolinko wrote:
>>
>> 2012/1/10 Konstantin Kolinko:
>>>
>>> 2012/1/9 Konstantin Kolinko:
>>
>> 2012/1/7 Rainer Jung:
>>>
>>>
>>> Maybe enable the accesslog during testing with test.accesslog=true,
>>> so one
>>> ca
I analyzed a fun problem a few weeks ago. Someone was using the shared
loader extensively (TC 5.5). They observed performance problems and
thread dumps showed, that often the class loader locking was the culprit.
Code was inside loadClass(). Now it turned out, it wasn't about really
loading cl
https://issues.apache.org/bugzilla/show_bug.cgi?id=52328
--- Comment #3 from Mark Thomas 2012-01-10 10:38:46 UTC ---
Looking at this some more, I think we'll need to be careful around recycling,
resetting and flushing but the most efficient way to fix this is to remove the
calls to conv.flush() a
On 10.01.2012 05:27, Konstantin Kolinko wrote:
2012/1/10 Konstantin Kolinko:
2012/1/9 Konstantin Kolinko:
2012/1/7 Rainer Jung:
Maybe enable the accesslog during testing with test.accesslog=true, so one
can check after the next failure whether the contents agree with your
assumption. Not sure
https://issues.apache.org/bugzilla/show_bug.cgi?id=52440
--- Comment #2 from JustasR 2012-01-10 09:39:08
UTC ---
Created attachment 28130
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28130
Test case for ValueReference returning null
I use SystemEventListener event javax.faces.even
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181
--- Comment #25 from Pid 2012-01-10 09:35:09 UTC ---
> // WebSocket event processor
> public void event(WebSocketEvent event) throws IOException, ServletException
> {
> WebSocketServletRequest request = event.getHttpServletRequest(
47 matches
Mail list logo
