Re: svn commit: r1335700 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/

2012-06-03 Thread Konstantin Kolinko
2012/5/8 : > Author: markt > Date: Tue May  8 19:07:09 2012 > New Revision: 1335700 > > URL: http://svn.apache.org/viewvc?rev=1335700&view=rev > Log: > It appears that pausing requests for a Context during reload was relying on > the mapper not being cleaned up correctly. The Lifecycle refactorin

Re: svn commit: r1344253 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java webapps/docs/changelog.xml

2012-06-03 Thread Konstantin Kolinko
2012/5/30 : > Author: markt > Date: Wed May 30 13:35:55 2012 > New Revision: 1344253 > > URL: http://svn.apache.org/viewvc?rev=1344253&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53119 > Make sure the buffer is cleared on any error to prevent any possible overflow > i

Re: svn commit: r1344267 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/AbstractHttp11Processor.java test/org/apache/coyote/http11/TestAbstractHttp11Processor.java webapps/docs/changelog

2012-06-03 Thread Konstantin Kolinko
2012/5/30 : > Author: markt > Date: Wed May 30 14:13:47 2012 > New Revision: 1344267 > > URL: http://svn.apache.org/viewvc?rev=1344267&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53169 > Allow servlets to opt to avoid chunked encoding with a response of unknown > leng

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2012-06-03 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-03 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/6/3 : >> Author: markt >> Date: Sat Jun  2 21:18:53 2012 >> New Revision: 1345580 >> >> URL: http://svn.apache.org/viewvc?rev=1345580&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=5 >> Validate JNDI resource types against injecti

Re: svn commit: r1345580 - in /tomcat/trunk/java/org/apache/catalina/deploy: LocalStrings.properties NamingResources.java

2012-06-03 Thread Konstantin Kolinko
2012/6/3 : > Author: markt > Date: Sat Jun  2 21:18:53 2012 > New Revision: 1345580 > > URL: http://svn.apache.org/viewvc?rev=1345580&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=5 > Validate JNDI resource types against injection target types and use target > types

Re: svn commit: r1345367 - in /tomcat/trunk/java/org/apache/catalina: core/ startup/ util/

2012-06-03 Thread Konstantin Kolinko
2012/6/2 : > Author: markt > Date: Fri Jun  1 22:03:10 2012 > New Revision: 1345367 > > URL: http://svn.apache.org/viewvc?rev=1345367&view=rev > Log: > Refactor some duplicate code into an new utility class with an eye to the > proposed patch for BZ 5 > > Added: >    tomcat/trunk/java/org/apa

[Bug 52723] An incomplete fix for the resource leak bugs in StandardManager.java

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52723 --- Comment #4 from Konstantin Kolinko --- My comment 2 was wrong. I missed that the original code closes oos (which is always null there). It should have closed the file stream instead. oos constructor can throw IOException because it wr

[Bug 52723] An incomplete fix for the resource leak bugs in StandardManager.java

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52723 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53354] doesn't find the @WebFilter(filterName)

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53354 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: svn commit: r1345780 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/StreamInbound.java

2012-06-03 Thread Mark Thomas
On 03/06/2012 22:12, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sun Jun 3 21:12:40 2012 > New Revision: 1345780 > > URL: http://svn.apache.org/viewvc?rev=1345780&view=rev > Log: > Merged revision 1345779 from tomcat/trunk: > Review of r1345737: Correct copy-pasted comments to match the

svn commit: r1345782 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 21:18:26 2012 New Revision: 1345782 URL: http://svn.apache.org/viewvc?rev=1345782&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53354 Don't add empty filter mappings to the set of mappings - they'll fail validation Modified: tomcat/tc7.0.x

svn commit: r1345781 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 21:16:25 2012 New Revision: 1345781 URL: http://svn.apache.org/viewvc?rev=1345781&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53354 Don't add empty filter mappings to the set of mappings - they'll fail validation Modified: tomcat/trunk/j

svn commit: r1345780 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/StreamInbound.java

2012-06-03 Thread kkolinko
Author: kkolinko Date: Sun Jun 3 21:12:40 2012 New Revision: 1345780 URL: http://svn.apache.org/viewvc?rev=1345780&view=rev Log: Merged revision 1345779 from tomcat/trunk: Review of r1345737: Correct copy-pasted comments to match the method that is actually called there. Modified: tomcat/tc

svn commit: r1345779 - /tomcat/trunk/java/org/apache/catalina/websocket/StreamInbound.java

2012-06-03 Thread kkolinko
Author: kkolinko Date: Sun Jun 3 21:10:56 2012 New Revision: 1345779 URL: http://svn.apache.org/viewvc?rev=1345779&view=rev Log: Review of r1345737: Correct copy-pasted comments to match the method that is actually called there. Modified: tomcat/trunk/java/org/apache/catalina/websocket/Stre

buildbot failure in ASF Buildbot on tomcat-trunk

2012-06-03 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3029 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

buildbot success in ASF Buildbot on tomcat-trunk

2012-06-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3028 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: StuckThreadDetectionValve proposal in Tomcat 6 - GitHub link is dead

2012-06-03 Thread Mark Thomas
On 03/06/2012 20:59, Henri Gomez wrote: > Did you contact him ? > > Btw, it could allways happen with external contributions, not GitHub related. Which is why a patch attached to BZ should be the preferred approach. > Le 3 juin 2012 à 21:02, Konstantin Kolinko a écrit : > >> Hi! >> >> I was go

[Bug 53353] Malformed contentType attribute results in two charset values

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1345755 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/ webapps/docs/

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 20:04:08 2012 New Revision: 1345755 URL: http://svn.apache.org/viewvc?rev=1345755&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 Make the HTTP header parser for ContentType tolerant of invalid parameters with names but no values. The inva

svn commit: r1345754 - /tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstMediaType.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 20:03:30 2012 New Revision: 1345754 URL: http://svn.apache.org/viewvc?rev=1345754&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 Additional fix Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/AstMediaType.java Modified

Re: StuckThreadDetectionValve proposal in Tomcat 6 - GitHub link is dead

2012-06-03 Thread Henri Gomez
Did you contact him ? Btw, it could allways happen with external contributions, not GitHub related. Le 3 juin 2012 à 21:02, Konstantin Kolinko a écrit : > Hi! > > I was going to take another look at this old proposal in Tomcat 6: > * Add StuckThreadDetectionValve > > https://github.com/sylv

svn commit: r1345752 - in /tomcat/trunk: java/org/apache/tomcat/util/http/parser/ test/org/apache/tomcat/util/http/parser/

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 19:55:33 2012 New Revision: 1345752 URL: http://svn.apache.org/viewvc?rev=1345752&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 Make the HTTP header parser for ContentType tolerant of invalid parameters with names but no values. The inva

[Bug 53353] Malformed contentType attribute results in two charset values

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 --- Comment #2 from Mark Thomas --- At one level, this is just a case of "garbage in, garbage out" with current 7.0.x producing different garbage that 6.0.x for the same input. Granted, the 7.0.x garbage is likely to cause more problems for

svn commit: r1345745 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/http/parser/TestMediaType.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 19:19:52 2012 New Revision: 1345745 URL: http://svn.apache.org/viewvc?rev=1345745&view=rev Log: Add quotes that were missed - tests still pass Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/parser/Tes

svn commit: r1345744 - /tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestMediaType.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 19:16:51 2012 New Revision: 1345744 URL: http://svn.apache.org/viewvc?rev=1345744&view=rev Log: Add quotes that were missed - tests still pass Modified: tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestMediaType.java Modified: tomcat/trunk/test/org/apa

[Bug 53354] New: doesn't find the @WebFilter(filterName)

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53354 Priority: P2 Bug ID: 53354 Assignee: dev@tomcat.apache.org Summary: doesn't find the @WebFilter(filterName) Severity: normal Classification: Unclassified

StuckThreadDetectionValve proposal in Tomcat 6 - GitHub link is dead

2012-06-03 Thread Konstantin Kolinko
Hi! I was going to take another look at this old proposal in Tomcat 6: * Add StuckThreadDetectionValve https://github.com/sylvainlaurent/tomcat60/commit/252334f958877221ecb2dc64ee0fd12bb77e360b +1: slaurent The GitHub link is dead - there is no "tomcat60" repository in Sylvain's account. I

[Bug 53339] ClassNotFoundException when using WebSocketServlet

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53339 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1345739 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/StreamInbound.java test/org/apache/catalina/websocket/TestWebSocket.java webapps/docs/changelog.xml

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 18:50:48 2012 New Revision: 1345739 URL: http://svn.apache.org/viewvc?rev=1345739&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53339 Ensure WebSocket event calls are made using the web application's class loader. Includes a test case. Modifi

svn commit: r1345738 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/websocket/TestWebSocket.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 18:48:34 2012 New Revision: 1345738 URL: http://svn.apache.org/viewvc?rev=1345738&view=rev Log: Refactor - no functional change Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/websocket/TestWebSocket.java Prop

svn commit: r1345737 - in /tomcat/trunk: java/org/apache/catalina/websocket/StreamInbound.java test/org/apache/catalina/websocket/TestWebSocket.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 18:47:25 2012 New Revision: 1345737 URL: http://svn.apache.org/viewvc?rev=1345737&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53339 Ensure WebSocket event calls are made using the web application's class loader. Includes a test case. Modifi

[Tomcat Wiki] Update of "FAQ/CharacterEncoding" by KonstantinKolinko

2012-06-03 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/CharacterEncoding" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/FAQ/CharacterEncoding?action=diff&rev1=20&rev2=21 Comment: Note that JSP documents

svn commit: r1345732 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 18:14:20 2012 New Revision: 1345732 URL: http://svn.apache.org/viewvc?rev=1345732&view=rev Log: More refactoring - no functional change Modified: tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java Modified: tomcat/trunk/test/org/apache/catalina/

svn commit: r1345731 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 18:11:29 2012 New Revision: 1345731 URL: http://svn.apache.org/viewvc?rev=1345731&view=rev Log: Refactor - no functional change Modified: tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java Modified: tomcat/trunk/test/org/apache/catalina/websocke

[Bug 53353] Malformed contentType attribute results in two charset values

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 --- Comment #1 from Konstantin Kolinko --- > With current Tomcat 7.0 (7.0.23) I meant 7.0.27. The issue is reproducible with 7.0.27 release and with current trunk of 7.0.x. -- You are receiving this mail because: You are the assignee for

[Bug 53353] New: Malformed contentType attribute results in two charset values

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53353 Priority: P2 Bug ID: 53353 Assignee: dev@tomcat.apache.org Summary: Malformed contentType attribute results in two charset values Severity: normal Classification: U

[Bug 53008] New test case for Basic Authenticator

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53008 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1345708 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java webapps/docs/changelog.xml

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:47:16 2012 New Revision: 1345708 URL: http://svn.apache.org/viewvc?rev=1345708&view=rev Log: Extend test cases for BASIC auth and RFC2617 compliance. Patch provided by Brian Burch. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/te

svn commit: r1345705 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/websocket/WsInputStream.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:45:26 2012 New Revision: 1345705 URL: http://svn.apache.org/viewvc?rev=1345705&view=rev Log: Fix typo Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/websocket/WsInputStream.java Propchange: tomcat/tc7.0.x/

svn commit: r1345704 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:44:49 2012 New Revision: 1345704 URL: http://svn.apache.org/viewvc?rev=1345704&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53008 Extend test cases for BASIC auth and RFC2617 compliance Modified: tomcat/trunk/test/org/apache/catalina/

[Bug 53096] New test cases for TestDigestAuthenticator

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53096 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1345699 - /tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:29:30 2012 New Revision: 1345699 URL: http://svn.apache.org/viewvc?rev=1345699&view=rev Log: Fix typo Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java Modified: tomcat/trunk/java/org/apache/catalina/websocket/WsInputStream.java UR

svn commit: r680 - /release/tomcat/tomcat-7/v7.0.26/

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:22:35 2012 New Revision: 680 Log: Remove old version from mirrors Removed: release/tomcat/tomcat-7/v7.0.26/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional comman

svn commit: r680 - /release/tomcat/tomcat-7/v7.0.26/

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 16:22:35 2012 New Revision: 680 Log: Remove old version from mirrors Removed: release/tomcat/tomcat-7/v7.0.26/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional comman

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53337] IllegalStateException when trying to render a JSP after startAsync

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53337 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1345689 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationDispatcher.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 15:54:28 2012 New Revision: 1345689 URL: http://svn.apache.org/viewvc?rev=1345689&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53337 Fix RequestDispatcher.forward() to an async servlet. Includes a test case based on code by Rossen Stoyanchev.

svn commit: r1345688 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationDispatcher.java test/org/apache/catalina/core/TestAsyncContextImpl.java

2012-06-03 Thread markt
Author: markt Date: Sun Jun 3 15:50:50 2012 New Revision: 1345688 URL: http://svn.apache.org/viewvc?rev=1345688&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53337 Fix RequestDispatcher.forward() to an async servlet Modified: tomcat/trunk/java/org/apache/catalina/core/

[Bug 53333] NPE is thrown for env-entry without env-entry-type but with injection-target specified

2012-06-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=5 --- Comment #4 from Violeta Georgieva --- Thanks -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomc

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-06-03 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

Bug report for Tomcat Native [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2012/06/03]

2012-06-03 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned