Re: Could anybody give me some reference about how Tomcat handle the default servlet

2012-06-12 Thread Konstantin Kolinko
2012/6/13 Zhi Xie : > If I deploy a war with a web.xml like this. > > >  xmlns="http://java.sun.com/xml/ns/j2ee"; xmlns:xsi=" > http://www.w3.org/2001/XMLSchema-instance"; >  xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee > http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd";> >  Test WAR > >  

[Bug 53406] New: Stack overflow in connector

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53406 Priority: P2 Bug ID: 53406 Assignee: dev@tomcat.apache.org Summary: Stack overflow in connector Severity: normal Classification: Unclassified Reporter: fha...@apache.org

"WARNING: Incorrect connection count" when running testsuite for APR/native 1.1.24

2012-06-12 Thread Konstantin Kolinko
Hi! I run the testsuite for Tomcat trunk with APR connector with release candidate for Tomcat Native 1.1.24, on WinXP 32-bit. The testsuite passes successfully, but looking closer into log files I see many occurrences of the following warning: 12.06.2012 21:13:43 org.apache.tomcat.util.net.Abstr

Could anybody give me some reference about how Tomcat handle the default servlet

2012-06-12 Thread Zhi Xie
If I deploy a war with a web.xml like this. http://java.sun.com/xml/ns/j2ee"; xmlns:xsi=" http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd";> Test WAR default /images/* I want to

svn commit: r1349574 - in /tomcat/tc7.0.x/trunk: ./ webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 22:41:39 2012 New Revision: 1349574 URL: http://svn.apache.org/viewvc?rev=1349574&view=rev Log: Merged revision 1349539 from tomcat/trunk: For https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Review of r1349477: use more simple code when converting a list

svn commit: r1349539 - /tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionFilter.java

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 21:19:50 2012 New Revision: 1349539 URL: http://svn.apache.org/viewvc?rev=1349539&view=rev Log: For https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Review of r1349477: use more simple code when converting a list of mime types into array and ignore empty

svn commit: r1349529 - /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-webapp-it/pom.xml

2012-06-12 Thread olamy
Author: olamy Date: Tue Jun 12 21:10:59 2012 New Revision: 1349529 URL: http://svn.apache.org/viewvc?rev=1349529&view=rev Log: last selenium version in the archetype Modified: tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/basic-webapp-it/pom.xml Mod

svn commit: r1349528 - /tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-resources/pom.xml

2012-06-12 Thread olamy
Author: olamy Date: Tue Jun 12 21:10:46 2012 New Revision: 1349528 URL: http://svn.apache.org/viewvc?rev=1349528&view=rev Log: upgrade maven compiler plugin to 2.5.1 (more performant) in the archetype Modified: tomcat/maven-plugin/trunk/tomcat-maven-archetype/src/main/resources/archetype-res

svn commit: r687 - /release/tomcat/tomcat-connectors/jk/README.html

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 20:57:06 2012 New Revision: 687 Log: Align with r1348979 and set svn:eol-style=native Make verification text consistent across all components Modified: release/tomcat/tomcat-connectors/jk/README.html (contents, props changed) Modified: release/tomcat/tomca

svn commit: r687 - /release/tomcat/tomcat-connectors/jk/README.html

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 20:57:06 2012 New Revision: 687 Log: Align with r1348979 and set svn:eol-style=native Make verification text consistent across all components Modified: release/tomcat/tomcat-connectors/jk/README.html (contents, props changed) Modified: release/tomcat/tomca

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #9 from Michael Osipov <1983-01...@gmx.net> --- (In reply to comment #8) > (In reply to comment #4) > > Putting this caveat in the bug and not just on the dev list: > > I agree with Mark here. > The change in r1348762 is in the

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #8 from Konstantin Kolinko --- (In reply to comment #4) > Putting this caveat in the bug and not just on the dev list: I agree with Mark here. The change in r1348762 is in the place where ErrorReportValve prepares HTML text of

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #7 from Konstantin Kolinko --- Created attachment 28921 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28921&action=edit Screen shot from Tomcat trunk The same with Tomcat trunk after implementing the feature. --

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #6 from Konstantin Kolinko --- Created attachment 28920 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28920&action=edit Screen shot from Tomcat 7.0.27 Just a screen shot, for comparison. It is before implementing t

Re: svn commit: r1349473 - in /tomcat/trunk/webapps/examples/WEB-INF: ./ classes/compressionFilters/

2012-06-12 Thread Konstantin Kolinko
2012/6/12 : > Author: markt > Date: Tue Jun 12 18:57:00 2012 > New Revision: 1349473 > > URL: http://svn.apache.org/viewvc?rev=1349473&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 > Various improvements to the compression filter example. > Patch by David Becker >

[Bug 50182] Contributing back enhancements to CompressionFilter

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1349477 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/ webapps/examples/WEB-INF/ webapps/examples/WEB-INF/classes/compressionFilters/

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 19:07:39 2012 New Revision: 1349477 URL: http://svn.apache.org/viewvc?rev=1349477&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Various improvements to the compression filter example. Patch by David Becker Modified: tomcat/tc7.0.x/tr

svn commit: r1349475 - /tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionServletResponseWrapper.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 19:05:32 2012 New Revision: 1349475 URL: http://svn.apache.org/viewvc?rev=1349475&view=rev Log: Drop info Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/compressionFilters/CompressionServletResponseWrapper.java Modified: tomcat/trunk/webapps/examples

svn commit: r1349473 - in /tomcat/trunk/webapps/examples/WEB-INF: ./ classes/compressionFilters/

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 18:57:00 2012 New Revision: 1349473 URL: http://svn.apache.org/viewvc?rev=1349473&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50182 Various improvements to the compression filter example. Patch by David Becker Modified: tomcat/trunk/web

Re: Time for 7.0.28?

2012-06-12 Thread markt
Mladen Turk wrote: >On 06/12/2012 06:53 PM, Filip Hanik (mailing lists) wrote: >> Over 2 months since last release >> >> Got some critical fixes that I would like to see released >> - max connections broken >> - send file in nio broken >> - jdbc pool can hang during DB failure >> > >Sure, w

RE: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1349439 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java session/StandardSession.java

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 16:58:38 2012 New Revision: 1349439 URL: http://svn.apache.org/viewvc?rev=1349439&view=rev Log: Review of Context.getApplicationLifecycleListeners() calls: Do less work if there are no listeners or 'notify' flag is false. I do not expect much effect from this chan

Re: Time for 7.0.28?

2012-06-12 Thread Mladen Turk
On 06/12/2012 06:53 PM, Filip Hanik (mailing lists) wrote: Over 2 months since last release Got some critical fixes that I would like to see released - max connections broken - send file in nio broken - jdbc pool can hang during DB failure Sure, we need native 1.1.24 for Mark's WebSocke

Time for 7.0.28?

2012-06-12 Thread Filip Hanik (mailing lists)
Over 2 months since last release Got some critical fixes that I would like to see released - max connections broken - send file in nio broken - jdbc pool can hang during DB failure Filip - To unsubscribe, e-mail: dev-unsubsc

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Rainer Jung
On 12.06.2012 17:39, Mladen Turk wrote: On 06/12/2012 03:19 PM, Rainer Jung wrote: I implemented those for Solaris long ago and thought they existed for Linux from the beginning. But in fact for Linux there are only memory Thanks for such a thorough review! Happy to not get flamed :) Coul

svn commit: r1349425 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 16:31:31 2012 New Revision: 1349425 URL: http://svn.apache.org/viewvc?rev=1349425&view=rev Log: Merged revision 1349410 from tomcat/trunk: Review of r1349300: Make ReadWriteLock fields final (the new one and an old private one as well). Modified: tomcat/tc7.0

svn commit: r1349410 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2012-06-12 Thread kkolinko
Author: kkolinko Date: Tue Jun 12 16:02:44 2012 New Revision: 1349410 URL: http://svn.apache.org/viewvc?rev=1349410&view=rev Log: Review of r1349300: Make ReadWriteLock fields final (the new one and an old private one as well). Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBas

[Bug 53403] New: Reference to 2.2/2.3 servlet container in Tomcat 7 docs

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53403 Priority: P2 Bug ID: 53403 Assignee: dev@tomcat.apache.org Summary: Reference to 2.2/2.3 servlet container in Tomcat 7 docs Severity: trivial Classification: Unclas

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Mladen Turk
On 06/11/2012 02:54 PM, Mladen Turk wrote: The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.24 is [X] Stable, go ahead and release [ ] Broken because of ... Cast my vote. Regards -- ^TM

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Mladen Turk
On 06/12/2012 03:19 PM, Rainer Jung wrote: I implemented those for Solaris long ago and thought they existed for Linux from the beginning. But in fact for Linux there are only memory Thanks for such a thorough review! Could you add some of your thoughts into trunk's README Just add TODO

[Bug 48600] Performance issue with tags

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48600 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2012-06-12 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=52&rev2=53 angosso angosso\.com angosso\.net + \.a

[Bug 52954] Allowing for broken android HTTP DIGEST support

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52954 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1349321 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/DigestAuthenticator.java webapps/docs/changelog.xml

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 13:26:10 2012 New Revision: 1349321 URL: http://svn.apache.org/viewvc?rev=1349321&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52954 Be tolerant of slightly broken Android implementation of DIGEST auth. Security is not impacted. Modified:

svn commit: r1349317 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 13:23:53 2012 New Revision: 1349317 URL: http://svn.apache.org/viewvc?rev=1349317&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52954 Be tolerant of slightly broken Android implementation of DIGEST auth. Security is not impacted. Modified:

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Rainer Jung
On 11.06.2012 14:54, Mladen Turk wrote: Version 1.1.24 is feature-add release containing additional API to set per-socket timeouts inside Poller. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2012-06-12 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=51&rev2=52 mamaiacazare masterjin\.com mathsolutions\

[Bug 52999] Performance issue with locking in ContainerBase.fireContainerEvent()

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52999 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1349300 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java webapps/docs/changelog.xml

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 12:40:00 2012 New Revision: 1349300 URL: http://svn.apache.org/viewvc?rev=1349300&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52999 Remove synchronization bottleneck in container event handling Modified: tomcat/tc7.0.x/trunk/ (props ch

svn commit: r1349298 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 12:38:20 2012 New Revision: 1349298 URL: http://svn.apache.org/viewvc?rev=1349298&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52999 Remove synchronization bottleneck in container event handling Modified: tomcat/trunk/java/org/apache/cata

svn commit: r1349282 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-post-7.0.x-fixes.xml

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 12:01:43 2012 New Revision: 1349282 URL: http://svn.apache.org/viewvc?rev=1349282&view=rev Log: Refactoring has been completed in fix for BZ 48870 Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-post-7.0.x-fixes.xml Modified: tomcat/tc7.0.x/trunk/res/findbug

svn commit: r1349281 - /tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 12:01:21 2012 New Revision: 1349281 URL: http://svn.apache.org/viewvc?rev=1349281&view=rev Log: Refactoring has been completed in fix for BZ 48870 Modified: tomcat/trunk/res/findbugs/filter-post-7.0.x-fixes.xml Modified: tomcat/trunk/res/findbugs/filter-post-7.

svn commit: r1349263 - in /tomcat/trunk/java/org/apache: catalina/realm/RealmBase.java tomcat/spdy/NetSupportOpenSSL.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 11:26:51 2012 New Revision: 1349263 URL: http://svn.apache.org/viewvc?rev=1349263&view=rev Log: Remove unused code (FindBugs) Modified: tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java tomcat/trunk/java/org/apache/tomcat/spdy/NetSupportOpenSSL.java

[Bug 53401] Request objects use too much memory!

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53401 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1349239 - /tomcat/trunk/java/org/apache/catalina/util/DateTool.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 10:36:58 2012 New Revision: 1349239 URL: http://svn.apache.org/viewvc?rev=1349239&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/util/DateTool.java Modified: tomcat/trunk/java/org/apache/catalina/util/DateTool.java URL: http:/

svn commit: r1349238 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ssi/SSIFlastmod.java java/org/apache/catalina/ssi/SSIMediator.java java/org/apache/catalina/util/DateTool.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 10:36:37 2012 New Revision: 1349238 URL: http://svn.apache.org/viewvc?rev=1349238&view=rev Log: Deprecate pointless constant Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/ssi/SSIFlastmod.java tomcat/tc7.0

svn commit: r1349237 - in /tomcat/trunk/java/org/apache/catalina: ssi/SSIFlastmod.java ssi/SSIMediator.java util/DateTool.java

2012-06-12 Thread markt
Author: markt Date: Tue Jun 12 10:35:26 2012 New Revision: 1349237 URL: http://svn.apache.org/viewvc?rev=1349237&view=rev Log: Deprecate pointless constant Modified: tomcat/trunk/java/org/apache/catalina/ssi/SSIFlastmod.java tomcat/trunk/java/org/apache/catalina/ssi/SSIMediator.java t

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #10 from Mark Thomas --- Glad to hear that all is OK. It wasn't a waste of time - the new test cases I wrote for Comet are good to have. -- You are receiving this mail because: You are the assignee for the bug. --