Re: svn commit: r1372242 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread Mark Thomas
On 13/08/2012 03:20, kkoli...@apache.org wrote: Author: kkolinko Date: Mon Aug 13 02:20:18 2012 New Revision: 1372242 URL: http://svn.apache.org/viewvc?rev=1372242view=rev Log: veto. It concerns current Tomcat 7 code (r1370537) as well. Fair point. I'll get trunk / 7.0.x fixed and update

svn commit: r1372390 - in /tomcat/trunk/java/org/apache/catalina/authenticator: FormAuthenticator.java SavedRequest.java

2012-08-13 Thread markt
Author: markt Date: Mon Aug 13 12:25:57 2012 New Revision: 1372390 URL: http://svn.apache.org/viewvc?rev=1372390view=rev Log: Additional fix for http://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Store decoded and original request URI. Restore both. Use decoded for matching. Modified:

svn commit: r1372394 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/authenticator/SavedRequest.java

2012-08-13 Thread markt
Author: markt Date: Mon Aug 13 12:29:51 2012 New Revision: 1372394 URL: http://svn.apache.org/viewvc?rev=1372394view=rev Log: Additional fix for http://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Store decoded and original request URI. Restore both. Use decoded for matching. Modified:

svn commit: r1372392 - /tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java

2012-08-13 Thread markt
Author: markt Date: Mon Aug 13 12:29:26 2012 New Revision: 1372392 URL: http://svn.apache.org/viewvc?rev=1372392view=rev Log: Fix indent Modified: tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java Modified:

svn commit: r1372397 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread markt
Author: markt Date: Mon Aug 13 12:32:03 2012 New Revision: 1372397 URL: http://svn.apache.org/viewvc?rev=1372397view=rev Log: Update proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

RE: Possible IIS SPDY Redirector for Tomcat

2012-08-13 Thread Konstantin Preißer
Hello Costin all, -Original Message- From: Costin Manolache [mailto:cos...@gmail.com] Sent: Tuesday, May 29, 2012 9:09 AM To: Tomcat Developers List Subject: Re: Possible IIS SPDY Redirector for Tomcat I'm working on a 3 implementation for tomcat - the hard part is the flow

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-08-13 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community

svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread kkolinko
Author: kkolinko Date: Mon Aug 13 13:06:43 2012 New Revision: 1372415 URL: http://svn.apache.org/viewvc?rev=1372415view=rev Log: Change votes where my concerns were addressed. Add formatting fix to schultz's proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified:

[Bug 53633] Scope of Realm expanded when using SSO

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53633 --- Comment #2 from Dennis Verbeek dverb...@hotmail.com --- (In reply to comment #1) As per the docs, if you use SSO all contexts must use the same Realm. The behaviour is undefined if you don't follow that requirement. Looking back at

[Bug 44284] Support java.lang.Iterable in c:forEach tag

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44284 --- Comment #2 from Christopher Schultz ch...@christopherschultz.net --- The JSTL spec requires that items that are of type array, java.util.Collection, java.util.Iterator, java.util.Enumeration, java.util.Map, and String be supported by

[Bug 46263] Tomcat reloading of context.xml does not update docBase

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46263 --- Comment #4 from Christopher Schultz ch...@christopherschultz.net --- If you want to re-name the context AND install a new copy of it, why not just deploy a completely new copy of the webapp on the new context path, then undeploy the old

Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
All, Recently, I have made a proposal or to to back-port changes into Tomcat 6. In one case, Konstantin has (helpfully!) provided a new patch based upon several changes to trunk/TC7. In this case, is it more appropriate to apply the single patch to TC6 and ignore those patches made to trunk, or

Re: svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 9:06 AM, kkoli...@apache.org wrote: Author: kkolinko @@ -178,12 +161,14 @@ PATCHES PROPOSED TO BACKPORT: Patch from 7.0.x should apply relatively cleanly, as it is very small: http://svn.apache.org/viewvc?view=revisionrevision=1041892 +1: schultz - -1:

Re: svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread Konstantin Kolinko
2012/8/13 Christopher Schultz Can I ask why the use of HashSetString rather than SetString is a problem? I intentionally used the implementation class instead of an interface for a (small) performance improvement. I'm happy to patch trunk/7.0.x/6.0.x to fix this if you feel that it is

Re: Back-porting versus brand-new patch

2012-08-13 Thread Konstantin Kolinko
2012/8/13 Christopher Schultz ch...@christopherschultz.net: All, Recently, I have made a proposal or to to back-port changes into Tomcat 6. In one case, Konstantin has (helpfully!) provided a new patch based upon several changes to trunk/TC7. In this case, is it more appropriate to apply

[Bug 53712] New: localvariabletable length error reintroduced?

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53712 Priority: P2 Bug ID: 53712 Assignee: dev@tomcat.apache.org Summary: localvariabletable length error reintroduced? Severity: normal Classification: Unclassified OS:

[Bug 53712] localvariabletable length error reintroduced?

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53712 Colin Mac apa...@macallister.net changed: What|Removed |Added CC|

[Bug 53712] localvariabletable length error reintroduced?

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53712 Colin Mac apa...@macallister.net changed: What|Removed |Added CC|apa...@macallister.net | -- You are

[Bug 53712] localvariabletable length error reintroduced?

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53712 --- Comment #1 from Colin Mac apa...@macallister.net --- (In reply to comment #0) I should note I'm running Tomcat 5.5.35. When reading a large jsp file, get the error shown at bottom. It seems this was an error that occurred in a past

Re: Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 3:26 PM, Konstantin Kolinko wrote: Regarding size of a patch: It is up to you. You do it in your own name. The lesser the patch the lesser are chances to screw it. But if you feel that something needs to be included as well, feel free to include it.

[Bug 53712] localvariabletable length error reintroduced?

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53712 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- 1. org/apache/jsp/cbs/views/eventb/form_jsp java.lang.ClassFormatError: LocalVariableTable has wrong length in class file org/apache/jsp/cbs/views/eventb/form_jsp at

Re: Back-porting versus brand-new patch

2012-08-13 Thread Konstantin Kolinko
2012/8/14 Christopher Schultz ch...@christopherschultz.net: 2. The svn patch command does not update mergeinfo, but mergeinfo can be updated explicitly by doing a svn merge --record-only. Understood. I almost never do 'svn patch' but instead do 'svn merge'. I didn't know that one could

[Bug 53633] Scope of Realm expanded when using SSO

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53633 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to comment #2) 2 - Create a separate Service/Connector/Engine/Host/Realm for the manager webapp. 2 is a limited workaround, because the Manager webapp manages

[Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2012-08-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #17 from Christopher Schultz ch...@christopherschultz.net --- Created attachment 29222 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29222action=edit Patch for Tomcat 6.0 This patch is an amalgamation of the

svn commit: r1372691 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread schultz
Author: schultz Date: Tue Aug 14 00:56:33 2012 New Revision: 1372691 URL: http://svn.apache.org/viewvc?rev=1372691view=rev Log: Updated proposal. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: