svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 11:11:23 2013 New Revision: 1501719 URL: http://svn.apache.org/r1501719 Log: javax.el.ResourceBundleELResolver: According to javadoc: 1. When creating FeatureDescriptors shortDescription must be empty string 2. isReadOnly returns true only if the base is

[Bug 55220] Tomcat adding trailing slash when directory exists

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55220 --- Comment #4 from Mark Thomas ma...@apache.org --- (In reply to japgolly from comment #3) My servlet is mapped to /* so shouldn't that pickup /foo? It depends what other mappings are present. The mapping rules are set out in section 12

Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread Mark Thomas
On 10/07/2013 12:11, violet...@apache.org wrote: Author: violetagg Date: Wed Jul 10 11:11:23 2013 New Revision: 1501719 URL: http://svn.apache.org/r1501719 Log: javax.el.ResourceBundleELResolver: According to javadoc: 1. When creating FeatureDescriptors shortDescription must be empty

svn commit: r1501732 - in /tomcat/trunk: java/org/apache/jasper/compiler/JspConfig.java webapps/docs/web-socket-howto.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 11:46:04 2013 New Revision: 1501732 URL: http://svn.apache.org/r1501732 Log: Whoops. Fix JSPs for apps that don't have a JSP config descriptor element in their web.xml. Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java

svn commit: r1501738 - /tomcat/trunk/webapps/docs/logging.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 11:53:43 2013 New Revision: 1501738 URL: http://svn.apache.org/r1501738 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55215 Remove unnecessary period at the end of file names Use space around = in properties consistently. Based on a patch by Brian

[Bug 55215] Improvements to sample log4j configuration

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55215 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 55228] AbstractHttp11Processor overwrites Date header, even when set by application

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55228 --- Comment #2 from Mark Thomas ma...@apache.org --- If a bug affects multiple versions open an issue (as you have done) against the earliest supported version you want to see the fix in. Fixes are applied to trunk and then back-ported

Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread Violeta Georgieva
2013/7/10 Mark Thomas wrote: On 10/07/2013 12:11, violet...@apache.org wrote: Author: violetagg Date: Wed Jul 10 11:11:23 2013 New Revision: 1501719 URL: http://svn.apache.org/r1501719 Log: javax.el.ResourceBundleELResolver: According to javadoc: 1. When creating

Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread Mark Thomas
On 10/07/2013 13:00, Violeta Georgieva wrote: 2013/7/10 Mark Thomas wrote: On 10/07/2013 12:11, violet...@apache.org wrote: Author: violetagg Date: Wed Jul 10 11:11:23 2013 New Revision: 1501719 URL: http://svn.apache.org/r1501719 Log: javax.el.ResourceBundleELResolver: According to

[Bug 55228] AbstractHttp11Processor overwrites Date header, even when set by application

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55228 --- Comment #3 from Mark Thomas ma...@apache.org --- I'm currently leaning to resolving this as invalid. As an origin server, Tomcat is required by RFc2616 to set the date header (using the current time) on every request. I'd be prepared

Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread Violeta Georgieva
2013/7/10 Mark Thomas wrote: No. Firstly because if is not exclusive. Secondly because the remainder of the returns definition states that the return value is undefined if propertyResolved is false. Another way of looking at it is that there is no language that requires a return value of

svn commit: r1501761 - in /tomcat/tc7.0.x/trunk: java/org/apache/naming/resources/DirContextURLConnection.java webapps/docs/changelog.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 13:21:39 2013 New Revision: 1501761 URL: http://svn.apache.org/r1501761 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55230 Use the correct resource path when obtaining an InputStream for resources served by a ProxyDirContext. Modified:

[Bug 55230] DirContextURLConnection.getInputStream() fails to reopen resources for ProxyDirContext

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55230 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 55231] NPE and incorrect version detection in JspC

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55231 --- Comment #2 from Mark Thomas ma...@apache.org --- Large patches that address multiple issues are hard to review and won't get applied. One patch should address one issue. -- You are receiving this mail because: You are the assignee for

svn commit: r1501763 - /tomcat/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 13:30:02 2013 New Revision: 1501763 URL: http://svn.apache.org/r1501763 Log: Whoops. Fix JSPs with TLDs for apps that don't have a JSP config descriptor element in their web.xml. Modified: tomcat/trunk/java/org/apache/jasper/compiler/TldLocationsCache.java

[Bug 55231] NPE and incorrect version detection in JspC

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55231 --- Comment #3 from Mark Thomas ma...@apache.org --- I'd already spotted one NPE and have fixed another case highlighted by the patch. I'll look at version detection next. -- You are receiving this mail because: You are the assignee for

Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java

2013-07-10 Thread Mark Thomas
On 10/07/2013 14:09, Violeta Georgieva wrote: 2013/7/10 Mark Thomas wrote: No. Firstly because if is not exclusive. Secondly because the remainder of the returns definition states that the return value is undefined if propertyResolved is false. Another way of looking at it is that there is

svn commit: r1501764 - /tomcat/trunk/test/org/apache/jasper/servlet/TestJspCServletContext.java

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 13:36:46 2013 New Revision: 1501764 URL: http://svn.apache.org/r1501764 Log: There is a 2.2 webapp now as well. Based on a patch by Jermey Boynes. Modified: tomcat/trunk/test/org/apache/jasper/servlet/TestJspCServletContext.java Modified:

svn commit: r1501765 - /tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 13:40:32 2013 New Revision: 1501765 URL: http://svn.apache.org/r1501765 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55231 JSP capability should be based on effective version of webapp. Modified:

[Bug 55231] NPE and incorrect version detection in JspC

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55231 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

javax.el.ListELResolver.isReadOnly

2013-07-10 Thread Violeta Georgieva
Hi, In the javadoc it is not described that the method throws IAE when the property cannot be coerced into an integer. Moreover it is specified that the property will be ignored by the resolver: property - The index of the element in the list to return the acceptable type for. Will be coerced

Re: javax.el.ListELResolver.isReadOnly

2013-07-10 Thread Konstantin Kolinko
2013/7/10 Violeta Georgieva miles...@gmail.com: Hi, In the javadoc it is not described that the method throws IAE when the property cannot be coerced into an integer. Moreover it is specified that the property will be ignored by the resolver: property - The index of the element in the

[Bug 55233] New: [websocket] Problem reading many subsequent binary messages

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55233 Bug ID: 55233 Summary: [websocket] Problem reading many subsequent binary messages Product: Tomcat 8 Version: trunk Hardware: PC OS: Linux

[Bug 55171] [jsr 356] All server threads become blocked after some websocket testing

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55171 --- Comment #11 from Stoyan Boshev s.bos...@gmail.com --- Thanks a lot Mark! I confirm the issue is resolved now. However I think the timeout of 5 seconds is pretty low. Under load or slow network and big messages, it is pretty much easy

svn commit: r1501818 - in /tomcat/trunk: java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java webapps/docs/web-socket-howto.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 16:05:17 2013 New Revision: 1501818 URL: http://svn.apache.org/r1501818 Log: Increase default timeout to 20s Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java tomcat/trunk/webapps/docs/web-socket-howto.xml Modified:

[Bug 55171] [jsr 356] All server threads become blocked after some websocket testing

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55171 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1501823 - in /tomcat/trunk: java/javax/el/ListELResolver.java test/javax/el/TestListELResolver.java

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 16:16:42 2013 New Revision: 1501823 URL: http://svn.apache.org/r1501823 Log: javax.el.ListELResolver: According to javadoc: 1. getFeatureDescriptors - always returns null 2. isReadOnly - when property cannot be coerced into an integer it is ignored by the

Re: javax.el.ListELResolver.isReadOnly

2013-07-10 Thread Violeta Georgieva
2013/7/10 Konstantin Kolinko wrote: 2013/7/10 Violeta Georgieva miles...@gmail.com: Hi, In the javadoc it is not described that the method throws IAE when the property cannot be coerced into an integer. Moreover it is specified that the property will be ignored by the resolver:

[Bug 55230] DirContextURLConnection.getInputStream() fails to reopen resources for ProxyDirContext

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55230 --- Comment #2 from zik...@gmail.com --- That is excellent news. Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

svn commit: r1501910 - in /tomcat/trunk: java/javax/el/ArrayELResolver.java test/javax/el/TestArrayELResolver.java

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 18:53:50 2013 New Revision: 1501910 URL: http://svn.apache.org/r1501910 Log: javax.el.ArrayELResolver: According to javadoc: 1. getFeatureDescriptors - always returns null 2. isReadOnly - when property cannot be coerced into an integer it is ignored by the

svn commit: r1501915 - in /tomcat/trunk/java/org/apache/tomcat/websocket: AsyncChannelWrapperSecure.java LocalStrings.properties

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:03:59 2013 New Revision: 1501915 URL: http://svn.apache.org/r1501915 Log: Further improvements to error message to aid debugging https://issues.apache.org/bugzilla/show_bug.cgi?id=55233 Modified:

svn commit: r1501920 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 19:16:30 2013 New Revision: 1501920 URL: http://svn.apache.org/r1501920 Log: Move the log to the correct subsection. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

[Bug 55198] Quote entity in html element attribute evaluated in tagx if attribute contains EL expression

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55198 --- Comment #3 from Mark Thomas ma...@apache.org --- Please be aware that a contributor spotted that the tagx file provided as part fo the test case is not valid. No elements at all may be present inside a jsp:text element. Tomcat 7 8 will

svn commit: r1501926 - /tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:27:04 2013 New Revision: 1501926 URL: http://svn.apache.org/r1501926 Log: Another NPE fox after the switch to obtaining the JspConfigDescription from the ServletContext Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java Modified:

svn commit: r1501927 - /tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:27:52 2013 New Revision: 1501927 URL: http://svn.apache.org/r1501927 Log: Remove some debug code. Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java URL:

svn commit: r1501929 - in /tomcat/trunk: java/org/apache/jasper/compiler/JspDocumentParser.java test/webapp/WEB-INF/tags/bug55198.tagx

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:29:26 2013 New Revision: 1501929 URL: http://svn.apache.org/r1501929 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55207 Enforce requirement that jsp:text elements do not contain any other elements. Fix a test that this change found. Patch by Jeremy

svn commit: r1501935 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java webapps/docs/changelog.xml

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 19:38:49 2013 New Revision: 1501935 URL: http://svn.apache.org/r1501935 Log: Merged revision 1501719 from tomcat/trunk: javax.el.ResourceBundleELResolver: According to javadoc: 1. When creating FeatureDescriptors shortDescription must be empty string 2.

[Bug 55207] In XML syntax, jsp:text does not error on sub-elements from other namespaces

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55207 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1501938 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspDocumentParser.java test/webapp-3.0/WEB-INF/tags/bug55198.tagx webapps/docs/changelog.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:47:43 2013 New Revision: 1501938 URL: http://svn.apache.org/r1501938 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java

svn commit: r1501939 - /tomcat/trunk/conf/catalina.properties

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:49:53 2013 New Revision: 1501939 URL: http://svn.apache.org/r1501939 Log: Ensure the log4j v2 jars are scanned Patch provided by Nick Williams. Modified: tomcat/trunk/conf/catalina.properties Modified: tomcat/trunk/conf/catalina.properties URL:

svn commit: r1501940 - in /tomcat/tc7.0.x/trunk: conf/catalina.properties webapps/docs/changelog.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 19:51:09 2013 New Revision: 1501940 URL: http://svn.apache.org/r1501940 Log: Ensure the log4j v2 jars are scanned Patch provided by Nick Williams. Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 54083] Provide jarsToSkip on a per-webapp basis

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54083 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1501948 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/ListELResolver.java test/javax/el/TestListELResolver.java webapps/docs/changelog.xml

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 20:04:29 2013 New Revision: 1501948 URL: http://svn.apache.org/r1501948 Log: Merged revision 1501823 from tomcat/trunk: javax.el.ListELResolver: According to javadoc: 1. getFeatureDescriptors - always returns null 2. isReadOnly - when property cannot be coerced

[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770 --- Comment #7 from Nick Williams nicho...@nicholaswilliams.net --- Excellent. Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 55144] NIO connection locked when trying to release it

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55144 --- Comment #5 from Mark Thomas ma...@apache.org --- It is good to know that Atmosphere doesn't appear to change the timeout but the question I asked was for one of these blocked threads can you see what the timeout has actually been set

svn commit: r1501971 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/ArrayELResolver.java test/javax/el/TestArrayELResolver.java webapps/docs/changelog.xml

2013-07-10 Thread violetagg
Author: violetagg Date: Wed Jul 10 20:29:56 2013 New Revision: 1501971 URL: http://svn.apache.org/r1501971 Log: Merged revision 1501910 from tomcat/trunk: javax.el.ArrayELResolver: According to javadoc: 1. getFeatureDescriptors - always returns null 2. isReadOnly - when property cannot be coerced

buildbot success in ASF Buildbot on tomcat-trunk

2013-07-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4646 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

Re: svn commit: r1501938 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspDocumentParser.java test/webapp-3.0/WEB-INF/tags/bug55198.tagx webapps/docs/changelog.xml

2013-07-10 Thread Konstantin Kolinko
2013/7/10 ma...@apache.org: Author: markt Date: Wed Jul 10 19:47:43 2013 New Revision: 1501938 URL: http://svn.apache.org/r1501938 Log: (empty) No log message. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1501999 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 21:12:33 2013 New Revision: 1501999 URL: http://svn.apache.org/r1501999 Log: Fix typo Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1502011 - in /tomcat/trunk/java: javax/el/ org/apache/el/ org/apache/jasper/el/

2013-07-10 Thread markt
Author: markt Date: Wed Jul 10 21:30:08 2013 New Revision: 1502011 URL: http://svn.apache.org/r1502011 Log: Implement EL listener notifications for expression evaluations. Modified: tomcat/trunk/java/javax/el/ValueExpression.java tomcat/trunk/java/org/apache/el/MethodExpressionImpl.java

svn propchange: r1501938 - svn:log

2013-07-10 Thread markt
Author: markt Revision: 1501938 Modified property: svn:log Modified: svn:log at Wed Jul 10 21:32:46 2013 -- --- svn:log (original) +++ svn:log Wed Jul 10 21:32:46 2013 @@ -0,0 +1,4 @@ +Fix

[Bug 55198] Quote entity in html element attribute evaluated in tagx if attribute contains EL expression

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55198 --- Comment #4 from Evan Greensmith evan.greensm...@exari.com --- (In reply to Mark Thomas from comment #3) Please be aware that a contributor spotted that the tagx file provided as part fo the test case is not valid. No elements at all