Re: Confused on ServletContainerInitializer discovery

2013-07-21 Thread Mark Thomas
On 21/07/2013 23:07, Jeremy Boynes wrote: > I'm confused by the spec saying: Implementations of the > ServletContainerInitializer interface will be discovered by the > runtime's service lookup mechanism or a container specific mechanism > that is semantically equivalent to it. In either case, > Ser

Confused on ServletContainerInitializer discovery

2013-07-21 Thread Jeremy Boynes
I'm confused by the spec saying: > Implementations of the ServletContainerInitializer interface will be > discovered by the runtime's service lookup mechanism or a container specific > mechanism that is semantically equivalent to it. In either case, > ServletContainerInitializer services from we

[Bug 55287] ServletContainerInitializer in parent classloader may not be found

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 --- Comment #1 from Jeremy Boynes --- Looking at StandardJarScanner, it also only looks for services where the ClassLoader is a URLClassLoader whereas j.u.ServiceLoader basically uses getResources() on the supplied ClassLoader. -- You are

[Bug 55287] New: ServletContainerInitializer in parent classloader may not be found

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 Bug ID: 55287 Summary: ServletContainerInitializer in parent classloader may not be found Product: Tomcat 8 Version: trunk Hardware: All OS: All

[Bug 55243] Add special search string for nested roles

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55243 Felix Schumacher changed: What|Removed |Added Attachment #30582|0 |1 is obsolete|

svn commit: r1505464 - in /tomcat/trunk: ./ conf/ java/org/apache/jasper/resources/ java/org/apache/jasper/servlet/ res/META-INF/jasper.jar/ res/META-INF/jasper.jar/services/

2013-07-21 Thread jboynes
Author: jboynes Date: Sun Jul 21 19:51:31 2013 New Revision: 1505464 URL: http://svn.apache.org/r1505464 Log: Add a ServletContainerInitializer for Jasper. Does nothing yet except log that it is being executed. Added: tomcat/trunk/java/org/apache/jasper/servlet/JasperInitializer.java (with

buildbot success in ASF Buildbot on tomcat-6-trunk

2013-07-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-6-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-6-trunk/builds/556 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

svn commit: r1505435 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 17:49:03 2013 New Revision: 1505435 URL: http://svn.apache.org/r1505435 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1505435&r1=1505434&r

[Bug 55266] Trailing slash redirect loses jsessionid attribute

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55266 --- Comment #2 from Mark Thomas --- Created attachment 30608 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30608&action=edit Proposed patch for this issue This patch fixes this issue for me in local testing. I'll propose it fo

svn commit: r1505434 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 17:46:03 2013 New Revision: 1505434 URL: http://svn.apache.org/r1505434 Log: CTR - Remove trailing whitespace prior to patch for 55266 Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/tc6.0.x/trunk/java/org/

Re: Jasper improvements - web resources and TLDs

2013-07-21 Thread Jeremy Boynes
On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote: > On 08/07/2013 06:38, Jeremy Boynes wrote: >> >> Another area of convergence is in parsing TLDs: currently both >> Catalina and Jasper do it, differently. > > A lot of the code is identical with large comments to keep the two > implementations in

[Bug 55266] Trailing slash redirect loses jsessionid attribute

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55266 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas

[Bug 55249] JspC compiles tag files even if compile options is false

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249 --- Comment #2 from Jeremy Boynes --- Sorry, yes it should. JspC always attempts to compile the Java source generated for tag files even if the "compile" option is set "false" to indicate that operation should not be performed. The call i

buildbot success in ASF Buildbot on tomcat-trunk

2013-07-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4732 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 55249] JspC compiles tag files even if compile options is false

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55249 --- Comment #1 from Mark Thomas --- The report doesn't make much sense (I haven't looked at the source code to try and clarify it). I wouldn't expect a compile flag to control whether or not a .java file is created. Should the last sentence

[Bug 55243] Add special search string for nested roles

2013-07-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55243 --- Comment #1 from Mark Thomas --- The patch also needs to update the JNDI Realm Documentation. I'm not convinced that roleNested should be set to true if this is set. If roleNested is set to false for some reason the user will have no wa

Re: ELException: Cannot convert ... of type class java.lang.Long to class javax.el.LambdaExpression

2013-07-21 Thread Mark Thomas
On 21/07/2013 10:41, Mark Thomas wrote: > I've been comparing Tomcat's behaviour with the RI and it appears that > the parser in the RI always reports lambda expressions with parameters > as functions whereas Tomcat doesn't. I'm taking a close look at the > grammar so see why that might be the cas

svn commit: r1505394 - in /tomcat/trunk: java/org/apache/el/Messages.properties java/org/apache/el/parser/AstValue.java java/org/apache/el/stream/Optional.java test/org/apache/el/stream/TestCollection

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 14:01:52 2013 New Revision: 1505394 URL: http://svn.apache.org/r1505394 Log: Handle calls to Optional#orElseGet where the LambdaExpression has already been evaluated Modified: tomcat/trunk/java/org/apache/el/Messages.properties tomcat/trunk/java/org/apache/

svn commit: r1505347 - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParser.jjt

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 11:38:28 2013 New Revision: 1505347 URL: http://svn.apache.org/r1505347 Log: Align grammar for function with that provided in the EL spec. Unit tests show no functional change. Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java tomcat/trunk/java

svn commit: r1505337 - /tomcat/trunk/test/org/apache/el/stream/TestCollectionOperations.java

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 10:59:42 2013 New Revision: 1505337 URL: http://svn.apache.org/r1505337 Log: Fix tests (still expected to fail until the parser is fixed) Modified: tomcat/trunk/test/org/apache/el/stream/TestCollectionOperations.java Modified: tomcat/trunk/test/org/apache/el/st

Re: ELException: Cannot convert ... of type class java.lang.Long to class javax.el.LambdaExpression

2013-07-21 Thread Mark Thomas
On 19/07/2013 18:53, Violeta Georgieva wrote: > Hi, > > I tried to test the different o.a.el.stream.Optional methods. > > Again I used one of our tests and modify > it: (o.a.el.stream.TestCollectionOperations.testAverage03()) > > > [].stream().average().orElseGet(()->64) > > > I received: >

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2013-07-21 Thread Mark Thomas
On 21/07/2013 10:34, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/4727 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

svn commit: r1505326 - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParser.jjt ELParserTokenManager.java

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 09:34:52 2013 New Revision: 1505326 URL: http://svn.apache.org/r1505326 Log: Review differences between Tomcat's grammar and spec's grammer. Fix a comment typo Correct entry for SKIP Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java tomcat/trunk

buildbot failure in ASF Buildbot on tomcat-trunk

2013-07-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4727 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1505317 - /tomcat/trunk/res/checkstyle/org-import-control.xml

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 08:59:44 2013 New Revision: 1505317 URL: http://svn.apache.org/r1505317 Log: Fix checkstyle import warnings Modified: tomcat/trunk/res/checkstyle/org-import-control.xml Modified: tomcat/trunk/res/checkstyle/org-import-control.xml URL: http://svn.apache.org/vie

svn commit: r1505310 - in /tomcat/trunk: java/org/apache/jasper/servlet/JspCServletContext.java java/org/apache/tomcat/util/descriptor/web/JspConfigDescriptorImpl.java test/org/apache/tomcat/util/desc

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 08:44:57 2013 New Revision: 1505310 URL: http://svn.apache.org/r1505310 Log: Formatting to keep Checkstyle happy Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/JspConfigD

svn commit: r1505308 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/ test/org/apache/el/stream/

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 08:43:56 2013 New Revision: 1505308 URL: http://svn.apache.org/r1505308 Log: Remove unused imports Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/trunk/tes

svn commit: r1505299 - in /tomcat/site/trunk: docs/security-4.html docs/security-5.html docs/security-6.html xdocs/security-4.xml xdocs/security-5.xml xdocs/security-6.xml

2013-07-21 Thread markt
Author: markt Date: Sun Jul 21 08:23:20 2013 New Revision: 1505299 URL: http://svn.apache.org/r1505299 Log: Clarify what was fixed for CVE-2007-1358 Modified: tomcat/site/trunk/docs/security-4.html tomcat/site/trunk/docs/security-5.html tomcat/site/trunk/docs/security-6.html tomca

Re: 8.0.0 (was: 8.0-SNAPSHOT updated)

2013-07-21 Thread Mark Thomas
On 20/07/2013 17:42, Konstantin Kolinko wrote: > 2013/7/18 Mark Thomas : >> Given recent progress, I have uploaded a snapshot of the current state >> of trunk to the Maven snapshot repository. Note that our Maven builds >> include full binary distributions (.zip & .tar.gz) so if folks want to >> te

Bug report for Tomcat Modules [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2013/07/21]

2013-07-21 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned