Re: Need tomcat-native 1.1.29 for next 8.0.x/7.0.x releases

2013-10-09 Thread Mladen Turk
On 10/09/2013 04:42 PM, Mark Thomas wrote: On 05/10/2013 23:39, Mark Thomas wrote: Sorry to be a pain. The JSR 356 WebSocket implementation is broken with APR prior to r1525525 [1]. Tomcat 7.0.x and Tomcat 8.0.x need a 1.1.29 native release to pick up this fix. Any takers for the release? Ping

RE: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread Konstantin Preißer
> Then I also get such exceptions sporadically: > > 09-Oct-2013 23:19:07.646 SEVERE [http-nio-8783-ClientPoller-0] > org.apache.tomcat.util.net.NioEndpoint.processSocket Error allocating > socket processor > java.lang.NullPointerException > at > org.apache.tomcat.util.net.NioEndpoint.proc

svn commit: r1530822 - /tomcat/trunk/webapps/examples/websocket/drawboard.xhtml

2013-10-09 Thread kpreisser
Author: kpreisser Date: Wed Oct 9 22:55:31 2013 New Revision: 1530822 URL: http://svn.apache.org/r1530822 Log: Fix bug in the drawboard JavaScript when socket.onmessage is raised while the Image.load event from a previous message did not yet raise which caused messages to be ignored. Modified:

RE: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, October 9, 2013 3:38 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1530081 - > /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > On 09/10/2013 12:26, Mark Thomas w

svn commit: r1530791 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java

2013-10-09 Thread kpreisser
Author: kpreisser Date: Wed Oct 9 20:48:05 2013 New Revision: 1530791 URL: http://svn.apache.org/r1530791 Log: Fix bug in parsing the client message. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java Modified: tomcat/trunk/webapps/examples/

svn commit: r1530713 - /tomcat/trunk/test/org/apache/jasper/compiler/TestNode.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 17:06:53 2013 New Revision: 1530713 URL: http://svn.apache.org/r1530713 Log: Remove the debug code. Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestNode.java Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestNode.java URL: http://svn.apache

svn commit: r1530712 - /tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestNode.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 17:06:17 2013 New Revision: 1530712 URL: http://svn.apache.org/r1530712 Log: Forgot to back-port the change in webapp location. Remove the debug code. Modified: tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestNode.java Modified: tomcat/tc7.0.x/trunk/te

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-10-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1457 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

Re: Proposal for a more flexible tomcat embedding api

2013-10-09 Thread Adib Saikali
I am creating the API in such a way that if an attribute was added to the component but not to the builder API the user of the API should be able to participate in the creation of the underlying tomcat component object and override its setting. They would have to write more code but could accou

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #16 from Christopher Schultz --- Mark, can you comment on why Tomcat is limited further than, say, httpd? I think that might help drive the final nail in the coffin, here. Is the problem that the Java SSL layer is so far below

svn commit: r1530637 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Node.java test/org/apache/jasper/compiler/TestNode.java test/webapp-3.0/bug5nnnn/bug55642a.jsp test/webapp-3.0/bug5n

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 14:38:53 2013 New Revision: 1530637 URL: http://svn.apache.org/r1530637 Log: Correct logic error in Node.isLiteral() that was returning the inverse of the desired result when the value was an EL expression. Added: tomcat/tc7.0.x/trunk/test/org/apache/jasper/com

[Bug 55642] TagPluginManager isConstantAttribute broken

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55642 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: Need tomcat-native 1.1.29 for next 8.0.x/7.0.x releases

2013-10-09 Thread Mark Thomas
On 05/10/2013 23:39, Mark Thomas wrote: > Sorry to be a pain. The JSR 356 WebSocket implementation is broken with > APR prior to r1525525 [1]. Tomcat 7.0.x and Tomcat 8.0.x need a 1.1.29 > native release to pick up this fix. Any takers for the release? Ping. 8.0.x looks to be ready for the next RC

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-10-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1456 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

svn commit: r1530632 - in /tomcat/trunk: java/org/apache/jasper/compiler/Node.java test/org/apache/jasper/compiler/TestNode.java test/webapp/bug5nnnn/bug55642a.jsp test/webapp/bug5nnnn/bug55642b.jsp

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 14:33:39 2013 New Revision: 1530632 URL: http://svn.apache.org/r1530632 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55642 Correct logic error in Node.isLiteral() that was returning the inverse of the desired result when the value was an EL expression

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #15 from Mark Thomas --- (In reply to Konstantin Preißer from comment #14) > As you can see, Tomcat didn't returin anything like "HTTP/0.9 200 OK" plain > text in its SSL response although Live HTTP Headers reports this. Instead

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #14 from Konstantin Preißer --- (In reply to saurabh from comment #12) > Created attachment 30912 [details] > HTTP 0.9 response from the server > > I tried the identical steps that have been provided and the browser receives >

Re: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread Mark Thomas
On 09/10/2013 12:26, Mark Thomas wrote: > On 09/10/2013 02:41, Konstantin Preißer wrote: > >> When trying with APR, I keep seeing that Tomcat initates the >> connection shutdown. > > I do still see the error when using APR with the current code. I'll dig > into this some more. This should be fix

svn commit: r1530601 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 13:37:05 2013 New Revision: 1530601 URL: http://svn.apache.org/r1530601 Log: Fix issue observed with APR, WebSocket and blocking messages. If one client freezes the system freezes once the network buffers are full. When the client unfroze, the backlog of traffic wa

[Bug 53281] Tomcat returns garbage data with HTTP/0.9 200 OK header when SSL port is accessed using http

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53281 --- Comment #13 from robchek --- (In reply to Mark Thomas from comment #11) > Tested with 6.0.x and confirmed that: > - connecting to the https port using http with a browser returns garbage (as > expected) > - connecting to the https port

svn commit: r1530599 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 13:31:03 2013 New Revision: 1530599 URL: http://svn.apache.org/r1530599 Log: Fix issue observed with APR, WebSocket and blocking messages. If one client freezes the system freezes once the network buffers are full. When the client unfroze, the backlog of traffic wa

[Bug 55642] New: TagPluginManager isConstantAttribute broken

2013-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55642 Bug ID: 55642 Summary: TagPluginManager isConstantAttribute broken Product: Tomcat 7 Version: 7.0.42 Hardware: All OS: All Status: NEW Severity: nor

svn commit: r1530574 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletOutputStream.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 11:38:40 2013 New Revision: 1530574 URL: http://svn.apache.org/r1530574 Log: Handle write errors when the client drops the connection in the same way read errors are handled. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletOutputStream.j

svn commit: r1530575 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/upgrade/AprServletOutputStream.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 11:39:26 2013 New Revision: 1530575 URL: http://svn.apache.org/r1530575 Log: Handle write errors when the client drops the connection in the same way read errors are handled. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/a

Re: svn commit: r1530081 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-09 Thread Mark Thomas
On 09/10/2013 02:41, Konstantin Preißer wrote: > Mark, > >>> -Original Message- From: Mark Thomas >>> [mailto:ma...@apache.org] Sent: Tuesday, October 8, 2013 3:57 PM >>> To: Tomcat Developers List Subject: Re: svn commit: r1530081 - >>> /tomcat/trunk/java/org/apache/tomcat/util/net/AprE

Re: Proposal for a more flexible tomcat embedding api

2013-10-09 Thread Mark Thomas
On 09/10/2013 04:24, Adib Saikali wrote: > 1. Has anyone already done such as API? I'm not aware of any. > 2. Would the tomcat committers accept an implementation of this proposal > into > the tomcat distribution ? The main question for me is maintainability and how much work would be re

jasper changes for 8.0: genStringAsCharArray, genStringAsByteArray, trimSpaces

2013-10-09 Thread Pavel Cibulka
Hello, both jetty and glassfish have genStringAsByteArray set to "true" by default. Would it be possible to change this in jasper? I know that genStringAsByteArray is not implemented yet, what about making genStringAsCharArray default "true" for now? Also trimSpaces works as in specification, but

svn commit: r1530545 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 09:41:31 2013 New Revision: 1530545 URL: http://svn.apache.org/r1530545 Log: Use the constant for the buffer sizes (makes it easier to experiment with performance impacts of different buffer sizes) Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemot

svn commit: r1530528 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 08:39:56 2013 New Revision: 1530528 URL: http://svn.apache.org/r1530528 Log: Remove completed TODOs and pointless Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.ja

svn commit: r1530519 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/EchoEndpoint.java

2013-10-09 Thread markt
Author: markt Date: Wed Oct 9 08:08:47 2013 New Revision: 1530519 URL: http://svn.apache.org/r1530519 Log: Changes to the programmatic echo endpoint so it can be used with the Authobahn test suite: - handle binary messages - handle partial messages (enables larger messages) Modified: tomc