svn commit: r1630059 - /tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 10:13:20 2014 New Revision: 1630059 URL: http://svn.apache.org/r1630059 Log: FindBugs. Remove unnecessary null check. Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappLoader.java Modified:

svn commit: r1630060 - /tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 10:20:20 2014 New Revision: 1630060 URL: http://svn.apache.org/r1630060 Log: FindBugs. Use a better test for an odd number. Functionally makes no difference since length is always =0 but it should be a little faster. Modified:

svn commit: r1630063 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/tomcat/util/http/TestCookieParsing.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 10:26:37 2014 New Revision: 1630063 URL: http://svn.apache.org/r1630063 Log: FindBugs. Ignore a false positive. Add a warning to the code in case someone copies this test code for a real app. Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-10-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/308 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: scheduler Build

svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 10:38:33 2014 New Revision: 1630065 URL: http://svn.apache.org/r1630065 Log: Extend support for permessage-deflate to the WebSocket client implementation. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java

Re: svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread Martin Grigorov
Hi, On Wed, Oct 8, 2014 at 12:38 PM, ma...@apache.org wrote: Author: markt Date: Wed Oct 8 10:38:33 2014 New Revision: 1630065 URL: http://svn.apache.org/r1630065 Log: Extend support for permessage-deflate to the WebSocket client implementation. Modified:

Re: svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread Mark Thomas
On 08/10/2014 11:41, Martin Grigorov wrote: It really helps if you are going to comment on a small part of a large commit if you trim the irrelevant parts of the original in your reply. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java URL:

Re: svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread Martin Grigorov
On Wed, Oct 8, 2014 at 1:02 PM, Mark Thomas ma...@apache.org wrote: On 08/10/2014 11:41, Martin Grigorov wrote: It really helps if you are going to comment on a small part of a large commit if you trim the irrelevant parts of the original in your reply. I'll try to remember for the next

Re: [VOTE] Release Apache Tomcat 6.0.42

2014-10-08 Thread Konstantin Kolinko
2014-10-01 0:48 GMT+04:00 jean-frederic clere jfcl...@gmail.com: The proposed Apache Tomcat 6.0.42 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.42/ The Maven staging repo is:

svn commit: r1630088 - /tomcat/trunk/build.xml

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 12:45:40 2014 New Revision: 1630088 URL: http://svn.apache.org/r1630088 Log: Use 24 hour clock in build stamp Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: svn commit: r1630088 - /tomcat/trunk/build.xml

2014-10-08 Thread Konstantin Kolinko
2014-10-08 16:45 GMT+04:00 ma...@apache.org: Author: markt Date: Wed Oct 8 12:45:40 2014 New Revision: 1630088 URL: http://svn.apache.org/r1630088 Log: Use 24 hour clock in build stamp Good catch! Maybe add timezone information as well? Modified: tomcat/trunk/build.xml

svn commit: r1630092 - /tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 12:56:42 2014 New Revision: 1630092 URL: http://svn.apache.org/r1630092 Log: Correct type as spotted by Martin Grigorov Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java Modified:

svn commit: r1630094 - /tomcat/trunk/build.xml

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 13:06:56 2014 New Revision: 1630094 URL: http://svn.apache.org/r1630094 Log: Ensure all dates are generated for UTC and add timezone to build stamp Suggested by kkolinko Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: svn commit: r1630088 - /tomcat/trunk/build.xml

2014-10-08 Thread Mark Thomas
On 08/10/2014 13:50, Konstantin Kolinko wrote: 2014-10-08 16:45 GMT+04:00 ma...@apache.org: Author: markt Date: Wed Oct 8 12:45:40 2014 New Revision: 1630088 URL: http://svn.apache.org/r1630088 Log: Use 24 hour clock in build stamp Good catch! Maybe add timezone information as

buildbot failure in ASF Buildbot on tomcat-trunk

2014-10-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/523 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1630110 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/VersionLoggerListener.java webapps/docs/changelog.xml webapps/docs/co

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 14:05:22 2014 New Revision: 1630110 URL: http://svn.apache.org/r1630110 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47919 Extend the information logged when Tomcat starts to optionally include (enabled by default) the values of key environment

[Bug 47919] Log Tomcat Java environment variables in addition to echoing to the screen

2014-10-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47919 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141008-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

Re: svn commit: r1630110 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/VersionLoggerListener.java webapps/docs/changelog.xml webapps/doc

2014-10-08 Thread Konstantin Kolinko
2014-10-08 18:05 GMT+04:00 ma...@apache.org: Author: markt Date: Wed Oct 8 14:05:22 2014 New Revision: 1630110 URL: http://svn.apache.org/r1630110 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47919 Extend the information logged when Tomcat starts to optionally include

svn commit: r1630194 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: LocalStrings.properties UpgradeUtil.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 18:40:56 2014 New Revision: 1630194 URL: http://svn.apache.org/r1630194 Log: Fix an i18n TODO Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

Re: svn commit: r1630110 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/VersionLoggerListener.java webapps/docs/changelog.xml webapps/doc

2014-10-08 Thread Mark Thomas
On 08/10/2014 19:36, Konstantin Kolinko wrote: 2014-10-08 18:05 GMT+04:00 ma...@apache.org: Author: markt Date: Wed Oct 8 14:05:22 2014 New Revision: 1630110 URL: http://svn.apache.org/r1630110 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47919 Extend the information

svn commit: r1630199 - /tomcat/trunk/java/org/apache/tomcat/websocket/Util.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:01:20 2014 New Revision: 1630199 URL: http://svn.apache.org/r1630199 Log: NPE protection. Note NPE only possible with test code. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Util.java Modified:

svn commit: r1630203 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsFrameClient.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:08:31 2014 New Revision: 1630203 URL: http://svn.apache.org/r1630203 Log: Add debug logging for IOEs while reading data from server Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.9-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20141008.jar:/srv/gump/public/workspace

svn commit: r1630208 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsWebSocketContainer.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:26:28 2014 New Revision: 1630208 URL: http://svn.apache.org/r1630208 Log: Fix an i18n TODO Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified:

svn commit: r1630209 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:32:30 2014 New Revision: 1630209 URL: http://svn.apache.org/r1630209 Log: Address a TODO Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

svn commit: r1630210 - /tomcat/trunk/java/org/apache/tomcat/websocket/PerMessageDeflate.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:32:59 2014 New Revision: 1630210 URL: http://svn.apache.org/r1630210 Log: Correct logic (error detected by Autobahn test suite) Modified: tomcat/trunk/java/org/apache/tomcat/websocket/PerMessageDeflate.java Modified:

svn commit: r1630211 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:35:05 2014 New Revision: 1630211 URL: http://svn.apache.org/r1630211 Log: Expand Autobahn client test to include permessage-deflate Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java Modified:

[GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141008-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

svn commit: r1630212 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:39:59 2014 New Revision: 1630212 URL: http://svn.apache.org/r1630212 Log: Revert unintentional change Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java Modified:

svn commit: r1630216 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml

2014-10-08 Thread markt
Author: markt Date: Wed Oct 8 19:52:08 2014 New Revision: 1630216 URL: http://svn.apache.org/r1630216 Log: Fix checkstyle nags Modified: tomcat/trunk/build.xml tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.xml URL:

Re: svn commit: r1630110 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/VersionLoggerListener.java webapps/docs/changelog.xml webapps/doc

2014-10-08 Thread Konstantin Kolinko
2014-10-08 22:48 GMT+04:00 Mark Thomas ma...@apache.org: On 08/10/2014 19:36, Konstantin Kolinko wrote: 2014-10-08 18:05 GMT+04:00 ma...@apache.org: Author: markt Date: Wed Oct 8 14:05:22 2014 New Revision: 1630110 URL: http://svn.apache.org/r1630110 Log: Fix

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141008-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141008-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

buildbot exception in ASF Buildbot on tomcat-7-trunk

2014-10-08 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/331 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: scheduler

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-10-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/332 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: scheduler Build

Re: [VOTE] Release Apache Tomcat 6.0.42

2014-10-08 Thread Andrew Carr
Tested for https://issues.apache.org/bugzilla/show_bug.cgi?id=56561 it is fixed The proposed 6.0.42 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 6.0.42 Stable On Wed, Oct 8, 2014 at 8:38 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2014-10-01 0:48

Re: [VOTE] Release Apache Tomcat 6.0.42

2014-10-08 Thread Andrew Carr
Sorry for the gmail formatting of my text where it assumes my response should be trimmed, here is my vote, easier to see. [X] Stable - go ahead and release as 6.0.42 Stable Andrew On Wed, Oct 8, 2014 at 8:46 PM, Andrew Carr andrewlanec...@gmail.com wrote: Tested for

[GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-bio has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-10-08 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration.