[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-11-10 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th

svn commit: r1637982 - /tomcat/trunk/java/org/apache/tomcat/util/net/res/

2014-11-10 Thread kkolinko
Author: kkolinko Date: Mon Nov 10 21:25:56 2014 New Revision: 1637982 URL: http://svn.apache.org/r1637982 Log: Remove empty directory. The files were moved in r1637926. Removed: tomcat/trunk/java/org/apache/tomcat/util/net/res/ ---

Re: [VOTE] Release Apache Tomcat 6.0.42

2014-11-10 Thread Andrew Carr
Has this issue been fixed? On Fri, Oct 17, 2014 at 6:01 AM, Mark Thomas wrote: > On 30/09/2014 21:48, jean-frederic clere wrote: > > The proposed Apache Tomcat 6.0.42 release is now available for voting. > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/

svn commit: r1637949 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2014-11-10 Thread remm
Author: remm Date: Mon Nov 10 18:09:39 2014 New Revision: 1637949 URL: http://svn.apache.org/r1637949 Log: Fix apparent issue with a non final field. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.j

RE: svn commit: r1637684 - /tomcat/trunk/webapps/docs/ssl-howto.xml

2014-11-10 Thread Konstantin Preißer
Hi Christopher, > -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Monday, November 10, 2014 3:39 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1637684 - /tomcat/trunk/webapps/docs/ssl- > howto.xml > > Konstantin, > > On 11/10/14

Re: Connector refactoring

2014-11-10 Thread Rémy Maucherat
2014-11-10 18:32 GMT+01:00 Mark Thomas : > > For example, with the NIO2 connector, the code is rather different > between > > upgrade and non upgrade, plus it has the possibility of doing gather > writes > > (not done in upgrade, only in regular mode; basically in upgrade mode the > > framework in

Re: Connector refactoring

2014-11-10 Thread Mark Thomas
On 10/11/2014 17:14, Rémy Maucherat wrote: > 2014-11-10 17:42 GMT+01:00 Mark Thomas : > >> Hi, >> >> I am about to push the first batch of commits. I started with the >> upgrade package as that looked like the simplest to tackle first. Rather >> than a single commit, I'll keep the individual commi

Re: Connector refactoring

2014-11-10 Thread Rémy Maucherat
2014-11-10 17:42 GMT+01:00 Mark Thomas : > Hi, > > I am about to push the first batch of commits. I started with the > upgrade package as that looked like the simplest to tackle first. Rather > than a single commit, I'll keep the individual commits from git. They > aren't all as clean as I would l

svn commit: r1637942 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: LocalStrings.properties UpgradeProcessor.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:48:08 2014 New Revision: 1637942 URL: http://svn.apache.org/r1637942 Log: Align message naming Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/LocalStrings.properties tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java M

svn commit: r1637941 - in /tomcat/trunk/java/org/apache/coyote/http11: ./ upgrade/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:48:03 2014 New Revision: 1637941 URL: http://svn.apache.org/r1637941 Log: No longer need implementation specific upgrade processors. Collapse class hierarchy into single implementation. Added: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcesso

svn commit: r1637939 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AprProcessor.java Nio2Processor.java NioProcessor.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:47 2014 New Revision: 1637939 URL: http://svn.apache.org/r1637939 Log: Rename for clarity Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2Processor.java tomcat/tr

svn commit: r1637933 - /tomcat/trunk/webapps/examples/websocket/drawboard.xhtml

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:12 2014 New Revision: 1637933 URL: http://svn.apache.org/r1637933 Log: Remove unnecessary comment now BIO has been removed. Modified: tomcat/trunk/webapps/examples/websocket/drawboard.xhtml Modified: tomcat/trunk/webapps/examples/websocket/drawboard.xhtml

svn commit: r1637938 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/ tomcat/util/net/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:40 2014 New Revision: 1637938 URL: http://svn.apache.org/r1637938 Log: No longer need implementation specific UpgradeServletOutputStreams. Collapse the unnecessary class hierarchy. Added: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletOu

svn commit: r1637935 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/Nio2ServletOutputStream.java tomcat/util/net/Nio2Endpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:25 2014 New Revision: 1637935 URL: http://svn.apache.org/r1637935 Log: Push write methods down to SocketWrapper for NIO2 Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java tomcat/trunk/java/org/apache/tomcat/util

svn commit: r1637937 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/AprServletOutputStream.java tomcat/util/net/AprEndpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:30 2014 New Revision: 1637937 URL: http://svn.apache.org/r1637937 Log: Push write methods down to SocketWrapper for APR Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletOutputStream.java tomcat/trunk/java/org/apache/tomcat/util/n

svn commit: r1637940 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/ tomcat/util/net/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:56 2014 New Revision: 1637940 URL: http://svn.apache.org/r1637940 Log: Add a standard method for returning input to the SocketWrapper. Use this to make the code consistent between upgrade processor implementations. Modified: tomcat/trunk/java/org/apache/co

svn commit: r1637923 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11Nio2Protocol.java upgrade/Nio2Processor.java upgrade/Nio2ServletOutputStream.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:55 2014 New Revision: 1637923 URL: http://svn.apache.org/r1637923 Log: Remove Endpoint from NioServletOutputStream constructor Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2Protocol.java tomcat/trunk/java/org/apache/coyote/http11/upgra

svn commit: r1637934 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/NioServletOutputStream.java tomcat/util/net/NioEndpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:19 2014 New Revision: 1637934 URL: http://svn.apache.org/r1637934 Log: Push write methods down to SocketWrapper for NIO Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/NioServletOutputStream.java tomcat/trunk/java/org/apache/tomcat/util/n

svn commit: r1637925 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/AprProcessor.java coyote/http11/upgrade/AprServletInputStream.java tomcat/util/net/AprEndpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:09 2014 New Revision: 1637925 URL: http://svn.apache.org/r1637925 Log: Push down read methods to AprSocketWrapper Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServ

svn commit: r1637932 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AbstractProcessor.java AprProcessor.java Nio2Processor.java NioProcessor.java ServletInputStreamImpl.java UpgradeServletI

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:47:08 2014 New Revision: 1637932 URL: http://svn.apache.org/r1637932 Log: Rename. Might collapse some of these packages at a later point. Added: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java (contents, props changed)

svn commit: r1637926 - in /tomcat/trunk/java/org/apache/tomcat/util/net: ./ res/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:21 2014 New Revision: 1637926 URL: http://svn.apache.org/r1637926 Log: Move message resources to same package for consistency with other Tomcat code Added: tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties (contents, props changed)

svn commit: r1637930 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:50 2014 New Revision: 1637930 URL: http://svn.apache.org/r1637930 Log: Drop the connector specific ServletInputStream implementations for HTTP upgrade Added: tomcat/trunk/java/org/apache/coyote/http11/upgrade/ServletInputStreamImpl.java (contents, prop

svn commit: r1637928 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProtocol.java upgrade/AprProcessor.java upgrade/AprServletOutputStream.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:32 2014 New Revision: 1637928 URL: http://svn.apache.org/r1637928 Log: Remove endpoint from AprServletOutputStream Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprProcess

svn commit: r1637917 [1/2] - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/coyote/spdy/ ja

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:04 2014 New Revision: 1637917 URL: http://svn.apache.org/r1637917 Log: Make SocketWrapper abstract Rename SocketWrapper and sub-classes for consistency Added: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java (contents, props changed)

svn commit: r1637921 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/NioServletInputStream.java tomcat/util/net/NioEndpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:42 2014 New Revision: 1637921 URL: http://svn.apache.org/r1637921 Log: Push read methods down to NioSocketWrapper. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/NioServletInputStream.java tomcat/trunk/java/org/apache/tomcat/util/net/Nio

svn commit: r1637931 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AbstractServletOutputStream.java AprServletOutputStream.java Nio2ServletOutputStream.java NioServletOutputStream.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:56 2014 New Revision: 1637931 URL: http://svn.apache.org/r1637931 Log: Use close method now available in SocketWrapper Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java tomcat/trunk/java/org/apache/coyote/h

svn commit: r1637927 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java LocalStrings.properties

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:27 2014 New Revision: 1637927 URL: http://svn.apache.org/r1637927 Log: Add missing messages Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings.properties Modified: tomcat/t

svn commit: r1637929 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/ tomcat/util/net/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:40 2014 New Revision: 1637929 URL: http://svn.apache.org/r1637929 Log: Add common methods to SocketWrapperBase as abstract methods and rename Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java tomcat/trunk/java/or

svn commit: r1637922 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: Nio2Processor.java Nio2ServletInputStream.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:48 2014 New Revision: 1637922 URL: http://svn.apache.org/r1637922 Log: Remove Endpoint from NioServletInputStream constructor Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2Processor.java tomcat/trunk/java/org/apache/coyote/http11/up

svn commit: r1637924 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/Nio2ServletInputStream.java tomcat/util/net/Nio2Endpoint.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:46:03 2014 New Revision: 1637924 URL: http://svn.apache.org/r1637924 Log: Push read methods down into Nio2SocketWrapper Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletInputStream.java tomcat/trunk/java/org/apache/tomcat/util/net/

svn commit: r1637918 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AbstractProcessor.java AbstractServletInputStream.java AbstractServletOutputStream.java Constants.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:12 2014 New Revision: 1637918 URL: http://svn.apache.org/r1637918 Log: Remove unnecessary Constants class. Removed: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Constants.java Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractP

svn commit: r1637919 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java NioEndpoint.java SocketWrapperBase.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:20 2014 New Revision: 1637919 URL: http://svn.apache.org/r1637919 Log: Add the Endpoint to the SocketWrapper Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomc

svn commit: r1637920 - in /tomcat/trunk/java/org/apache: coyote/http11/ coyote/http11/upgrade/ tomcat/util/net/

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:45:33 2014 New Revision: 1637920 URL: http://svn.apache.org/r1637920 Log: No longer need to pass NioSelectorPool in constructors in I/O streams Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java tomcat/trunk/java/org/apache/coyote

svn commit: r1637917 [2/2] - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/coyote/spdy/ ja

2014-11-10 Thread markt
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1637917&r1=1637916&r2=1637917&view=diff == --- t

svn commit: r1637916 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 16:44:43 2014 New Revision: 1637916 URL: http://svn.apache.org/r1637916 Log: Remove unnecessary IDE warning Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java Modified: tomcat/trunk/modules/jdbc-pool/src

Connector refactoring

2014-11-10 Thread Mark Thomas
Hi, I am about to push the first batch of commits. I started with the upgrade package as that looked like the simplest to tackle first. Rather than a single commit, I'll keep the individual commits from git. They aren't all as clean as I would like but it gives a better idea of how I approached it

svn commit: r1637893 - in /tomcat/trunk/java/org/apache/catalina/authenticator: AuthenticatorBase.java Constants.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 15:47:25 2014 New Revision: 1637893 URL: http://svn.apache.org/r1637893 Log: Use new utility method to obtain StringManager and remove the constant that is now unused. Move the statics to the start of the class. A small amount of whitespace clean-up Modified: t

svn commit: r1637892 - /tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 15:39:46 2014 New Revision: 1637892 URL: http://svn.apache.org/r1637892 Log: Add a utility method that will make it easier to get the StringManager for a given class. Modified: tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java Modified: tomcat/tr

svn commit: r1637890 - /tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 15:39:11 2014 New Revision: 1637890 URL: http://svn.apache.org/r1637890 Log: Clean-up - Consistent whitespace - Fix Java8 Javadoc warnings - Remove unnecessary synchronized Modified: tomcat/trunk/java/org/apache/tomcat/util/res/StringManager.java Modified: t

Re: svn commit: r1637684 - /tomcat/trunk/webapps/docs/ssl-howto.xml

2014-11-10 Thread Christopher Schultz
Konstantin, On 11/10/14 4:54 AM, Konstantin Kolinko wrote: > 2014-11-10 6:51 GMT+03:00 Christopher Schultz : >> Konstantin, >> >> On 11/9/14 10:12 AM, kkoli...@apache.org wrote: >>> Author: kkolinko >>> Date: Sun Nov 9 15:12:29 2014 >>> New Revision: 1637684 >>> >>> URL: http://svn.apache.org/r16

svn commit: r1637876 - in /tomcat/tc7.0.x/trunk/webapps/docs: config/context.xml tomcat-docs.xsl

2014-11-10 Thread schultz
Author: schultz Date: Mon Nov 10 14:38:57 2014 New Revision: 1637876 URL: http://svn.apache.org/r1637876 Log: Removed arkward indent/outdent markup in favor of plain-old with manual spacing. (Partial revert of r1371336) Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/context.xml tomc

svn commit: r1637867 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-11-10 Thread markt
Author: markt Date: Mon Nov 10 14:13:26 2014 New Revision: 1637867 URL: http://svn.apache.org/r1637867 Log: Drop my proposal. Vote for Konstantin's. This effectively removed Remy's vote. I was tempted to leave it but the patch is different. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified

[Bug 57187] OPTIONS * failure

2014-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57187 Remy Maucherat changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1637848 - in /tomcat/tc8.0.x/trunk/java/org/apache/catalina: connector/CoyoteAdapter.java mapper/Mapper.java

2014-11-10 Thread remm
Author: remm Date: Mon Nov 10 13:41:20 2014 New Revision: 1637848 URL: http://svn.apache.org/r1637848 Log: Port r1637839 57187 again: handle * before mapping. Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/tc8.0.x/trunk/java/org/apache/catalina

svn commit: r1637839 - in /tomcat/trunk/java/org/apache/catalina: connector/CoyoteAdapter.java mapper/Mapper.java

2014-11-10 Thread remm
Author: remm Date: Mon Nov 10 13:35:02 2014 New Revision: 1637839 URL: http://svn.apache.org/r1637839 Log: 57187 again: handle * before mapping. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java Modified:

[Bug 57187] OPTIONS * failure

2014-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57187 --- Comment #6 from jfclere --- basically OPTIONS * shouldn't be mapped to anything just answered as it is like the CPING/PONG of AJP. See http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html -- You are receiving this mail because: You a

[Bug 57187] OPTIONS * failure

2014-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57187 --- Comment #5 from Remy Maucherat --- Another possibility (looking at the code) is to deal with * in CoyoteAdpater.postParseRequest before mapping, and only OPTIONS would return a non 404 response. -- You are receiving this mail because:

[Bug 57187] OPTIONS * failure

2014-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57187 --- Comment #4 from Remy Maucherat --- OPTIONS * means an OPTIONS method applied to the whole server, it is used my mod_cluster to ping. This is a valid request, which should be processed by the default servlet as it is now. For any other m

[Bug 57187] OPTIONS * failure

2014-11-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57187 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

Re: svn commit: r1637684 - /tomcat/trunk/webapps/docs/ssl-howto.xml

2014-11-10 Thread Konstantin Kolinko
2014-11-10 6:51 GMT+03:00 Christopher Schultz : > Konstantin, > > On 11/9/14 10:12 AM, kkoli...@apache.org wrote: >> Author: kkolinko >> Date: Sun Nov 9 15:12:29 2014 >> New Revision: 1637684 >> >> URL: http://svn.apache.org/r1637684 >> Log: >> Minor corrections: >> - Remove '\' at end-of-line whe