Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread jean-frederic clere
On 11/14/2014 11:42 AM, Mark Thomas wrote: [X] Stable - go ahead and release as 6.0.43 Stable My tests are passing. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

[Bug 57233] New: unable to shutdown with whitespace in path because of javaagent error

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57233 Bug ID: 57233 Summary: unable to shutdown with whitespace in path because of javaagent error Product: Tomcat 7 Version: 7.0.55 Hardware: PC OS: Linux

Re: svn commit: r1640089 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2014-11-18 Thread Mark Thomas
On 18/11/2014 03:48, Konstantin Kolinko wrote: 2014-11-18 5:30 GMT+03:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-11-17 11:06 GMT+03:00 ma...@apache.org: Author: markt Date: Mon Nov 17 08:06:24 2014 New Revision: 1640089 URL: http://svn.apache.org/r1640089 Log: Fix

svn commit: r1640322 - /tomcat/trunk/build.xml

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 12:56:52 2014 New Revision: 1640322 URL: http://svn.apache.org/r1640322 Log: Remove unneeded taskdef for setproxy task. The announcement for Ant 1.8.2 said, * distinction between core tasks and optional tasks is abolished

svn commit: r1640347 - in /tomcat/trunk: java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/core/TestStandardContext.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 14:04:07 2014 New Revision: 1640347 URL: http://svn.apache.org/r1640347 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57216 Warn and correct invalid context paths that end with a '/' Modified:

svn commit: r1640349 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/core/TestStandardC

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 14:22:30 2014 New Revision: 1640349 URL: http://svn.apache.org/r1640349 Log: Further fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57216 Warn and correct invalid context paths that end with a '/' Merged r1640347 from tomcat/trunk. Modified:

svn commit: r1640351 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/core/TestStandardC

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 14:40:48 2014 New Revision: 1640351 URL: http://svn.apache.org/r1640351 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57216 Improve handling of invalid context paths. This adds handling of paths that end with '/', including /. This corrects handling

[Bug 57216] Servlet mapping not found when creating RequestDispatcher for forward()

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57216 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- I backported the path checks to Tomcat 7 (r1640351). It will be in 7.0.58 onwards. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57216] Servlet mapping not found when creating RequestDispatcher for forward()

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57216 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com --- For a record: The check and correction of context paths originates from r1080714 in 7.0.12 (3 years ago). Thus the fix was backported to Tomcat 7 as well. -- You are

svn commit: r1640361 - in /tomcat/trunk/test/org/apache/catalina/startup: TestListener.java TestTomcat.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 15:08:08 2014 New Revision: 1640361 URL: http://svn.apache.org/r1640361 Log: Correct tests to use the correct context path for ROOT webapp. Those were printing the warning StandardContext.setPath A context path must either be an empty string or start with a

svn commit: r1640363 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/startup/TestListener.java test/org/apache/catalina/startup/TestTomcat.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 15:09:42 2014 New Revision: 1640363 URL: http://svn.apache.org/r1640363 Log: Correct tests to use the correct context path for ROOT webapp. Those were printing the warning StandardContext.setPath A context path must either be an empty string or start with a

svn commit: r1640365 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 15:20:58 2014 New Revision: 1640365 URL: http://svn.apache.org/r1640365 Log: A better message text. Followup to r1640363. Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified:

svn commit: r1640366 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/startup/TestTomcat.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 15:22:20 2014 New Revision: 1640366 URL: http://svn.apache.org/r1640366 Log: A better message text. Followup to r1640363. Merged r1640365 from tomcat/trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn propchange: r1640351 - svn:log

2014-11-18 Thread kkolinko
Author: kkolinko Revision: 1640351 Modified property: svn:log Modified: svn:log at Tue Nov 18 15:23:41 2014 -- --- svn:log (original) +++ svn:log Tue Nov 18 15:23:41 2014 @@ -1,6 +1,6 @@ Fix

svn commit: r1640367 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/TestListener.java test/org/apache/catalina/startup/TestTomcat.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 15:25:21 2014 New Revision: 1640367 URL: http://svn.apache.org/r1640367 Log: Correct tests to use the correct context path for ROOT webapp. Those were printing the warning StandardContext.setPath A context path must either be an empty string or start with a

[Bug 57232] Sealed .jar files in WEB-INF/lib always fail to load second class

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57232 Brent Shikoski brent.shiko...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1640385 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 16:42:56 2014 New Revision: 1640385 URL: http://svn.apache.org/r1640385 Log: Correct tests to use the correct context path for ROOT webapp. Those were printing the warning StandardContext.setPath A context path must either be an empty string or start with a

Re: svn commit: r1640089 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2014-11-18 Thread Konstantin Kolinko
2014-11-18 13:29 GMT+03:00 Mark Thomas ma...@apache.org: On 18/11/2014 03:48, Konstantin Kolinko wrote: 2014-11-18 5:30 GMT+03:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-11-17 11:06 GMT+03:00 ma...@apache.org: Author: markt Date: Mon Nov 17 08:06:24 2014 New Revision: 1640089 URL:

svn commit: r1640396 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 17:36:34 2014 New Revision: 1640396 URL: http://svn.apache.org/r1640396 Log: Automatically create target directory (base.path) when downloading files. Use random temporary filename instead of file.zip/file.tar.gz to allow several downloads to run in parallel.

svn commit: r1640400 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default build.xml webapps/docs/changelog.xml

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 17:40:12 2014 New Revision: 1640400 URL: http://svn.apache.org/r1640400 Log: Update to Checkstyle 6.0 Download just a checkstyle-6.0-all.jar instead of the whole bin.zip that contains that file. Merged r1638726 from tomcat/tc8.0.x/trunk. Modified:

Re: Difference between o.a.c.realm.PasswordStrategy and o.a.c.CredentialHandler

2014-11-18 Thread Konstantin Kolinko
2014-11-17 18:56 GMT+03:00 Christopher Schultz ch...@christopherschultz.net: All, (mostly markt) Is there a real difference between PasswordStrategy and CredentialHandler? It appears the former is only used in RealmBase's startInternal method... I think it's completely unused (and Eclipse

svn commit: r1640403 - /tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 18:22:13 2014 New Revision: 1640403 URL: http://svn.apache.org/r1640403 Log: Revert unwanted change from r1640087 (r1640084 in trunk) that was a fix for BZ 57172 Modified: tomcat/trunk/java/org/apache/catalina/loader/LocalStrings.properties Modified:

svn commit: r1640404 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/loader/LocalStrings.properties

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 18:23:36 2014 New Revision: 1640404 URL: http://svn.apache.org/r1640404 Log: Revert unwanted change from r1640087 (r1640084 in trunk) that was a fix for BZ 57172 Merged r1640403 from tomcat/trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed)

[Bug 57233] unable to shutdown with whitespace in path because of javaagent error

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57233 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

svn commit: r1640410 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 19:08:54 2014 New Revision: 1640410 URL: http://svn.apache.org/r1640410 Log: Further fix for BZ 57172 - followup to r1640087 (r1640084 in trunk). Be consistent with webappClassLoader.stopped message handling and throw an ISE from findResourceInternal In all

svn commit: r1640411 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/loader/WebappClassLoaderBase.java webapps/docs/changelog.xml

2014-11-18 Thread kkolinko
Author: kkolinko Date: Tue Nov 18 19:11:14 2014 New Revision: 1640411 URL: http://svn.apache.org/r1640411 Log: Further fix for BZ 57172 - followup to r1640087 (r1640084 in trunk). Be consistent with webappClassLoader.stopped message handling and throw an ISE from findResourceInternal In all

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Christopher Schultz
Andrew, On 11/17/14 2:26 PM, Andrew Carr wrote: +1 stable for me However, and I don't know if this is a game changer, I am having a problem when implementing SSL using the NIOConnector, althought the problem does not look like a Tomcat source problem. I did verify that disabling SSLv3

Re: Difference between o.a.c.realm.PasswordStrategy and o.a.c.CredentialHandler

2014-11-18 Thread Christopher Schultz
Konstantin, On 11/18/14 1:16 PM, Konstantin Kolinko wrote: 2014-11-17 18:56 GMT+03:00 Christopher Schultz ch...@christopherschultz.net: All, (mostly markt) Is there a real difference between PasswordStrategy and CredentialHandler? It appears the former is only used in RealmBase's

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Andrew Carr
Chris, Thank you for the response. I will include the full stack trace next time. Note that, like polio, SSLv2 has been wiped from the face of the planet. This is not an error. This will not impact anyone of consequence. You may be looking for SSLv2Hello. -chirs You said that I

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Konstantin Kolinko
2014-11-17 22:26 GMT+03:00 Andrew Carr andrewlanec...@gmail.com: +1 stable for me However, and I don't know if this is a game changer, I am having a problem when implementing SSL using the NIOConnector, althought the problem does not look like a Tomcat source problem. I did verify that

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Andrew Carr
Thanks Konstantin On Tue, Nov 18, 2014 at 3:09 PM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2014-11-17 22:26 GMT+03:00 Andrew Carr andrewlanec...@gmail.com: +1 stable for me However, and I don't know if this is a game changer, I am having a problem when implementing SSL using

[Bug 57234] New: Use case-insensitive substring search when filtering SSLv2/v3 protocols in connectors

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57234 Bug ID: 57234 Summary: Use case-insensitive substring search when filtering SSLv2/v3 protocols in connectors Product: Tomcat 8 Version: 8.0.15 Hardware: PC

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Christopher Schultz
Andrew, On 11/18/14 2:58 PM, Andrew Carr wrote: Chris, Thank you for the response. I will include the full stack trace next time. Note that, like polio, SSLv2 has been wiped from the face of the planet. This is not an error. This will not impact anyone of consequence. You may be

[Bug 57234] Use case-insensitive substring search when filtering SSLv2/v3 protocols in connectors

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57234 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added OS|

[Bug 57234] Use case-insensitive substring search when filtering SSLv2/v3 protocols in connectors

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57234 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- I didn't check to see if SSLv2Hello is returned by socket.getEnabledProtocols() It is possible to turn on logging with

[Bug 57215] Regression in Tomcat 7.0.54 after Bug 56501 with urls starting with //

2014-11-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57215 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- (In reply to Mark Thomas from comment #1) For example, what gets returned for a request to %2Ffoo%2F%2E%2E%2Fpath? RFC7230 2.7.3. http and https URI Normalization and

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2014-11-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2014-11-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2014-11-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

Re: [VOTE] Release Apache Tomcat 6.0.43

2014-11-18 Thread Andrew Carr
If you review the Tomcat 6 documentation here: https://tomcat.apache.org/tomcat-6.0-doc/config/http.html#SSL_Support , you will see sslEnabledProtocols. On the desc. for that setting there are links for Java 6 and Java 7 protocol lists, and they both include SSLv2. Not nitpicking here, just