Re: [VOTE] Release Apache Tomcat 8.0.17

2015-01-15 Thread Ognjen Blagojevic
Mark, On 9.1.2015 19:26, Mark Thomas wrote: The proposed Apache Tomcat 8.0.17 release is now available for voting. ... The proposed 8.0.17 release is: [ ] Broken - do not release [x] Stable - go ahead and release as 8.0.17 Tested .zip distribution on Windows 7 64-bit and Oracle JDK 1.7.0_67:

svn commit: r1651999 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:20:48 2015 New Revision: 1651999 URL: http://svn.apache.org/r1651999 Log: Add a TODO Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/v

svn commit: r1651998 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractInputBuffer.java InternalAprInputBuffer.java InternalNio2InputBuffer.java InternalNioInputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:20:42 2015 New Revision: 1651998 URL: http://svn.apache.org/r1651998 Log: Revert the parallel ByteBuffer idea Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.j

svn commit: r1652000 - in /tomcat/trunk/java/org/apache/coyote/http11: InternalAprInputBuffer.java InternalNioInputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:20:53 2015 New Revision: 1652000 URL: http://svn.apache.org/r1652000 Log: APR: - Simplify. - Correct test for exceeded the max header size. NIO - Use read method from SocketWrapper Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer

svn commit: r1652001 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:00 2015 New Revision: 1652001 URL: http://svn.apache.org/r1652001 Log: Remove unused code. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java URL: http

svn commit: r1652002 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:08 2015 New Revision: 1652002 URL: http://svn.apache.org/r1652002 Log: NIO reafctoring - Use read from socketWrapper rather than HttpNio2InputBuffer - Various API tweaks to support the above Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2

svn commit: r1652005 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:29 2015 New Revision: 1652005 URL: http://svn.apache.org/r1652005 Log: This fixes a unit test failure but I'm not (yet) completely happy that the fix is correct. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/tru

svn commit: r1652004 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:24 2015 New Revision: 1652004 URL: http://svn.apache.org/r1652004 Log: Fix first set of issues found with NIO2 and new SocketBufferHandler Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java tomcat/trunk/java/org/apache/to

svn commit: r1652003 - in /tomcat/trunk/java/org/apache: coyote/http11/ tomcat/util/net/

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:17 2015 New Revision: 1652003 URL: http://svn.apache.org/r1652003 Log: InputBuffer refactoring. All compiles but not yet tested. Added: tomcat/trunk/java/org/apache/tomcat/util/net/SocketBufferHandler.java (with props) Modified: tomcat/trunk/java/or

svn commit: r1652006 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:35 2015 New Revision: 1652006 URL: http://svn.apache.org/r1652006 Log: Trivial - rename - add a TODO Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL:

svn commit: r1652007 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:40 2015 New Revision: 1652007 URL: http://svn.apache.org/r1652007 Log: Fix remaining NIO2 unit test failures after refactoring. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net

svn commit: r1652009 - in /tomcat/trunk/java/org/apache: coyote/http11/InternalAprInputBuffer.java coyote/http11/InternalNio2InputBuffer.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:52 2015 New Revision: 1652009 URL: http://svn.apache.org/r1652009 Log: Align HTTP InputBuffer implementations Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputB

svn commit: r1652008 - in /tomcat/trunk/java/org/apache/coyote/http11: InternalNio2InputBuffer.java InternalNioInputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 09:21:45 2015 New Revision: 1652008 URL: http://svn.apache.org/r1652008 Log: Align formatting to aid checking for differences between the InputBuffer implementations. Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java tomcat/tr

Connector refactoring progress update

2015-01-15 Thread Mark Thomas
The latest series of commits is the prep work for merging the Http11InputBuffer implementations. I'll be doing that shortly. The current status is that the tests pass but performance is currently worse for all connectors but especially for NIO2. Once I complete the InputBuffer merging, I plan on

[Bug 57445] New: java.util.Map$Entry cannot be resolved - jsp's no longer compile under java8

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57445 Bug ID: 57445 Summary: java.util.Map$Entry cannot be resolved - jsp's no longer compile under java8 Product: Tomcat 7 Version: 7.0.56 Hardware: All OS

Re: Connector refactoring progress update

2015-01-15 Thread Rémy Maucherat
2015-01-15 11:11 GMT+01:00 Mark Thomas : > The latest series of commits is the prep work for merging the > Http11InputBuffer implementations. I'll be doing that shortly. > > The current status is that the tests pass but performance is currently > worse for all connectors but especially for NIO2. >

svn commit: r1652041 - /tomcat/trunk/java/org/apache/coyote/http11/

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 10:48:52 2015 New Revision: 1652041 URL: http://svn.apache.org/r1652041 Log: Merge identical InputBuffer implementations into the abstract base class. Removed: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java tomcat/trunk/java/org/apach

svn commit: r1652042 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java AbstractInputBuffer.java Http11AprProcessor.java Http11InputBuffer.java Http11Nio2Processor.java Htt

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 10:49:25 2015 New Revision: 1652042 URL: http://svn.apache.org/r1652042 Log: Rename Added: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java - copied, changed from r1652041, tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.ja

svn commit: r1652048 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11InputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 11:05:40 2015 New Revision: 1652048 URL: http://svn.apache.org/r1652048 Log: Remove unused code. Reduce field and method visibility. Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java tomcat/trunk/java/org/apache/coyote/http11/

svn commit: r1652051 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 11:07:07 2015 New Revision: 1652051 URL: http://svn.apache.org/r1652051 Log: Reduce visibility. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java URL: http://

svn commit: r1652055 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11Nio2Processor.java Http11NioProcessor.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 11:12:34 2015 New Revision: 1652055 URL: http://svn.apache.org/r1652055 Log: Reduce duplication in HttpProcessor implementation constructors Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java tomcat/trunk/java/org/apache/coyote

[Bug 57446] New: Catalina presents a wrapped ServletContext in de-init phase to application listeners

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57446 Bug ID: 57446 Summary: Catalina presents a wrapped ServletContext in de-init phase to application listeners Product: Tomcat 8 Version: 8.0.9 Hardware: PC

Re: Connector refactoring progress update

2015-01-15 Thread Mark Thomas
On 15/01/2015 10:25, Rémy Maucherat wrote: > 2015-01-15 11:11 GMT+01:00 Mark Thomas : > >> The latest series of commits is the prep work for merging the >> Http11InputBuffer implementations. I'll be doing that shortly. >> >> The current status is that the tests pass but performance is currently >>

Re: Connector refactoring progress update

2015-01-15 Thread Rémy Maucherat
2015-01-15 13:21 GMT+01:00 Mark Thomas : > Thanks for the pointer. That explains what I was seeing. I had > maxKeepAliveRequests at the default so the delay was impacting the > results. Ignore the delay and the 8.0.x vs. 9.0.x results are comparable. > > I'll take a look and see if I can figure ou

[VOTE][RESULT] Release Apache Tomcat 8.0.17

2015-01-15 Thread Mark Thomas
The following votes were cast: Binding: +1: violetagg, markt, remm, kkolinko, jfarcand, schultz Non-binding +1: fschumacher, mgrigorov, Ognjen Blagojevic No other votes were case. The votes therefore passes. I'll start the remaining steps of the release process shortly. Mark

svn commit: r1652108 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread remm
Author: remm Date: Thu Jan 15 14:28:13 2015 New Revision: 1652108 URL: http://svn.apache.org/r1652108 Log: Fix use of the semaphore (it seems equivalent to not using it). This fixes the ab corruption I was experiencing. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

svn commit: r1652121 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 14:56:48 2015 New Revision: 1652121 URL: http://svn.apache.org/r1652121 Log: No need for volatile here. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http:

svn commit: r1652122 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 14:56:53 2015 New Revision: 1652122 URL: http://svn.apache.org/r1652122 Log: Simplify Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/v

svn commit: r1652123 - in /tomcat/trunk/java/org/apache: coyote/http11/upgrade/UpgradeServletInputStream.java tomcat/util/net/AprEndpoint.java tomcat/util/net/Nio2Endpoint.java tomcat/util/net/NioEndp

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 14:56:59 2015 New Revision: 1652123 URL: http://svn.apache.org/r1652123 Log: Rename for clarity. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServletInputStream.java tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java to

svn commit: r1652124 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 14:57:04 2015 New Revision: 1652124 URL: http://svn.apache.org/r1652124 Log: Minor optimisation - remove unnecessary call. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoi

svn commit: r1652139 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketBufferHandler.java

2015-01-15 Thread remm
Author: remm Date: Thu Jan 15 15:41:02 2015 New Revision: 1652139 URL: http://svn.apache.org/r1652139 Log: Fix SSL NIO2 tests (and a glitch with non blocking probably), no idea how this happened since there's the same isEmpty for the write buffer. Modified: tomcat/trunk/java/org/apache/tomca

Re: svn commit: r1652108 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread Mark Thomas
On 15/01/2015 14:28, r...@apache.org wrote: > Author: remm > Date: Thu Jan 15 14:28:13 2015 > New Revision: 1652108 > > URL: http://svn.apache.org/r1652108 > Log: > Fix use of the semaphore (it seems equivalent to not using it). This fixes > the ab corruption I was experiencing. Thanks. That fix

Re: svn commit: r1652139 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketBufferHandler.java

2015-01-15 Thread Mark Thomas
On 15/01/2015 15:41, r...@apache.org wrote: > Author: remm Date: Thu Jan 15 15:41:02 2015 New Revision: 1652139 > > URL: http://svn.apache.org/r1652139 Log: Fix SSL NIO2 tests (and a > glitch with non blocking probably), no idea how this happened since > there's the same isEmpty for the write buff

[Bug 57445] java.util.Map$Entry cannot be resolved - jsp's no longer compile under java8

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57445 --- Comment #1 from Christopher Schultz --- Care to post a sample JSP? Are you sure you don't have an old ECJ library laying around? -- You are receiving this mail because: You are the assignee for the bug. -

Re: svn commit: r1652108 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread Rémy Maucherat
2015-01-15 17:03 GMT+01:00 Mark Thomas : > On 15/01/2015 14:28, r...@apache.org wrote: > > Author: remm > > Date: Thu Jan 15 14:28:13 2015 > > New Revision: 1652108 > > > > URL: http://svn.apache.org/r1652108 > > Log: > > Fix use of the semaphore (it seems equivalent to not using it). This > fixes

svn commit: r1652240 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 19:19:11 2015 New Revision: 1652240 URL: http://svn.apache.org/r1652240 Log: Remove incorrect comment Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor

svn commit: r1652252 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2015-01-15 Thread markt
Author: markt Date: Thu Jan 15 19:35:39 2015 New Revision: 1652252 URL: http://svn.apache.org/r1652252 Log: Make a couple of fields final and remove some unnecessary code. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java Modified: tomcat/trunk/java/org/apache/coyot

Re: svn commit: r1652108 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-01-15 Thread Mark Thomas
On 15/01/2015 18:24, Rémy Maucherat wrote: > 2015-01-15 17:03 GMT+01:00 Mark Thomas : > >> On 15/01/2015 14:28, r...@apache.org wrote: >>> Author: remm >>> Date: Thu Jan 15 14:28:13 2015 >>> New Revision: 1652108 >>> >>> URL: http://svn.apache.org/r1652108 >>> Log: >>> Fix use of the semaphore (it

[Bug 57282] request process UML diagram seems outdated

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #14 from Stephen Chen --- Created attachment 32368 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32368&action=edit Revised(V3) request process according to Mark's comment -- You are receiving this mail because: Yo

[Bug 57282] request process UML diagram seems outdated

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #15 from Stephen Chen --- Created attachment 32369 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32369&action=edit Revised(V3) authenticate process according to Mark's comment -- You are receiving this mail becaus

[Bug 57282] request process UML diagram seems outdated

2015-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #16 from Stephen Chen --- (In reply to Mark Thomas from comment #13) > Broadly it looks OK but the detail around the Pipelines isn't right. Calls > to getFirst() are missing and some method names shown don't exist. Also > method

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-01-15 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-01-15 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th